http://bugzilla.suse.com/show_bug.cgi?id=974627 Max Lin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dimstar@opensuse.org -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 Antonio Larrosa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alarrosa@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c3 --- Comment #3 from Max Lin --- (In reply to Hrvoje Senjan from comment #2)

There was one focus-related bugfix in Qt 5.6 that sounds it could be related http://code.qt.io/cgit/qt/qtbase.git/commit/ ?id=8eaf3352590690079735eda9fb872ec8c9c58f0a Dunno where/how YaST calls it's installation window. If we can try somewhere with the above commit reverted?

This commit should not included in 5.6.0 but 5.6.1. And actually I've tried a dud within this commit https://build.opensuse.org/package/show/home:mlin7442:branches:KDE:Qt5/libqt... , doesn't help(not getting better/worse) for this issue. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c5 --- Comment #5 from Max Lin --- (In reply to Stefan Hundhammer from comment #4)

Does the window have the keyboard focus? (Click into the window to make sure)

I'm assumed "Click" here mean to click mouse button, if so, everything is *back to work(keyboard focus and shortcuts)* after a mouse click, but before a mouse click, keyboard shortcut does not work, even F10 key does not work too. And I've a question about keyboard focus, we've UI.SetFocus(Id(:language)) in yast2-installation, if I understand it correct, Language combobox will turn to green color, but it didn't when this issue happened.

Does the "Tab" key move the keyboard focus around from one widget to the next?

after a mouse click, yes. before a mouse click, nope. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c6 --- Comment #6 from Stefan Hundhammer --- OK, so the real problem seems to be that this window does not have the keyboard focus by default. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 Ludwig Nussel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcrozat@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c7 --- Comment #7 from Max Lin --- Qt 5.6 updates were passed SP2 staging openqa check, that is surprised me, one of the difference I can see is SP2 staging iso had the beta warning dialog currently, thus we've made a openSUSE Staging iso within the beta warning(added BETA_VERSION productoption to kiwi file), and it really did work[1], so we're assumed when the beta warning dialog popup it *grabbed the proper focus*. Any idea why the first screen(without beta warning dialog) seems can not grab the proper focus? If you need any log, information or to do any kind of testing from me, please feel free let me know. [1] https://openqa.opensuse.org/tests/139914 -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c8 --- Comment #8 from Max Lin --- (In reply to Max Lin from comment #7)

Qt 5.6 updates were passed SP2 staging openqa check, that is surprised me, one of the difference I can see is SP2 staging iso had the beta warning dialog currently, thus we've made a openSUSE Staging iso within the beta warning(added BETA_VERSION productoption to kiwi file), and it really did work[1], so we're assumed when the beta warning dialog popup it *grabbed the proper focus*. Any idea why the first screen(without beta warning dialog) seems can not grab the proper focus? If you need any log, information or to do any kind of testing from me, please feel free let me know.

[1] https://openqa.opensuse.org/tests/139914

oh, and *the focus* here I was mean keyboard focus. In [1] it pressed "return" when found beta warning dialog popup. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 Stefan Behlert changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c15 --- Comment #15 from Stefan Hundhammer --- IMHO this problem is on the Qt side. It might also be the window manager we are using during installation, but if the problem appears since that new Qt 5.6, it really looks like a Qt problem. Back many years ago, we did not use a window manager during installation, so we drew our own window borders and actively grabbed the keyboard focus for each new window. But of course this is highly antisocial behaviour, and it led to all kinds of problems. Those problems went away when we introducted a window manager during installation and no longer actively grabbed the keyboard focus. AFAIK that worked well throughout many years - until this Qt 5.6. So this would be the obvious place for any fix. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c17 Egbert Eich changed: What |Removed |Added ---------------------------------------------------------------------------- Component|X.Org |YaST2 QA Contact|xorg-maintainer-bugs@forge. |jsrain@suse.com |provo.novell.com | --- Comment #17 from Egbert Eich --- It's not Xorg that's to be blamed on everything. So moving it back to YaST - until proven guilty. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c19 --- Comment #19 from Ludwig Nussel --- Guys, this is not an easy problem. Max already spent days on debugging and bisecting this without conclusion. So even if you don't think your area if responsibility is to blame your experience in debugging strange X quirks would be very valuable. At this point it is still unclear whether the problem is actually due to qt doing something wrong. Maybe it' s a behavior change that suddenly uncovers a bug elsewhere. Maybe is a coincidental combination of qt, X, YaST and icewm. Any help to shed light on this case appreciated. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c20 --- Comment #20 from Max Lin --- (In reply to Stefan Hundhammer from comment #16)

Reassigning to Qt maintainer.

Max, to put it short, the scenario is this:

With Qt 5.6, a new window does not seem to get the keyboard focus automatically. This behaviour seems to have changed between Qt 5.5 and Qt 5.6.

AFAIK we are using IceWM during installation (needs to be checked).

Dear, it's openSUSE, I'm not openSUSE Qt5 maintainer actually, but I don't mind it was assigned to me as we've same problem in SLE :) Anyway, I need any advice from YaST team, according to the result below I found, where is the right direction I should investigate to? 1) The issue is only happened on installer. I've tried pure qt application qdbusviewer from qt 5.6, didn't see either focus problem or shortcuts problem. 2) Seems the issue is only appears in *first time* launched installer, I've tried killed installer and relaunch it, the issue haven't appear in second time. 3) I assumed the working installer should set focus on the language list(a YQComboBox?) like [1], but with this issue, it doesn't[2]. 4) From what we learnt from Staging:E, this issue a bit random, not every time we lost focus. 5) I can reproduced the issue with Qt 5.6.0 Alpha1, but not on 5.5 branch from git, so probably something bad merged into 5.6 but not in 5.5 is the culprit caused this issue, not sure though. [1] https://openqa.opensuse.org/tests/175595/modules/welcome/steps/1 [2] https://openqa.opensuse.org/tests/174102/modules/installation_mode/steps/2 Any suggestion are welcome. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c23 --- Comment #23 from Stefan Hundhammer --- Not very surprisingly, there is no difference in any of the relevant q*x11*cpp files between Qt 5.5 and Qt 5.6: [shundhammer @ morgul] ...space/src/qt-5.6.0 28 % find . -name "*x11*cpp" | sort ./config.tests/qpa/egl-x11/egl-x11.cpp ./src/gui/doc/snippets/code/src_gui_kernel_qguiapplication_x11.cpp ./src/plugins/platforms/eglfs/deviceintegration/eglfs_x11/qeglfsx11integration.cpp ./src/plugins/platforms/eglfs/deviceintegration/eglfs_x11/qeglfsx11main.cpp ./src/plugins/platforms/offscreen/qoffscreenintegration_x11.cpp ./src/widgets/util/qsystemtrayicon_x11.cpp [shundhammer @ morgul] ...space/src/qt-5.6.0 29 % foreach src ( `find . -name "*x11*cpp" | sort` ) do diff -q ../qt-5.5.1/$src $src done Files ../qt-5.5.1/./src/widgets/util/qsystemtrayicon_x11.cpp and ./src/widgets/util/qsystemtrayicon_x11.cpp differ That last file has differences, but that one is just about system tray items which is irrelevant here. For this test, I used the plain tarballs from https://build.suse.de/package/show/SUSE:SLE-12-SP1:Update/libqt5-qtbase (Qt 5.5.1) and https://build.opensuse.org/package/show/KDE:Qt5/libqt5-qtbase (Qt 5.6.0) -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c26 --- Comment #26 from Stefan Hundhammer --- Great work, guys! Parallel to that, I went through the diffs in src/gui/kernel between those Qt 5.5 and 5.6 sources. They shows a lot of differences, but nothing obvious that seems to be related to the window focus. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c30 --- Comment #30 from Dominique Leuenberger --- (In reply to Antonio Larrosa from comment #29)

After much debugging of icewm, I took a different route, since I wondered what Yast was doing exactly in its startup. Finally, I dived a bit on yast sources and fixed the issue with this patch: https://github.com/libyui/libyui-qt/pull/54

icewm still has broken focus policies, but I think yast should request the focus when running fullscreen anyway.

Thank you Antonio! Great job! -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=974627 http://bugzilla.suse.com/show_bug.cgi?id=974627#c33 Antonio Larrosa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #33 from Antonio Larrosa --- Tested and fixed with the pull request mentioned in comment #29 -- You are receiving this mail because: You are on the CC list for the bug.