https://bugzilla.novell.com/show_bug.cgi?id=382202 Stephan Kulow changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.provo.novell.com |sh@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User dave.plater@yahoo.co.uk added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c3 --- Comment #3 from Dave Plater 2008-04-22 07:54:47 MST --- Sorry I'm using yast2-qt-pkg-2.16.37-2.1 with working version tabs, from build service maybe when the rest of yast2 catches up it will go away or maybe its a bug that is yet to come. All the rest of my yast2 is Factory. I can live with it for now, the working version tab is very nice. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 Dave Plater changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Major -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Major |Normal -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User robin.knapp@fujitsu-siemens.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c7 --- Comment #7 from Robin Knapp 2008-04-25 04:37:11 MST --- reopening, because it's 100% reproducible with the beta1 live cd (kde). logfile does not show anything while pressing "cancel", should I attach one anyway? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c9 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #9 from Stefan Hundhammer 2008-04-25 06:08:07 MST --- Trying again, I can now reproduce it on Beta1, too: - change some package status in the package selector - use WM_CLOSE (not the "Cancel" button) in the package selector - use WM_CLOSE in the "Abandon all changes?" pop-up (not the "Cancel" button) -> window closes, but y2base will remain active -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c11 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmueller@novell.com, coolo@novell.com --- Comment #11 from Stefan Hundhammer 2008-04-25 07:38:31 MST --- I made a debugging version of this that shows the same effect. 406 bool YQPackageSelectorBase::eventFilter( QObject * obj, QEvent * event ) 407 { 408 if ( event->type() == QEvent::Close ) 409 { 410 // Handle WM_CLOSE like "Cancel" 411 reject(); 412 413 return true; // Stop processing this event 414 } 415 416 return false; // Don't stop processing this event 417 } 198 YQPackageSelectorBase::reject() 199 { 200 bool changes = 201 zyppPool().diffState() || 202 zyppPool().diffState() || 203 zyppPool().diffState(); 204 205 if ( changes ) 206 { 207 if ( zyppPool().diffStatezypp::Package() ) 208 yuiMilestone() << "diffState() reports changed packages" << endl; 209 210 if ( zyppPool().diffStatezypp::Pattern() ) 211 yuiMilestone() << "diffState() reports changed patterns" << endl; 212 213 if ( zyppPool().diffStatezypp::Patch() ) 214 yuiMilestone() << "diffState() reports changed patches" << endl; 215 } 216 217 #warning DEBUG - remove this before check-in! 218 changes = true; 219 220 bool doCancel = true; 221 222 if ( changes ) 223 { 224 yuiMilestone() << "Packages changed - asking for confirmation" << endl; 225 226 int button = QMessageBox::warning( this, "", 227 _( "Abandon all changes?" ), 228 _( "&Abandon" ), _( "&Cancel" ), "", 229 1, // defaultButtonNumber (from 0) 230 1 ); // escapeButtonNumber 231 232 yuiMilestone() << "\"Abandon all changes\" dialog closed with " << button << endl; 233 doCancel = ( button == 0 ); // OK 234 } 235 else 236 { 237 yuiMilestone() << "No changes" << endl; 238 } 239 240 if ( doCancel ) 241 { 242 zyppPool().restoreState(); 243 zyppPool().restoreState(); 244 zyppPool().restoreState(); 245 246 yuiMilestone() << "Closing PackageSelector with \"Cancel\"" << endl; 247 YQUI::ui()->sendEvent( new YCancelEvent() ); 248 } 249 else 250 { 251 yuiMilestone() << "NOT closing PackageSelector" << endl; 252 } 253 } y2log from the sample GDB session that will follow: 2008-04-25 15:26:38 <1> snell(7945) [qt-pkg] YQPackageSelector.cc(YQPackageSelector):193 PackageSelector init done 2008-04-25 15:26:38 <1> snell(7945) [ui] YCP_UI.cc(RunPkgSelection):1386 Running package selection... 2008-04-25 15:26:49 <1> snell(7945) [qt-pkg] YQPackageSelectorBase.cc(reject):224 Packages changed - asking for confirmation 2008-04-25 15:26:58 <1> snell(7945) [qt-pkg] YQPackageSelectorBase.cc(reject):232 "Abandon all changes" dialog closed with 1 2008-04-25 15:27:03 <1> snell(7945) [qt-pkg] YQPackageSelectorBase.cc(reject):251 NOT closing PackageSelector GDB session: [sh @ snell] ...trunk/ycp-ui-bindings/examples 3 % gdb =y2base GNU gdb 6.5 Copyright (C) 2006 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for details. This GDB was configured as "i586-suse-linux"...Using host libthread_db library "/lib/libthread_db.so.1". (gdb) break YQPackageSelectorBase::251 Can't find member of namespace, class, struct, or union named "YQPackageSelectorBase::251" Hint: try 'YQPackageSelectorBase::251<TAB> or 'YQPackageSelectorBase::251 (Note leading single quote.) (gdb) break YQPackageSelectorBase.cc:251 No source file named YQPackageSelectorBase.cc. Make breakpoint pending on future shared library load? (y or [n]) y Breakpoint 1 (YQPackageSelectorBase.cc:251) pending. (gdb) run ./PackageSelector-empty.ycp qt Starting program: /suse/sh/util/y2base ./PackageSelector-empty.ycp qt Failed to read a valid object file image from memory. [Thread debugging using libthread_db enabled] [New Thread -1214175536 (LWP 7945)] [New Thread -1231852656 (LWP 7951)] Breakpoint 2 at 0xb5f6371c: file /local_home/sh/yast2/trunk/qt-pkg/src/YQPackageSelectorBase.cc, line 251. Pending breakpoint "YQPackageSelectorBase.cc:251" resolved [Switching to Thread -1231852656 (LWP 7951)] Breakpoint 2, YQPackageSelectorBase::reject (this=0x807dd38) at /local_home/sh/yast2/trunk/qt-pkg/src/YQPackageSelectorBase.cc:251 251 yuiMilestone() << "NOT closing PackageSelector" << endl; Current language: auto; currently c++ (gdb) n 253 } (gdb) s YQPackageSelectorBase::eventFilter (this=0x807dd38, obj=0x80ae608, event=0xb6935724) at /local_home/sh/yast2/trunk/qt-pkg/src/YQPackageSelectorBase.cc:413 413 return true; // Stop processing this event (gdb) s 417 } (gdb) s 0xb6ce0341 in QApplicationPrivate::notify_helper () from /usr/lib/libQtGui.so.4 (gdb) s Single stepping until exit from function _ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent, which has no line number information. 0xb6ce653e in QApplication::notify () from /usr/lib/libQtGui.so.4 (gdb) s Single stepping until exit from function _ZN12QApplication6notifyEP7QObjectP6QEvent, which has no line number information. 0xb7338c8b in QCoreApplication::notifyInternal () from /usr/lib/libQtCore.so.4 The main window (!) closes here. IMHO this is a bug in Qt. Coolo? Dirk? Any hint? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c13 --- Comment #13 from Stefan Hundhammer 2008-04-25 07:46:40 MST --- BTW in the constructor there is also // Install event handler to handle WM_CLOSE like "Cancel" topLevelWidget()->installEventFilter( this ); This should redirect a WM_CLOSE of the parent dialog to this widget, which obviously works since we can see the log output of this widget's reject() method here. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User robin.knapp@fujitsu-siemens.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c15 --- Comment #15 from Robin Knapp 2008-04-25 08:05:02 MST --- mhh.. this is strange. The window closes here even if I press "cancel" in the popup. But maybe this is somehow related? I don't understand much of that debugging stuff (I'm not a coder...) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User dmueller@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c17 --- Comment #17 from Dirk Mueller 2008-04-25 09:44:54 MST --- are those dialogs inheriting qdialog? did you try without those eventfilters? I don't know what they're good for, but it is the default behaviour to handle closed dialogs as reject(). don't forget to destruct them when they close though.. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User dave.plater@yahoo.co.uk added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c19 --- Comment #19 from Dave Plater 2008-05-21 08:22:05 MST --- Is this bug ever going to be fixed? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Yast2 software manager does not close properly |Yast2 software manager does not close properly | |with WM_CLOSE -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c21 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |siegfried.olschner@novell.com --- Comment #21 from Stefan Hundhammer 2008-06-17 07:21:22 MDT --- *** Bug 374364 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=374364 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|# |#a07d -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User dave.plater@yahoo.co.uk added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c23 --- Comment #23 from Dave Plater 2008-10-07 11:44:08 MDT --- Confirm its fixed. Got so used to not using wm_close I forgot to test it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|#a07d |#b3ad -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c26 --- Comment #26 from Stefan Hundhammer 2008-10-09 05:27:53 MDT --- Created an attachment (id=244564) --> (https://bugzilla.novell.com/attachment.cgi?id=244564) gdb session This gdb session shows a simple test case (y2base PackageSelector.ycp qt) in this situation: Clicking the WM_CLOSE button on the toplevel window after there were changes, posting the "Abandon all changes?" pop-up (QMessageBox::warning()), clicking "Cancel" there - and oops, all windows are gone, but the y2base process is still running. To me it looks like QWidgetPrivate::close_helper() does not even try to honor any event filter's return value that says "do not proceed any further in processing this event". It always just deletes the toplevel window and all its widgets. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User dave.plater@yahoo.co.uk added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c27 --- Comment #27 from Dave Plater 2008-10-09 06:07:21 MDT --- I only run kde3.5.10 as desktop but I installed kde4 kwrite which is AFIK qt4, I loaded a file, altered it, and then clicked WM_CLOSE and was presented with 3 choices discard, save and cancel. If I click cancel I get returned to kwrite which is expected behavior. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=382202 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382202#c29 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #29 from Stefan Hundhammer 2008-10-09 09:40:40 MDT --- Now using a completely different method to handle this, based on (libyui level) YEventFilters and QDialog::close(). Unlike Qt-level event filters as described above, this method works reliably. Available with yast2-qt-pkg-2.17.10. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.