[Bug 749031] New: pm-utils-1.4.1-5.11.1.i586 misses functions and script 50rcnetwork contains errors
https://bugzilla.novell.com/show_bug.cgi?id=749031 https://bugzilla.novell.com/show_bug.cgi?id=749031#c0 Summary: pm-utils-1.4.1-5.11.1.i586 misses functions and script 50rcnetwork contains errors Classification: openSUSE Product: openSUSE 11.4 Version: Final Platform: x86-64 OS/Version: openSUSE 11.4 Status: NEW Severity: Major Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: guy.zelck@telenet.be QAContact: qa@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.1) Gecko/20100101 Firefox/10.0.1 1. functions dhcp_clients, save_state and restore_state are missing from the package or the 11.4 distribution so this script cannot work as supposed to. 2.command_exists dhcp_clients || exit $NA Early in the script this test will make you exit. So nothing will be processes for Networkmanager or ifup/ifdown setups. 3. [ x"${NETWORKMANAGER}" -eq x"yes" ] && exit $NA If you compare strings you need to use "=", not "-eq". Reproducible: Always Steps to Reproduce: 1.suspend to disk 2.ressume from disk 3. => no wlan0 8-( I have a desktop with a wireless main connection (wlan0) set up with ifdown/ifup because the box needs to function as a network server at home. In stead of shutting down I use "suspend to disk" which functionally works great. Ofcourse, the scripts need to be correct to realy enjoy it. It's easily fixed but as of now if breaks a main feature. So please give this priority as it makes Linux and Opensuse look bad. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c1
Li Bin
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.1) Gecko/20100101 Firefox/10.0.1
1. functions dhcp_clients, save_state and restore_state are missing from the package or the 11.4 distribution so this script cannot work as supposed to. Looks the save_state/restore_state change to savestate/restorestate. dhcp_clients change to dhcp_interfaces? Not sure.
2.command_exists dhcp_clients || exit $NA Early in the script this test will make you exit. So nothing will be processes for Networkmanager or ifup/ifdown setups. Yes, it doesn't work anymore.
3. [ x"${NETWORKMANAGER}" -eq x"yes" ] && exit $NA If you compare strings you need to use "=", not "-eq". Yes, we should change it.
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c2
Li Bin
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c3
Marius Tomaschewski
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c4
--- Comment #4 from Li Bin
I've no idea. I'll look into pm-utils.
Thanks for quick reply, and this network script was added at bnc#603291, it's in pm-utils-suse which owned by suse-self. :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c5
Marius Tomaschewski
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c6
--- Comment #6 from Marius Tomaschewski
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c7
--- Comment #7 from Guy Zelck
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c8
--- Comment #8 from Li Bin
Created an attachment (id=478133) --> (http://bugzilla.novell.com/attachment.cgi?id=478133) [details] Proposed patch
Thanks a lot! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c9
--- Comment #9 from Li Bin
The attachment is not quite correct.
I followed Bin Li's leads, adapted the script and did a suspend/resume test => OK.
The body of the script should have this in it :
============================================================================ . "${PM_FUNCTIONS}"
# Sanity checks [ -x /etc/init.d/network ] || exit $NA [ -r /etc/sysconfig/network/config ] && . /etc/sysconfig/network/config [ -r /etc/sysconfig/network/scripts/functions ] && . /etc/sysconfig/network/scripts/functions
command_exists dhcp_interfaces || exit $NA
# NetworkManager is handled by 55NetworkManager, so skip this script if # nm is enabled in sysconfig ... [ x"${NETWORKMANAGER}" = x"yes" ] && exit $NA # ... or if it is running command_exists nm_running && nm_running && exit $NA
case "$1" in hibernate|suspend) savestate "dhcp_interfaces" "`dhcp_interfaces`" service network stop-all-dhcp-clients ;; thaw|resume) for interface in `restorestate "dhcp_interfaces"`; do service network restart ${interface} done ;; *) exit $NA ;; esac
============================================================================
Thanks for the quick reaction.
Thanks for your feedback. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c10
--- Comment #10 from Li Bin
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c11
Li Bin
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c12
Li Bin
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c13
--- Comment #13 from Li Bin
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c14
--- Comment #14 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c15
Li Bin
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c16
--- Comment #16 from Michal Vyskocil
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c17
--- Comment #17 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c18
Benjamin Brunner
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c19
Swamp Workflow Management
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c20
Michal Vyskocil
We will start an update for 11.4 and 12.1 after it is checked in into factory. Please have a look at the decline-message in the factory-submission. For the 11.4 update I'll provide a SWAMP-ID
Hallo Benjamin, I do not understood why you declined the Bin's request - one would expect that update by adding a patch is a preferred workflow for maintenance update. The Factory update is different, but because I have all suse additions in pm-utils-suse (and have a plan to rebase it completelly), so for Factory I've merged all stuff here. So please accept the 107316 as I see nothing bad (well, convert of VTxx patch is not really needed, so here I would expect some problems) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c21
--- Comment #21 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c22
--- Comment #22 from Li Bin
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c23
--- Comment #23 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c24
--- Comment #24 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c25
Benjamin Brunner
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c26
Swamp Workflow Management
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c
Swamp Workflow Management
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c27
Michal Vyskocil
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c28
Li Bin
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c
Vojta Dziewięcki
https://bugzilla.novell.com/show_bug.cgi?id=749031
https://bugzilla.novell.com/show_bug.cgi?id=749031#c29
--- Comment #29 from Bernhard Wiedemann
participants (1)
-
bugzilla_noreply@novell.com