[Bug 925613] New: "osc sr" to submit a group of pakages fails if one package is not a link
http://bugzilla.opensuse.org/show_bug.cgi?id=925613 Bug ID: 925613 Summary: "osc sr" to submit a group of pakages fails if one package is not a link Classification: openSUSE Product: openSUSE.org Version: unspecified Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: BuildService Assignee: bnc-team-screening@forge.provo.novell.com Reporter: dimstar@opensuse.org QA Contact: adrian@suse.com Found By: --- Blocker: --- As in many, if not most. deve, projects, there are packages 'not yet' ready to be submitted to Factory or, are simply not meant to go to Factory... so they are not links. Submitting such a devel project using 'osc sr' (wihtout further parameters, that should result in a submit-request group) fails On the example of GNOME:Next osc co GNOME:Next cd GNOME:Next osc sr -m 'Submitting all awesome changes in one go' Submitting package [xxx] [...] Package gnome-battery-bench is not a source link and no target specified. This is currently not supported. submission aborts at this stage. NOTE: it listed all packages to be submitted up to this point (except the ones linking to the same project); despite only a handful of packages actually having changes in GNOME:Next at this moment. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=925613
Dominique Leuenberger
http://bugzilla.opensuse.org/show_bug.cgi?id=925613
--- Comment #1 from Adrian Schröter
http://bugzilla.opensuse.org/show_bug.cgi?id=925613
Adrian Schröter
http://bugzilla.opensuse.org/show_bug.cgi?id=925613
Dominique Leuenberger
http://bugzilla.opensuse.org/show_bug.cgi?id=925613
--- Comment #4 from Adrian Schröter
http://bugzilla.opensuse.org/show_bug.cgi?id=925613
--- Comment #5 from Dominique Leuenberger
http://bugzilla.opensuse.org/show_bug.cgi?id=925613
--- Comment #6 from Adrian Schröter
http://bugzilla.opensuse.org/show_bug.cgi?id=925613
--- Comment #7 from Dominique Leuenberger
we can add an option to ignore packages without links. On the other hand this contradicts the idea that the entire project gets submitted and you again do not know if some other change actually needs this new package.
The assumption that whole devel projects are submitted together, instead of a subset of packages (maintainers responsibility) is a bit bold, especially on large devel projects... Being able to ignore packages, which are not link, sounds very important to me (and I'm sure other devel maintainers, that actually maintain, and not only dump packages in a project).
creating the missing link can be done by either:
* manually before accepting the request (still empty package, so no conflict with request)
Too error prone. This will be forgotten 98% of the times
* We could introduce a new attribute which could be used that all new packages should be links to project X
This is reasonable for 'mostly devel projects' (like GNOME:Apps, KDE:Extra) and could work in those cases
* we can add this link afterwards. without testing it, "osc linkpac -N ..." should add it without breaking the sources. An interactive option in "osc sr" might make sense as well.
Can be used to fixup indeed, but, as it's a manual step on top of the process, will again lead to issues, to be only done when people are trying to push.
any opinions on that?
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=925613
--- Comment #8 from Adrian Schröter
http://bugzilla.opensuse.org/show_bug.cgi?id=925613
--- Comment #9 from Dominique Leuenberger
I take away for now that we want to have the attribute feature as described above and will discuss it within our group before implementing it.
Yes, that sounds reasonable. (besides that, a full workflow still needs to be created for: - Submit a large devel project, e.g. GNOME:Factory (osc sr, all changes one req) - the review team 'somehow' manages to review this. On package 129, there is an error, and the package needs be declined (does that decline the whole group? If so: the whole group has to be resubmitted, resulting in > 100 'new' requests to be reviewed by the team? Or can only the offending package be 'declined' and the group remain 'limbo/inacceptable' until that package is resubmitted and fixed?) Many things can happen here. a package from another devel prj is needed too for example, as it might be found in the <path> structure of my project, but not in openSUSE:Factory in the end... and so on... but different topic, not really 'this' bug. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com