https://bugzilla.novell.com/show_bug.cgi?id=300340#c1 --- Comment #1 from Christopher Stender 2007-08-14 10:50:23 MST --- I forgot to mention that I'm not using kpowersave atm. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340#c3 --- Comment #3 from Christopher Stender 2007-08-14 15:43:17 MST --- I already checked it on two T60 machines. Seems to be a general thinkpad_acpi error. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340#c6 --- Comment #6 from Christopher Stender 2007-08-16 11:31:53 MST --- I can reproduce this with kernel-default and kernel-bigsmp on a T60 and T60p. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340#c8 --- Comment #8 from Holger Macht 2007-08-17 11:46:45 MST --- Ok, the issue is known and already fixed in 2.6.23-rc3. Quoting Henrique de Moraes Holschuh: <quote> Back to the problem... Basically, the firmware does not store in an EC register the brightness level anymore. I can still read it from CMOS, so I added a parameter to let the user choose what the driver should do, and made it use only CMOS for Lenovo boxes. It seems to work on every lenovo box, even those who still update the EC register like IBM thinkpads did. How the firmware behaves depends on Lenovo thinkpad model and BIOS revision. The thruth is, that Lenovo is moving brightness away from the thinkpad mode to the generic ACPI mode in their models. As they update the BIOSes for the older models, they would break as well (x60 is the last one that appears to work in the old way). </quote> So to solve this issue, a lot more work and testing would be needed. I don't know if it is worth the effort. Anyway, I'll attach a proof-of-concept patch which is a backport of what is currently in 2.6.23 regarding the backlight. I'll provide a mbuild next week to test. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340#c10 --- Comment #10 from Christopher Stender 2007-08-21 04:54:45 MST --- Created an attachment (id=158678) --> (https://bugzilla.novell.com/attachment.cgi?id=158678) acpidump (Thinkpad T60 2007-VCE) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340 Thomas Renninger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |cstender@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340#c14 Thomas Renninger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |coolo@novell.com --- Comment #14 from Thomas Renninger 2007-08-24 02:54:37 MST --- This is a real [sb]ad situation. I am not sure whether we should really backport this change. Some things I found in patch from comment #9: 1) don't do this change: - if (ibm_thinkpad_ec_found && experimental) { + if (thinkpad_id.ec_model) { it seems to be thermal related and unrelated to the brightness stuff. Only change the ec_found variable to the newly declared one and still add the && experimental 2) don't add those: + u16 input_device_registered:1; + u16 platform_drv_registered:1; + u16 platform_drv_attrs_registered:1; the first is unused, the latter two come from another patch, which should also go in (done that already, it's a real short fix) 3) Free strings allocated with kstrdup in newly added init in module exit func: + kfree(thinkpad_id.bios_version_str); + kfree(thinkpad_id.ec_version_str); + kfree(thinkpad_id.model_str); I am really unsure whether we should take the risk. If we take it, it should be added soon. I'll post my reworked patch. I am also off for holidays -> someone else need to comit this, Pavel or Andi? -> better give this another review before... We should add some project manager to get an approval for this -> adding coolo for now. Coolo: how important is brightness control on Lenovos? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340#c16 --- Comment #16 from Holger Macht 2007-08-24 03:04:30 MST --- Summarizing the situation, brightness can still be controlled on thinkpads without the patch, but only with the keyboard. Once changed with the keyboard, changing brightness doesn't work with kpowersave/gnome-power-manager anymore. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340#c18 Thomas Renninger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |cstender@novell.com --- Comment #18 from Thomas Renninger 2007-08-24 03:30:25 MST --- I started builds, they will pop up in half an hour or so here: /mounts/work/built/mbuild/stravinsky-trenn-127 (x86_64) /mounts/work/built/mbuild/stravinsky-trenn-128 (i386) It would be great if someone could give it a test boot. Please have a short look into dmesg/syslog whether something bad happens. Some other patches are in there too, could you also try to: - rmmod thinkpad_acpi module when it got loaded and have a look whether errors pop up in syslog then, they should not anymore... - check whether dock module gets loaded automatically (must be Beta2 based, see: https://bugzilla.novell.com/show_bug.cgi?id=302482) I will add the stuff if tests are successful. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340#c20 Christopher Stender changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|cstender@novell.com | --- Comment #20 from Christopher Stender 2007-08-24 10:56:56 MST --- Okay - I did some tests with kernel-default (x86_64) and here is the result: - can't find any kernel related errors in dmesg and syslog - no! docking module loaded tank-testing:~ # lsmod | grep dock tank-testing:~ # dmesg | grep dock tank-testing:~ # - brightness control seems to work (when closing kpowersave), but I noticed some syslog entries when increasing the brightness level: Aug 24 18:24:22 tank-testing logger: thinkpad_acpi_events Custom event script for ThinkPad thinkpad_acpi driver Aug 24 18:24:22 tank-testing logger: thinkpad_acpi_events Fn+Home hotkey: keycode 128 serial 4112. action: brighter display - rmmod thinkpad_acpi && modprobe thinkpad_acpi went fine without any errors in dmesg/syslog -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340#c22 Thomas Renninger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #22 from Thomas Renninger 2007-08-25 00:28:53 MST --- It's in. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=300340#c24 --- Comment #24 from Thomas Renninger 2007-09-17 11:10:32 MST --- ohh, wrong bug :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.