http://bugzilla.novell.com/show_bug.cgi?id=599698 http://bugzilla.novell.com/show_bug.cgi?id=599698#c2 Petr Baudis changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|pbaudis@novell.com |zypp-maintainers@forge.prov | |o.novell.com --- Comment #2 from Petr Baudis 2010-05-18 20:01:42 UTC --- I'm sorry, but you cannot do crazy things like allocate memory within a signal handler. Only very precisely defined subset of standard functions (reentrant functions) is allowed to be called from a signal handler. Otherwise, you get a race condition. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=599698 http://bugzilla.novell.com/show_bug.cgi?id=599698#c4 --- Comment #4 from Michael Andres 2010-05-19 15:25:43 CEST --- Well, it works most of the time :) But not just zypper will leave things behind, also libzypp needs a proper exit to cleanup behind. One alternative is to set just some 'emergency' flag inside the handler, and clutter up the code with 'ifEmergencyExit()' calls. void ifEmergencyExit() { if ( emergency ) { Cleanup(); exit(); } } For an application whithout main event loop this is no fun. But maybe throwing an exception can help you out. struct EmergencyExit {}; void signal_handler( int sig ) { ::signal( SIGINT, SIG_IGN ); ::signal( SIGTERM, SIG_IGN ); if ( serious ) { throw EmergencyExit(); } ... } int main( int argc, char * argv[] ) { try { if (::signal(SIGINT, signal_handler) == SIG_ERR) out.error("Failed to set SIGINT handler."); if (::signal(SIGTERM, signal_handler) == SIG_ERR) out.error("Failed to set SIGTERM handler."); ... } catch ( EmergencyExit ) { Zypper & zypper = *Zypper::instance(); zypper.cleanup(); exit( ZYPPER_EXIT_ON_SIGNAL ); } return 0; } -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=599698 http://bugzilla.novell.com/show_bug.cgi?id=599698#c6 --- Comment #6 from Jon Nelson 2010-05-19 13:32:32 UTC --- One other thing: you can't throw exceptions from signal handlers. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=599698 http://bugzilla.novell.com/show_bug.cgi?id=599698#c8 --- Comment #8 from Jon Nelson 2010-05-20 13:33:31 UTC --- 1. never call exit from a signal handler. exit is *not* the same as _exit 2. functions registered with atexit are not called if the program exits /abnormally/ due to a signal (or _exit, or abort, and so on) 3. using a global variable, and setting it in the signal handler, the "main loop" would then be responsible for calling exit. functions registered with atexit would then execute. You could always use longjmp but that method has even more subtle issues. There might be other ways to handle this but the only "safe" ways I know of involve setting a global (preferably one of type atomic_t) and checking the value of that variable at various points within the flow of the program. Hope this is helpful. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=599698 http://bugzilla.novell.com/show_bug.cgi?id=599698#c9 --- Comment #9 from Jon Nelson 2010-07-21 16:25:14 UTC --- ping? Had the same problem on openSUSE 11.3: sudo zypper search reportlab ^C^[[A^[[ALoading repository data... ^[[AReading installed packages... ^[[A^[[A^C OK OK! Exiting immediately... ^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C and an strace in another terminal: strace -f -p 30780 Process 30780 attached - interrupt to quit futex(0x7f4a7e163e80, FUTEX_WAIT_PRIVATE, 2, NULL -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=599698 https://bugzilla.novell.com/show_bug.cgi?id=599698#c11 --- Comment #11 from Ján Kupec 2010-10-07 08:13:12 UTC --- No news here. The idea of cluttering the code based on some 'exit_asap' flag appeared to me as well, but i was not sure if that would be the best approach. Now i'm a bit more convinced... :O) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=599698 https://bugzilla.novell.com/show_bug.cgi?id=599698#c13 --- Comment #13 from Michael Andres 2010-10-07 12:39:31 CEST --- BTW. what kind of cleanup is needed? As long as you e.g. do not save volatile .repo files in /etc/zypp/repos.d, it would be easy to change the RepoManager to wipe excess dirs below /var/cache/zypp (data of volatile repos as well as leftover temp dirs after crash/^C). Such a check would not cost much, if everything is clean. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=599698 https://bugzilla.novell.com/show_bug.cgi?id=599698#c15 --- Comment #15 from Michael Andres 2010-10-07 16:16:37 CEST --- (In reply to comment #14)

(In reply to comment #13)

...

As long as you e.g. do not save volatile .repo files in /etc/zypp/repos.d, it

hm, i do. zypper in foo.rpm and zypper --plus-repo does temporarily add such repo. But i guess this could be done without it, right?

Yes, a RepoInfo in memory should be sufficient.

Then there are also leftovers from downloads in /var/adm/mount, tmp files from keyring manipulation (maybe not an issue), maybe more.

Should be solvable too, as we usually use temp. dirs. We could create a files in the tmpdirs root -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=599698 https://bugzilla.novell.com/show_bug.cgi?id=599698#c17 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 - Medium |P2 - High Status|NEW |ASSIGNED CC| |jkupec@novell.com AssignedTo|zypp-maintainers@forge.prov |jkupec@novell.com |o.novell.com | --- Comment #17 from Ján Kupec 2010-10-14 15:50:47 UTC --- OK, this looks like a good approach. I'll start with zypper using in-memory additional repos and RepoManager cleanup. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=599698 https://bugzilla.novell.com/show_bug.cgi?id=599698#c20 Michael Andres changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #20 from Michael Andres 2013-01-24 11:12:33 CET --- Looks like Jano at least started to fix this. Don't know if the fix is actually complete, OTOH there are no more complaints. Closing it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.