https://bugzilla.novell.com/show_bug.cgi?id=349604 Ivan Zlatev changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |341831 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=349604 User contact@i-nz.net added comment https://bugzilla.novell.com/show_bug.cgi?id=349604#c2 Ivan Zlatev changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188132|0 |1 is obsolete| | --- Comment #2 from Ivan Zlatev 2007-12-18 15:27:25 MST --- Created an attachment (id=188137) --> (https://bugzilla.novell.com/attachment.cgi?id=188137) Updated patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=349604 User federico@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=349604#c4 Federico Mena Quintero changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |federico@novell.com Status|NEW |NEEDINFO Info Provider| |contact@i-nz.net --- Comment #4 from Federico Mena Quintero 2007-12-18 17:31:01 MST --- Thanks for the patch! Now it just needs to actually use the label. After calling create_item(), I think you can just do g_bookmark_file_set_title (priv->store, uri, label + 1); Later, when update_items() runs, it will call g_bookmark_file_get_title() and retrieve the label that you set. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=349604 User contact@i-nz.net added comment https://bugzilla.novell.com/show_bug.cgi?id=349604#c6 Ivan Zlatev changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188137|0 |1 is obsolete| | Attachment #188153|0 |1 is obsolete| | Status|NEEDINFO |NEW Info Provider|contact@i-nz.net | --- Comment #6 from Ivan Zlatev 2007-12-18 17:48:03 MST --- Created an attachment (id=188154) --> (https://bugzilla.novell.com/attachment.cgi?id=188154) Updated patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=349604 User contact@i-nz.net added comment https://bugzilla.novell.com/show_bug.cgi?id=349604#c8 Ivan Zlatev changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188157|0 |1 is obsolete| | --- Comment #8 from Ivan Zlatev 2007-12-18 18:31:15 MST --- Created an attachment (id=188159) --> (https://bugzilla.novell.com/attachment.cgi?id=188159) Updated patch This one will compare title names only for USER_DIRS. Should be better optimization-wise. Cheers. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=349604 Ivan Zlatev changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|contact@i-nz.net |bnc-team-gnome@forge.provo.novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=349604 User sreeves@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=349604#c11 Scott Reeves changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188159|0 |1 is obsolete| | --- Comment #11 from Scott Reeves 2008-01-29 12:23:15 MST --- Created an attachment (id=192206) --> (https://bugzilla.novell.com/attachment.cgi?id=192206) updated patch to fix segfault Thanks for the patch - couple of fixes to it. Add a bookmark via nautilus and do not set a label initially. Then later if you edit that bookmark and add a label the patch will segfault in the strcmp in update_items as priv->items[i]->title is null If you delete an existing title the patch will not update the display as it exits the check because title is null If there is no title it needs to fall back and compare the uri for differences (for reordering which is not supported yet but will be) updated patch to fix this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=349604 Magnus Boman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |captain.magnus@opensuse.org Status Whiteboard| |gnomeup-gnome-main-menu -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.