https://bugzilla.novell.com/show_bug.cgi?id=840228 https://bugzilla.novell.com/show_bug.cgi?id=840228#c0 Summary: YCP to Ruby translator destroyed some comments in the code Classification: openSUSE Product: openSUSE Factory Version: 13.1 Milestone 4 Platform: All OS/Version: SUSE Other Status: NEW Severity: Major Priority: P5 - None Component: YaST2 AssignedTo: yast2-maintainers@suse.de ReportedBy: jsmeix@suse.com QAContact: jsrain@suse.com Found By: Development Blocker: --- I found some comments in the yast2-printer code that got destroyed by the YCP to Ruby translator. What I found up to now is that sometimes the first line of a comment got lost or was misplaced elsewhere. Examples: In yast2-printer-2.23.1 YCP there was in src/Printer.ycp (long lines wrapped here): ------------------------------------------------------------------------------- // what might be the reason why the server is not accessible via port 631. string netcat_test_fail_message = sformat( // Popup message // where %1 will be replaced by the server name. _("The server '%1' is not accessible via port 631 (IPP/CUPS)."), server_name ); string ping_test_good_message = sformat( // Popup message // where %1 will be replaced by the server name. _("The server '%1' responds to a 'ping' in the network."), server_name ); ------------------------------------------------------------------------------- In yast2-printer-3.0.0 Ruby it has become in src/modules/Printer.rb ------------------------------------------------------------------------------- # what might be the reason why the server is not accessible via port 631. netcat_test_fail_message = Builtins.sformat( # where %1 will be replaced by the server name. _("The server '%1' is not accessible via port 631 (IPP/CUPS)."), server_name ) # Popup message ping_test_good_message = Builtins.sformat( # where %1 will be replaced by the server name. _("The server '%1' responds to a 'ping' in the network."), server_name ) # Popup message ------------------------------------------------------------------------------- In yast2-printer-2.23.1 YCP there was in src/driveradd.ycp (long lines wrapped here): ------------------------------------------------------------------------------- if( hplip_install != hplip_installed ) { if( hplip_install ) { // When hpijs-standalone is installed, it must be removed first of all // because hpijs-standalone conflicts with hplip-hpijs which is required by hplip. ------------------------------------------------------------------------------- In yast2-printer-3.0.0 Ruby it has become in src/include/printer/driveradd.rb ------------------------------------------------------------------------------- if hplip_install != hplip_installed if hplip_install # because hpijs-standalone conflicts with hplip-hpijs which is required by hplip. ------------------------------------------------------------------------------- In yast2-printer-2.23.1 YCP there was in src/driveradd.ycp (long lines wrapped here): ------------------------------------------------------------------------------- { if( Printerlib::TestAndInstallPackage( "hplip", "install" ) ) { package_changed = true; } else { // We are here either when the user has rejected to install hplip // or if the installation of hplip has actually failed. ------------------------------------------------------------------------------- In yast2-printer-3.0.0 Ruby it has become in src/include/printer/driveradd.rb ------------------------------------------------------------------------------- if Printerlib.TestAndInstallPackage("hplip", "install") package_changed = true else # or if the installation of hplip has actually failed. ------------------------------------------------------------------------------- In yast2-printer-2.23.1 YCP there was in src/driveradd.ycp (long lines wrapped here): ------------------------------------------------------------------------------- if( Printerlib::TestAndInstallPackage( "hpijs-standalone", "installed" ) ) { // It can lead to an almost endless sequence of further problems // when hpijs-standalone is removed by the package management system ------------------------------------------------------------------------------- In yast2-printer-3.0.0 Ruby it has become in src/include/printer/driveradd.rb ------------------------------------------------------------------------------- if Printerlib.TestAndInstallPackage( "hpijs-standalone", "installed" ) # when hpijs-standalone is removed by the package management system ------------------------------------------------------------------------------- There are many more examples as above in yast2-printer. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.