[Bug 238680] New: yast2-slp should not needed in minimal installed system
https://bugzilla.novell.com/show_bug.cgi?id=238680 Summary: yast2-slp should not needed in minimal installed system Product: openSUSE 10.3 Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 AssignedTo: yast2-maintainers@suse.de ReportedBy: aj@novell.com QAContact: jsrain@novell.com OtherBugsDependingO 238668 nThis: # rpm -e --test yast2-slp error: Failed dependencies: yast2-slp is needed by (installed) yast2-ldap-client-2.15.1-2.noarch yast2-slp is needed by (installed) yast2-installation-2.15.5-2.noarch I don't think we really need yast2-slp in a minimal base system and suggest to make it optional. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 jdsn@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|yast2-maintainers@suse.de |jsuchome@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Comment #1 from jsuchome@novell.com 2007-02-01 08:16 MST ------- yast2-slp is used for browsing available LDAP servers. I'll try to make it non-mandatory (-> when user would click Browse button, the module would be installed). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsuchome@novell.com AssignedTo|jsuchome@novell.com |locilka@novell.com Status|ASSIGNED |NEW ------- Comment #2 from jsuchome@novell.com 2007-02-01 08:21 MST ------- Oh, but it wouldn't make much sense to remove it from yast2-ldap-client dependency if it would not be possible to remove from yast2-installation's one. Lukas, is it possible? Andreas, do you really want it? yast2-installation uses this module for finding available sources... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 locilka@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |aj@novell.com ------- Comment #3 from locilka@novell.com 2007-02-01 08:28 MST ------- yast2-installation requires the yast2-slp because SLP is just another installation source you can use when adding new Add-On. Add-Ons are part of the installation also on a running system - you can add a new SLP Add-On there as well. Yes, it could be done optionally, if user tries to search for available product on SLP, Add-On installer would check whether yast2-slp is installed and ask whether user wants to install yast2-slp if it isn't. Andreas, is it worth doing such change? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 aj@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|aj@novell.com | ------- Comment #4 from aj@novell.com 2007-02-02 01:18 MST ------- Yes, it's worth making such a change. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mvidner@novell.com ------- Comment #5 from jsuchome@novell.com 2007-02-02 06:28 MST ------- Martin, what do you think about introducing conditional imports/includes to YaST? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 locilka@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |locilka@novell.com, kmachalkova@novell.com AssignedTo|locilka@novell.com |jsuchome@novell.com Severity|Normal |Enhancement ------- Comment #6 from locilka@novell.com 2007-02-02 07:41 MST ------- We have run into some problems when implementing this feature: - yast2-packager was dependent on yast2-slp as well - When some YaST package is installed when running y2base, SCR agents which are included in that package need to be registered manually before we try to use them (Mvidner has a better - general solution) - Every call of the not-yet-installed package's module needs to be done via YCP clients. For instance add-on.ycp client can't import SLP module even if it uses this module later for searching for SLP installation source. Such search must be done via special search_for_slp client. In some cases, developer must be also sure that such client exists. Calling a new agent from running y2ase is slower than calling a pre-compiled YaST module and more errors can happen. Anyway, these changes have been implemented in: yast2-packager-2.15.6 - Separating SLP-related functions to the SourceManagerSLP module. - Creating new add_inst_source_slptype client. - Handling not installed yast2-slp package in inst_source client. - All to make system without yast2-slp package installed possible (#238680). yast2-installation-2.15.6 - Removing dependency on yast2-slp package. - Moving all SLP-related functionality to yast2-packager-2.15.7. - Handling not installed yast2-slp package in Add-Ons (#238680). So this is fixed / implemented for me, reassigning to jsuchome. Adding kmachalkova as maintainer of yast2-ntp-client where SLP-search is used as well. I suppose that more YaST modules could break when you do not install yast2-slp even if they don't require that package - just because that package had been installed in a default installation for a very long time. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Comment #7 from jsuchome@novell.com 2007-02-02 07:49 MST -------
- Every call of the not-yet-installed package's module needs to be done via YCP clients. For instance add-on.ycp client can't import SLP module even if it uses this module later for searching for SLP installation source. Such search must be done via special search_for_slp client. In some cases, developer must be also sure that such client exists. Calling a new agent from running y2ase is slower than calling a pre-compiled YaST module and more errors can happen.
This could be solved better way by allowing conditional imports/includes (comment #5). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 ------- Comment #8 from locilka@novell.com 2007-02-02 07:55 MST ------- AJ: yast2-slp needs to be set as required for inst-sys, All implemented handling is for not-Mode::installation() because you can't install new package into inst-sys as you can't check whether such package is in inst-sys. The only way to check whether SLP module is (probably) included in inst-sys is to call SCR::Read(.slp, "xyz") and evaluate what it returns. 'nil' could mean that such agent is not registered, which could mean that it doesn't exist. It could also return 'nil' for wrong SCR command... --- Jsuchome: yes, conditional include/import could solve it better but it needs to be well designed and well coded. The current implementation is just a fire-starter :) for evaluation... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 aj@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |snwint@novell.com ------- Comment #9 from aj@novell.com 2007-02-02 09:39 MST ------- The inst-sys should require the package, let's tell Steffen. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |mvidner@novell.com ------- Comment #10 from jsuchome@novell.com 2007-02-05 00:08 MST ------- Martin, please comment. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 mvidner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|mvidner@novell.com | ------- Comment #11 from mvidner@novell.com 2007-02-05 02:26 MST ------- Conditional imports (or includes) would be very hard* to do because they go against a basic principle of Code 9 YCP: The signature of every function call must be checked. The current way to avoid it is WFM::call. Maybe we could create a simple workaround by going through Perl... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 ------- Comment #12 from snwint@novell.com 2007-02-05 03:27 MST ------- yast2-slp already is in inst-sys -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC|snwint@novell.com | ------- Comment #13 from jsuchome@novell.com 2007-02-06 03:57 MST ------- Hm, I think I like the Perl solution more than WFM::call: - my ui.ycp calls SLPAPI::FindSrvs instead of SLP::FindSrvs, but only after it checks yast2-slp is installed - SLPAPI.pm is Perl module, which only wraps parts of SLP.ycp API (so SLPAPI::FindSrvs only calls SLP::FindSrvs) - importing SLPAPI.pm doesn't require to have SLP.ycp installed. What I like on this solution is some transparency at ui.ycp level. SLPAPI.pm could be in yast2.rpm if other than yast2-ldap-client modules would like to use it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jsuchome@novell.com |kmachalkova@novell.com Status|ASSIGNED |NEW ------- Comment #14 from jsuchome@novell.com 2007-02-13 02:39 MST ------- Fixed this way in yast2-ldap-client-2.15.3. Katarina, I think this is relevant for you as well, please close if I'm not right. If you would like to use the same solution, return back to me so I would put SLPAPI.pm to yast2.rpm -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 kmachalkova@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Comment #15 from kmachalkova@novell.com 2007-03-08 08:47 MST ------- (In reply to comment #14)
If you would like to use the same solution, return back to me so I would put SLPAPI.pm to yast2.rpm
Yes, please move SLPAPI.pm to yast2.rpm, so that I can use it. All I need is SLP::FindSrvs function. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 jsuchome@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Other |All ------- Comment #16 from jsuchome@novell.com 2007-03-08 10:32 MST ------- yast2-2.15.17 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238680 kmachalkova@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #17 from kmachalkova@novell.com 2007-03-12 04:24 MST ------- Fixed in yast2-ntp-client 2.15.2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com