https://bugzilla.novell.com/show_bug.cgi?id=842919 https://bugzilla.novell.com/show_bug.cgi?id=842919#c Jiri Srain changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jsrain@suse.com |snwint@suse.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=842919 https://bugzilla.novell.com/show_bug.cgi?id=842919#c2 --- Comment #2 from Andrey Borzenkov 2013-09-30 13:08:14 UTC --- (In reply to comment #1)

Is this grub2-specific, maybe?

I have tested it for grub2 only. Sorry for not being more specific. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=842919 https://bugzilla.novell.com/show_bug.cgi?id=842919#c4 Michael Chang changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |snwint@suse.com --- Comment #4 from Michael Chang 2013-10-01 10:15:48 UTC --- Above patch doesn't work. It seems to me that yast has subtle definition that md array MUST be created in exact "two disks" to enable redundancy .. ======== Observing from my installation logs. 8125 2013-10-01 17:52:48 <1> 147.2.211.25(6662) [Ruby] modules/BootStorage.rb:1445 Devices for analyse of redundacy md array: ["/dev/md1"] 8126 2013-10-01 17:52:48 <1> 147.2.211.25(6662) [Ruby] modules/BootStorage.rb:1378 Device: /dev/md1 doesn't contain 2 partitions: ["/dev/vda2", "/dev/vdb2", "/dev/vdc2"] 8127 2013-10-01 17:52:48 <1> 147.2.211.25(6662) [Ruby] modules/BootStorage.rb:1396 device: /dev/md1 is based on md_physical_disks: [] is not valid for enable redundancy 8128 2013-10-01 17:52:48 <1> 147.2.211.25(6662) [Ruby] modules/BootStorage.rb:1452 Skip enable redundancy of md arrays ======= And the code snippet causing above message modules/BootStorage.rb # FATE#305008: Failover boot configurations for md arrays with redundancy # Check if device are build from 2 partitions with same number but from different disks # # @param [Hash{String => map}] tm taregte map from storage # @param [String] device (md device) # @return true if device is from 2 partisions with same number and different disks def checkMDDevices(tm, device) ... ... @md_physical_disks = [] # find partitions in target map Builtins.foreach(Ops.get_list(tm_dm, "partitions", [])) do |p| if Ops.get_string(p, "device", "") == device if Ops.get_string(p, "raid_type", "") == "raid1" p_devices = Ops.get_list(p, "devices", []) if Builtins.size(p_devices) == 2 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ret = checkDifferentDisks(p_devices) else Builtins.y2milestone( "Device: %1 doesn't contain 2 partitions: %2", device, p_devices ) end else Builtins.y2milestone( "Device: %1 is not on raid1: %2", device, Ops.get_string(p, "raid_type", "") ) end end end ======= It's very clear that yast creates such requirement, but I really don't know why? Steffen do you have any other better idea ? Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=842919 https://bugzilla.novell.com/show_bug.cgi?id=842919#c6 --- Comment #6 from Andrey Borzenkov 2013-10-01 17:58:30 UTC --- Created an attachment (id=561087) --> (http://bugzilla.novell.com/attachment.cgi?id=561087) YaST2 logs after installation on MD RAID1 (In reply to comment #3)

Hi Andrey,

Are you having more than two disks raided ?

No, I have exactly 2 disks. Apparently there are some different corner cases. Attached is y2logs from clean installation using b1. During installation when I go to bootloader from summary screen MD RAID redundancy is indeed checked - but grub2 is installed in MBR only of single disk and when I start yast after installation, redundancy is offered but unchecked! Previous attempt did not even expose redundancy option. May be because one filesystem (root on btrfs) was not on RAID1. What are the rules? Must *all* filesystems/swaps be mirrored to get redundancy offered in bootloader configuration? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=842919 https://bugzilla.novell.com/show_bug.cgi?id=842919#c8 --- Comment #8 from Michael Chang 2013-10-02 04:53:05 UTC --- (In reply to comment #6)

No, I have exactly 2 disks. Apparently there are some different corner cases.

Attached is y2logs from clean installation using b1. During installation when I go to bootloader from summary screen MD RAID redundancy is indeed checked - but grub2 is installed in MBR only of single disk and when I start yast after installation, redundancy is offered but unchecked!

It could be the bogus Boot Loader Location Widget. The status (BootCommon.enable_md_array_redundancy) is initially "null" and will be converted to true|false once you explicit save the settings. If you see the settings and hit "cancel" you will leave it uninitialized and when saving bootloader configurations BootCommon.enable_md_array_redundancy is checked to match true to get boot_md_mbr saved, otherwise it's removed. The fix could be trivial, but it's not clear to me that enable_md_array_redundancy should be default to true or false when md raid1 array detected ..

Previous attempt did not even expose redundancy option. May be because one filesystem (root on btrfs) was not on RAID1. What are the rules? Must *all* filesystems/swaps be mirrored to get redundancy offered in bootloader configuration?

BootStorage.checkMDDevices has the comment "Check if device are build from 2 partitions with same number but from different disks" Above rule may explain my question (comment#4) and maybe like Steffen said this is the setup we want to support ? It looks to me (roughly) that if one of your /boot or / matches the rule 1. configured as md raid 1 2. that raid is built from 2 partitions with same number but from different disks The redundancy *should* be enabled (I use *should* because the checkMDDevices() is buggy to me (in it's handling of return value), because if your "/" matches with rule #1 but not with rule #2, the redundancy won't be enabled ..) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=842919 https://bugzilla.novell.com/show_bug.cgi?id=842919#c10 --- Comment #10 from Michael Chang 2013-10-02 09:08:59 UTC --- Created an attachment (id=561143) --> (http://bugzilla.novell.com/attachment.cgi?id=561143) Test DUD Hi Andrey, Is it possible for you to verify this DUD, it simply declares enable_md_array_redundancy as true instead of nil. A quick test on my side seems to work. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=842919 https://bugzilla.novell.com/show_bug.cgi?id=842919#c12 --- Comment #12 from Andrey Borzenkov 2013-10-03 02:38:50 UTC --- (In reply to comment #11)

Created an attachment (id=561145) --> (http://bugzilla.novell.com/attachment.cgi?id=561145) [details] Patch in DUD

Could you remind how to test it? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=842919 https://bugzilla.novell.com/show_bug.cgi?id=842919#c14 --- Comment #14 from Michael Chang 2013-10-04 06:46:03 UTC --- (In reply to comment #13)

Worked for me too on the same configuration as before (grub2 was installed on both HDDs and redundancy remained enabled after installation). I briefly tested installation with single disk and it was correct as well (no redundancy option was offered).

Thanks a lot for verification. At least we can confirm where the cause is from and we're seeing the same problem.

I wonder if it can have unwanted side effects, but it does fix this bug,

The patch did not look good to me either, my preferred fix is to not change it's initial nul (in BootCommon module) to be more safe on other circumstance, but somehow couldn't have a positive result which frustrated me A LOT as the fix is supposed to work and simple. :( Probably I will invest more time on it after hackweek. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=842919 https://bugzilla.novell.com/show_bug.cgi?id=842919#c16 --- Comment #16 from Andrey Borzenkov 2013-10-06 18:37:06 UTC --- Created an attachment (id=561581) --> (http://bugzilla.novell.com/attachment.cgi?id=561581) Fix reading and displaying of MD redundancy status for grub and grub2 Here is more complete version of patch which also correctly reads MD redundancy state of bootloader settings. Current code fails to set BootCommon.enable_md_array_redundancy if a) bootloader has redundancy configured and b) configuration did not change. It behaves identically for the case when something has changed. Missing part is summary display. I need some more time. But any chance to make this patch in RC, so it can be tested? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=842919 https://bugzilla.novell.com/show_bug.cgi?id=842919#c18 Andrey Borzenkov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |snwint@suse.com --- Comment #18 from Andrey Borzenkov 2013-10-16 16:54:46 UTC --- Could you review this pull request for inclusion in Factory/RC2? https://github.com/yast/yast-bootloader/pull/25 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.