[Bug 374477] New: kiwi: testing framework
https://bugzilla.novell.com/show_bug.cgi?id=374477 Summary: kiwi: testing framework Product: openSUSE 11.0 Version: Alpha 3 Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: P5 - None Component: Basesystem AssignedTo: ms@novell.com ReportedBy: pnemec@novell.com QAContact: qa@suse.de CC: adrian@novell.com, psladek@novell.com Found By: --- Psladek implemented quite basic testing framework for kiwi. I also did the kiwi integration part. basic use is kiwi --create [...] --test or kiwi --create [...] --test "firstTestCase second third" Kiwi then invoke KIWITest.pm on succesfully builded image and print resort to standard log. (see attached screenshot) Sources can be found here: http://svn.suse.de/viewvc/slepos/trunk/kiwi-test/tester/ three test are available here: http://svn.suse.de/viewvc/slepos/trunk/kiwi-test/ We would like to maintain test framework inside kiwi svn if it is ok. Tests are expected to be under /usr/share/kiwi/tests where xsd template for test definition lives and where tests are also expected (under separate directory). Patch agains kiwi.pl head will follow -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=374477
User pnemec@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c1
--- Comment #1 from Pavel Nemec
https://bugzilla.novell.com/show_bug.cgi?id=374477
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User pnemec@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c2
--- Comment #2 from Pavel Nemec
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c3
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User pnemec@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c4
Pavel Nemec
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c5
--- Comment #5 from Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c6
--- Comment #6 from Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c7
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c8
--- Comment #8 from Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User pnemec@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c9
Pavel Nemec
thanks for the test framework. I had a look into the code and fixed some warnings as well as did some adaption according to the rest of the kiwi code style. I also divided the two packages KIWITest
I see you had a lot of work with it. We will try harder next time.
and KIWITestResult into two files. Beyond this I found the following
Well It is holder Object only...but this is more clear.
problems/inconsistencies which would be great if you can fix before we check it in:
1) you don't use the KIWILog module and functionality to print log messages: It would be great if you can add that. It works like the following:
my $kiwi = $self->{kiwi}; $kiwi -> info ("..."); $kiwi -> error ("...");
I already have added the initialization of the log module in the test framework
I do not get it here. I of course find out how to use your log facility, but we do not use print alone at all. Are you suggesting we should add some information prints to see status? My idea was that this should be done by calling part. see attachement #204389 Or our standalone application tester.pl http://svn.suse.de/viewvc/slepos/trunk/kiwi-test/tester/tester.pl?view=log In kiwi.pl I am using only kiwi-> info/note/errors call to print messages.
2) you use an xsd description to validate the test xml. kiwi uses RelaxNG and I think it would be good to adapt your schema to rng as well
I see your point. And you are right ...probably :) RelaxNG is quite complicated for me and xml schema is enough. But I will take a deeper look and give it a chance.
3) I have removed the use of global variables they are evil :) all parameters are passed as object parameters so you need to adapt the kiwi.pl adaption you have made a bit
good Idea, we will adopt you patches and fix kiwi.pl integration part and report back. I am setting needinfo on you. Please comment point 1) Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c10
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c11
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c12
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c13
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c14
--- Comment #14 from Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c15
--- Comment #15 from Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c16
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User pnemec@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c17
Pavel Nemec
https://bugzilla.novell.com/show_bug.cgi?id=374477
User pnemec@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c18
Pavel Nemec
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c19
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User pnemec@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c21
--- Comment #21 from Pavel Nemec
Hmm, this patch uses again the result image instead of the prepared tree. I also don't understand why you prefer --test "a b c" instead of --test a --test b --test c
Yes I fixed "my version" as you asked me in comment #10. You are just too fast. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=374477
User pnemec@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c22
--- Comment #22 from Pavel Nemec
https://bugzilla.novell.com/show_bug.cgi?id=374477
User thomas.schraitle@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c23
--- Comment #23 from Thomas Schraitle
https://bugzilla.novell.com/show_bug.cgi?id=374477
User thomas.schraitle@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c24
--- Comment #24 from Thomas Schraitle
https://bugzilla.novell.com/show_bug.cgi?id=374477
User thomas.schraitle@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c25
--- Comment #25 from Thomas Schraitle
Thomas: can you help us change xml:scheme file to RelaxNG ?
See the attachements in RNC and RNG format. If you have any questions, please send me a mail. :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c26
--- Comment #26 from Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User ms@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c27
Marcus Schaefer
https://bugzilla.novell.com/show_bug.cgi?id=374477
User thomas.schraitle@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c28
--- Comment #28 from Thomas Schraitle
participants (1)
-
bugzilla_noreply@novell.com