[Bug 335676] New: kernel OOPS when starting nut UPS daemon
https://bugzilla.novell.com/show_bug.cgi?id=335676 Summary: kernel OOPS when starting nut UPS daemon Product: openSUSE 10.3 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: sbrabec@novell.com QAContact: qa@suse.de Found By: --- I got kernel OOPS when starting nut UPS daemon to handle USB HID UPS APC SmartUPS 750. I was able to reproduce this crash at least 3 times (sometimes keyboard started to blink, sometimes not, once the system except keyboard even continued to work for a minute), but when starting the ups daemon with strace, kernel did not oops and even consequent standard start did not oops. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335676#c1
--- Comment #1 from Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=335676#c2
--- Comment #2 from Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=335676#c3
Jeff Mahoney
https://bugzilla.novell.com/show_bug.cgi?id=335676#c4
Arjen de Korte
https://bugzilla.novell.com/show_bug.cgi?id=335676#c5
--- Comment #5 from Jeff Mahoney
https://bugzilla.novell.com/show_bug.cgi?id=335676#c6
--- Comment #6 from Arjen de Korte
https://bugzilla.novell.com/show_bug.cgi?id=335676#c7
--- Comment #7 from Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=335676#c8
Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=335676
Jeff Mahoney
https://bugzilla.novell.com/show_bug.cgi?id=335676#c12
Oliver Neukum
https://bugzilla.novell.com/show_bug.cgi?id=335676#c13
--- Comment #13 from Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=335676#c14
Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=335676#c15
--- Comment #15 from Arjen de Korte
https://bugzilla.novell.com/show_bug.cgi?id=335676#c16
Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=335676#c17
--- Comment #17 from Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=335676#c18
--- Comment #18 from Arjen de Korte
Communication log of /usr/lib/ups/driver/usbhid-ups -DD -a myups 2>ups2.log
Captured when kernel did not crash (at least not immetiately).
Looking at the ReportID's, the usbhid-ups driver is indeed vulnerable with this UPS (for instance, with the HID Path 'UPS.Output.Current' having an ID of 0x40 (which is higher than the 'safe' range 0x00 - 0x3F). If you only run the driver, does it crash (not neccessarily in debug mode) after a while? There are still some other bugs in 'usbhid-ups' in nut-2.2.0 that can be triggered depending on the UPS that is attached to it. These should be resolved by the nut-2.2.1 driver that will be released in a couple of weeks. If you're willing to try it out, the version we have in Testing is what it looks like (don't use nut-2.2.1-pre1, that's still the old one). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335676#c19
--- Comment #19 from Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=335676#c20
--- Comment #20 from Arjen de Korte
I have not seen any crash of nut driver (even before patch), both standalone or nut. The crashing side is the kernel and memory corruption occurs inside kernel. Nothing from user space (even incorrectly written) should cause kernel OOPS.
I agree.
If this crash is limited to this UPS model and x86_64, I would prefer to release fix for bug 331749 now. If anybody else is able to reproduce this crash, I'll postpone the (apparently correct) fix, which actually causes kernel to crash.
For me the fixes (both to udev and hidparser.c) obviously work. But I don't have this UPS model and neither do I run x86_64. Does this also happen with the default (i586) kernel?
Note that this UPS also communicates somehow with GNOME Power Manager and it does not cause OOPS.
You don't run the standard and HAL drivers at the same time, do you? That doesn't fly, since only one driver can claim an USB device at the same time. NUT 2.2.0 is still broken in this respect, after successfully claiming the device, it won't notice that another driver may have claimed it afterwards (fixed in nut-2.2.1). This leads to the kernel complaining about the driver using the interface without claiming it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335676#c21
--- Comment #21 from Stanislav Brabec
(In reply to comment #19 from Stanislav Brabec)
Note that this UPS also communicates somehow with GNOME Power Manager and it does not cause OOPS.
You don't run the standard and HAL drivers at the same time, do you? That doesn't fly, since only one driver can claim an USB device at the same time. NUT 2.2.0 is still broken in this respect, after successfully claiming the device, it won't notice that another driver may have claimed it afterwards (fixed in nut-2.2.1). This leads to the kernel complaining about the driver using the interface without claiming it.
It happens automatically in 10.3 if you have an USB HID UPS. Yes, I have seen these kernel complains. But the crash occurs even without running X, so it should not be related to device re-claiming. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335676#c22
--- Comment #22 from Arjen de Korte
It happens automatically in 10.3 if you have an USB HID UPS. Yes, I have seen these kernel complains. But the crash occurs even without running X, so it should not be related to device re-claiming.
Maybe it is not related to this bug, but this won't work reliably and it will break existing installations. I have filed bug 337059 for this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335676#c23
--- Comment #23 from Oliver Neukum
https://bugzilla.novell.com/show_bug.cgi?id=335676
Stanislav Brabec
https://bugzilla.novell.com/show_bug.cgi?id=335676
User oneukum@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=335676#c24
Oliver Neukum
https://bugzilla.novell.com/show_bug.cgi?id=335676
User cthiel@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=335676#c25
--- Comment #25 from Christoph Thiel
https://bugzilla.novell.com/show_bug.cgi?id=335676
User oneukum@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=335676#c26
Oliver Neukum
participants (1)
-
bugzilla_noreply@novell.com