[Bug 219584] New: fresh install: ivman does not start during boot
https://bugzilla.novell.com/show_bug.cgi?id=219584 Summary: fresh install: ivman does not start during boot Product: openSUSE 10.2 Version: Beta 2 Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: Basesystem AssignedTo: mkoenig@novell.com ReportedBy: aj@novell.com QAContact: qa@suse.de x40:/var/log # grep ivman boot.msg Starting ivman failed Failed services in runlevel 5: earlysyslog ivman -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 ------- Comment #1 from mkoenig@novell.com 2006-11-10 07:47 MST ------- Seems to be a HAL problem: Starting ivman manager.c:1370 (do_startup_configure) Directory /etc/ivman/ will be used for configuration files. manager.c:773 (ivm_run_command) Running: echo 0 > /proc/sys/dev/cdrom/lock manager.c:1174 (setupHAL) Couldn't initialise HAL! failed After boot: # /etc/init.d/haldaemon status Checking for service HAL daemon unused After restarting hal, ivman starts properly. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 mkoenig@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thoenig@novell.com, dkukawka@novell.com ------- Comment #2 from mkoenig@novell.com 2006-11-10 07:51 MST ------- Might be related to #217563. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 ------- Comment #3 from dkukawka@novell.com 2006-11-10 08:03 MST ------- No, I don't think so. Here I have the same error message and HAL is running after reboot. One thing in general: why exit ivman if HAL is not running? why not start and wait for HAL available via DBUS? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 mkoenig@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 mkoenig@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |schwab@novell.com ------- Comment #4 from mkoenig@novell.com 2006-11-21 03:13 MST ------- *** Bug 222901 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 ------- Comment #5 from mkoenig@novell.com 2006-11-21 03:19 MST ------- So we cannot assume that HAL is running when starting ivman. Timo convinced me to change the handling of HAL/DBus to properly react on shutdown/startup. I will do this for 10.3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 mkoenig@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #6 from mkoenig@novell.com 2007-01-18 11:13 MST ------- Fixed in stable. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 ------- Comment #7 from thoenig@novell.com 2007-01-18 11:22 MST ------- Matthias, the patch looks good, nice work. Just one remark: 40 + if (dbus_message_get_args(reply, 41 + NULL, 42 + DBUS_TYPE_STRING, &tmp_name, 43 + DBUS_TYPE_INVALID)) I'd spend some lines on proper error handling. Makes life easier whenever you run into issues. In our development versions, D-Bus will even cause ivman to exit if you pass NULL instead of an initialized DBusError. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 ------- Comment #8 from thoenig@novell.com 2007-01-18 11:26 MST ------- Missed one, the same applies for dbus_bus_add_match: 83 + dbus_bus_add_match(dbus_connection, 84 + "type='signal'," 85 + "interface='" DBUS_INTERFACE_DBUS "'," 86 + "sender='" DBUS_SERVICE_DBUS "'", 87 + NULL); -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 ------- Comment #9 from mkoenig@novell.com 2007-01-19 04:15 MST ------- Timo, thanks for reviewing the patch! Added some error handling for those functions. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 ------- Comment #10 from thoenig@novell.com 2007-01-19 04:28 MST ------- Very welcome :-) I have yet another comment on the code: If an DBusError was set, please free it afterwards by using dbus_error_free (DBusError *err). 47 + if (dbus_error_is_set(&error)) { 48 + log_error("dbus error: %s", error.message); 49 + return NULL; 50 + } -> 47 + if (dbus_error_is_set(&error)) { 48 + log_error("dbus error: %s", error.message); dbus_error_free(&error); 49 + return NULL; 50 + } There's probably another spot in the code, I didn't check. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219584 ------- Comment #11 from mkoenig@novell.com 2007-01-22 03:56 MST ------- Oops, it slipped through my attention that the errors contain dynamically allocated memory. Thanks for mentioning this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com