[Bug 644738] New: link_wait script just prints usage information when activated

bugzilla_noreply＠novell.com

7 Oct 2010 7 Oct '10

19:18

https://bugzilla.novell.com/show_bug.cgi?id=644738 https://bugzilla.novell.com/show_bug.cgi?id=644738#c0 Summary: link_wait script just prints usage information when activated Classification: openSUSE Product: openSUSE 11.3 Version: Final Platform: All OS/Version: openSUSE 11.3 Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: jochen.katz@de.thalesgroup.com QAContact: qa@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.10) Gecko/20100914 SUSE/3.6.10-0.3.1 Firefox/3.6.10 When activating /etc/sysconfig/network/scripts/link_wait, it just prints out its usage information because the initialization of SCRIPTNAME is wrong. SCRIPTNAME has to be set to SCRIPTNAME=${0}. SLES11 SP1 is also affected. Additional thing that need improvement: - There are a lot of calculations done with LINK_WAIT value. In the end it is not bigger than WAIT_FOR_INTERFACES / 4. This is confusing for the user. - The usage of ping should be replaced by fping, because the command "ping -I eth0 -w 20 -c 1 > /etc/sysconfig/network/ifcfg-eth0 rcnetwork restart Actual Results: Usage output Expected Results: No usage output -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

bugzilla_noreply＠novell.com

8 Oct 8 Oct

06:39

New subject: [Bug 644738] link_wait script just prints usage information when activated

https://bugzilla.novell.com/show_bug.cgi?id=644738 https://bugzilla.novell.com/show_bug.cgi?id=644738#c Marius Tomaschewski changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

16 Nov 16 Nov

17:09

New subject: [Bug 644738] link_wait script just prints usage information when activated

https://bugzilla.novell.com/show_bug.cgi?id=644738 https://bugzilla.novell.com/show_bug.cgi?id=644738#c2 --- Comment #2 from Marius Tomaschewski 2010-11-16 17:09:23 UTC --- Created an attachment (id=400598) --> (http://bugzilla.novell.com/attachment.cgi?id=400598) Minimal patch fixing the issues Rewritten in git master: http://gitorious.org/opensuse/sysconfig/commit/10da7e74aff7ecb6399fc8bcf1266... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

18:01

New subject: [Bug 644738] link_wait script just prints usage information when activated

https://bugzilla.novell.com/show_bug.cgi?id=644738 https://bugzilla.novell.com/show_bug.cgi?id=644738#c4 --- Comment #4 from Marius Tomaschewski 2010-11-16 18:01:16 UTC --- Thanks for the report! (In reply to comment #0)

...

SCRIPTNAME has to be set to SCRIPTNAME=${0}.

fixed.

...

Additional thing that need improvement: - There are a lot of calculations done with LINK_WAIT value. In the end it is not bigger than WAIT_FOR_INTERFACES / 4. This is confusing for the user.

Yes, the script was originally for sles10 and there it was required. You have to increase WAIT_FOR_INTERFACES.

...

- The usage of ping should be replaced by fping, because the command "ping -I eth0 -w 20 -c 1

I don't see any benefit using fping. It is installed in /usr, so it is not usable in the when /usr is on remote-fs and this (+static ip) was the purpose of this optional helper script, e.g. when bnx2 does not report the carrier correctly. A loop seems better to me. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

19:53

New subject: [Bug 644738] link_wait script just prints usage information when activated

https://bugzilla.novell.com/show_bug.cgi?id=644738 https://bugzilla.novell.com/show_bug.cgi?id=644738#c5 --- Comment #5 from Jochen Katz 2010-11-16 19:53:53 UTC --- (In reply to comment #4)

...

I don't see any benefit using fping. It is installed in /usr, so it is not usable in the when /usr is on remote-fs and this (+static ip) was the purpose of this optional helper script, e.g. when bnx2 does not report the carrier correctly. A loop seems better to me.

Yes, your loop can do it without fping. I mentioned fping, because if fping is called with the right params, it will return after the specified amount of seconds, while such params do not exist for ping. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

18 Nov 18 Nov