http://bugzilla.novell.com/show_bug.cgi?id=623290 http://bugzilla.novell.com/show_bug.cgi?id=623290#c1 --- Comment #1 from Jon Nelson 2010-08-15 22:33:26 UTC --- More info: I think the files in /usr/lib/pm-utils/power.d/ and /usr/lib/pm-utils/sleep.d/ should be using: /usr/lib/pm-utils/pm-functions not /usr/lib/pm-utils/functions -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c3 --- Comment #3 from Jon Nelson 2010-08-22 18:01:39 UTC --- If the code is ever run in a context where a failed command results in an error (ie, set -e), then it's a problem. Futhermore, it's not _right_. The code is trying to execute a command which in this context does not exist. That's wrong, and it should be fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c5 --- Comment #5 from Till Dörges 2010-08-23 22:01:59 UTC --- (In reply to comment #4)

in which module have you found this problem?

I see it, when 75modules tries to unload a module which it can't unload. Also see 633496. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c7 --- Comment #7 from Till Dörges 2010-08-26 10:39:20 UTC --- (In reply to comment #6)

And which command did you call when you see this error? Because all main pm-utils commands already sources /usr/lib/pm-utils/pm-functions, where log function is declared.

$ rpm -ql pm-utils | grep bin | xargs grep pm-functions /usr/bin/pm-is-supported:. "/usr/lib/pm-utils/pm-functions" /usr/lib/pm-utils/bin/pm-action:. "/usr/lib/pm-utils/pm-functions" /usr/sbin/pm-hibernate:. "/usr/lib/pm-utils/pm-functions" /usr/sbin/pm-powersave:. "/usr/lib/pm-utils/pm-functions" /usr/sbin/pm-suspend:. "/usr/lib/pm-utils/pm-functions" /usr/sbin/pm-suspend-hybrid:. "/usr/lib/pm-utils/pm-functions"

I didn't call anything directly. My testcase was related to bug 633496. I.e. I put SUSPEND_MODULES="em28xx" into /etc/pm/config.d/terratec. Then I tried to suspend to disk. When 75modules is executed (automatically for the suspend, not by me), I find the above error message in /var/log/pm-suspend.log. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c9 Till Dörges changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|jnelson-suse@jamponi.net | --- Comment #9 from Till Dörges 2010-09-04 21:41:11 UTC --- http://download.opensuse.org/repositories/home:/vbotka:/branches:/openSUSE:/... fixes the problem. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c11 Vladimir Botka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |maintenance@opensuse.org --- Comment #11 from Vladimir Botka 2010-09-06 20:41:33 UTC --- Created request id 47166 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c13 Christian Dengler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW CC| |cdengler@novell.com InfoProvider|maintenance@opensuse.org | --- Comment #13 from Christian Dengler 2010-09-07 14:25:05 UTC --- +1, update started. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c15 Vladimir Botka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |cdengler@novell.com --- Comment #15 from Vladimir Botka 2010-09-08 14:08:22 UTC --- Do I need the swamp to FActory either ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c16 Michal Vyskocil changed: What |Removed |Added ---------------------------------------------------------------------------- InfoProvider|maint-coord@suse.de |vbotka@novell.com --- Comment #16 from Michal Vyskocil 2010-09-13 11:40:03 UTC --- Hi guys, I'm little bit surprised there's already a SWAMPID and a patch. I do not think this is neither bug nor something should be fixed by maintenance update. As you can see in my comment#6 - every pm-utils command in /usr/(s)?bin/ sources the /usr/lib/pm-utils/pm-functions, where log command is defined. That means only one way user can face the missing log function is using pm-utils in a non-standard way, which is not supported. In other words, if you want to call something from /usr/lib/pm-utils directly, you have to source /usr/lib/pm-utils/pm-functions as a first step. Till, Vlado: if I'm wrong then please tell me which script did you use, because I'm not able to reproduce it. I understand that this requirement should be considered as annoying. But this should be discussed by upstream, not fixed by maintenance update. Please note that recent pm-utils-1.4.1 uses the same layout and I want to maintain less, not more SUSE pm-utils patches. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c18 Michal Vyskocil changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO URL| |http://lists.freedesktop.or | |g/archives/pm-utils/2010-Se | |ptember/002220.html InfoProvider| |maintenance@opensuse.org --- Comment #18 from Michal Vyskocil 2010-09-14 08:38:48 UTC --- So after a talk with Vlado and deeper look into the code I sent a patch which moves the definition of function log to pm/functions.in, because it is only one function used, but not defined in this file. http://lists.freedesktop.org/archives/pm-utils/2010-September/002220.html If and only if upstream will accept it, I'll vote for release of it as a maintenance update. If not, there are still two things should be fixed in 11.3, so we can reuse this SWAMPID http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=568565 http://cgit.freedesktop.org/pm-utils/commit/?id=79dde6f2f7bb620b163981ec7a7b... https://bugzilla.novell.com/show_bug.cgi?id=633496 http://cgit.freedesktop.org/pm-utils/commit/?id=ef1e0968b93d2e3425183e6f1874... maintenance: are you OK with that? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c20 Swamp Workflow Management changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:35694:low |maint:running:35694:low | |maint:released:11.3:35724 --- Comment #20 from Swamp Workflow Management 2010-09-28 10:11:41 UTC --- Update released for: pm-utils, pm-utils-debuginfo, pm-utils-debugsource, pm-utils-ndiswrapper Products: openSUSE 11.3 (debug, i586, x86_64) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c21 Michal Vyskocil changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |cdengler@novell.com --- Comment #21 from Michal Vyskocil 2010-09-29 12:49:05 UTC --- Afaik the pm-utils was not updated, or I'm wrong? BTW: I still don't have a response from upstream. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=623290 https://bugzilla.novell.com/show_bug.cgi?id=623290#c26 Michal Vyskocil changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #26 from Michal Vyskocil 2010-10-06 11:48:47 UTC --- Update has been released, so lets close this one -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.