https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c1 Jeff Mahoney changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Kernel |Kernel AssignedTo|kernel-maintainers@forge.pr |ro@novell.com |ovo.novell.com | Product|openSUSE 11.3 |openSUSE 12.1 --- Comment #1 from Jeff Mahoney 2011-04-25 21:28:11 UTC --- /etc/sysconfig/kernel is part of aaa_base. Assigning to maintainer. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c3 Michal Marek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmarek@novell.com InfoProvider|mmarek@novell.com |eich@novell.com --- Comment #3 from Michal Marek 2011-05-09 11:32:44 UTC --- (In reply to comment #2)

well, I'm just providing the variable. The use of it is in /lib/mkinitrd/scripts/setup-kms.sh. Michal: do we want to change this ? Does this still default to not setting up kms ?

Egbert contributed the kms scripts.

(I can provide renaming the variable and reversing the current setting on update if wanted in the install scripts of aaa_base), but actually: why does this file belong to aaa_base at all while the whole thing could live in mkinitrd ?

INITRD_MODULES, DOMU_INITRD_MODULES, ACPI_DSDT and NO_KMS_IN_INITRD are variables read by mkinitrd. MODULES_LOADED_ON_BOOT is read by /etc/init.d/boot.loadmodules. SKIP_RUNNING_KERNEL can be removed. So yes, most of the variables are used by mkinitd, although the *MODULES once are obsolete. What everything needs to be done to move a sysconfig file from one package to another (IOW is it worth it)? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c5 Jon Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|eich@novell.com | --- Comment #5 from Jon Nelson 2011-05-09 13:23:47 UTC --- If it's going to be a lot of work or difficult for end users, I would say not to bother. I _respectfully_ submit two observations: 1. at the time of the submission, there was time to correct the issue before release 2. in the future when new config items are introduced, try to avoid issues like this -- even though it's minor, once it's "in", it's hard to change. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c7 Ruediger Oertel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |mmarek@novell.com --- Comment #7 from Ruediger Oertel 2011-05-09 15:14:02 UTC --- created request id 69906 please ping me if this is okay, so I can remove the files from aaa_base in turn -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c9 Christian Boltz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bruno@ioda-net.ch, | |suse-beta@cboltz.de --- Comment #9 from Christian Boltz 2011-06-14 00:36:46 CEST --- (In reply to comment #4) (Egbert)

I could add the inverse semantics not replace what we currently have - this would be really easy -

Things aren't always as easy as they might look ;-)

still I'm hesitant as this might produce some nightmare on the update process.

Your guess was right - this *is* producing a nightmare on update. (OK, I'm exaggerating ;-) Bruno Friedmann wrote this in opensuse-factory yesterday: ------------------------------------------------------------------------------- Sid I mean on new factory install the NO_KMS_IN_INITRD="yes" become KMS_IN_INITRD="no" The upgrade process is faulty with wrong sed or regex as I've finished with a NO_KMS_IN_INITRD="noyes" and KMS_IN_INITRD="yes" ------------------------------------------------------------------------------- The "yesno" looks as if the update script can't decide ;-)) mkinitrd.spec from Base:System looks somewhat buggy, even if it seems to have the bug in the KMS_IN_INITRD variable instead of the NO_KMS_... variable: %post: [...] case "$NO_KMS_IN_INITRD" in no) sed -i -e "s@^KMS_IN_INITRD=@KMS_IN_INITRD=\"yes\"@" /etc/sysconfig/kernel ;; yes) sed -i -e "s@^KMS_IN_INITRD=@KMS_IN_INITRD=\"no\"@" /etc/sysconfig/kernel ;; esac You probably want to add ".*" to the search part to replace the whole line (and not only everything until the "=", which will at least result in additional, useless quotes, or in a "yesno" if things go worse). I'd also use single quotes to make the sed command better readable. In other words, I'd recommend to use the following sed commands: no) sed -i -e 's@^KMS_IN_INITRD=.*@KMS_IN_INITRD="yes"@' /etc/sysconfig/kernel ;; yes) sed -i -e 's@^KMS_IN_INITRD=.*@KMS_IN_INITRD="no"@' /etc/sysconfig/kernel ;; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c11 Michal Marek changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #11 from Michal Marek 2011-08-02 08:17:33 UTC --- (In reply to comment #9) This should be fixed already (KMS_IN_INITRD=.* in the sed command was lacking the ".*"). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c13 --- Comment #13 from Stefan Dirsch 2011-11-03 14:55:59 UTC --- Michal, please revert. :-) Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=619218 https://bugzilla.novell.com/show_bug.cgi?id=619218#c15 --- Comment #15 from Stefan Dirsch 2011-11-07 13:39:01 UTC --- Thanks a lot, Michal! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.