https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c Adrian Schröter changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|adrian@suse.com |vuntz@suse.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c3 --- Comment #3 from Vincent Untz 2012-05-14 15:24:14 UTC --- For reference, I think the right fix would be to add an option to control whether we want to target old rpm (like in SLE) or not. By default, spec-cleaner doesn't care about old rpm. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c5 --- Comment #5 from Joop Boonen 2012-05-14 16:26:58 UTC --- Is adding, the purposed work surround by Christopher, to spec-cleaner a solution? %if 0%{!?make_install:1} %define make_install make install 'DESTDIR=%{buildroot}' %endif -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c7 Juergen Weigert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jw@suse.com --- Comment #7 from Juergen Weigert 2013-02-05 21:22:18 UTC --- I agree that the folling statements make sense: * It is not spec-cleaners goal to add cruft automatically. * It is also not spec-cleaners goal to force packagers to manually add cruft. *The build service also does not want to provide modern definitions to old distros, because then packages would break unexpectedly when built out of build service. But none of these statements forces us to prepare the same traps over and over again. Suggestion: Lets start a package "obs-portable-macros", that provides all the fancy macros, for *all* distros in a non-intrusive way. Maybe even print warnings if a maccro is already defined, and differs. Helpful? Doable? Benefit: Spec-cleaner could assert to BuildRequire obs-portable-macros, whenever it sees one of the nice macros being used, or when it wants to introduce one of these macros itself. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c9 Tomáš Chvátal changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from Tomáš Chvátal 2014-01-26 21:07:04 UTC --- The thing should be addressed in 0.5 series. Firstly it uses make install DESTDIR... But if you us %make_install it lets you keep it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.