https://bugzilla.novell.com/show_bug.cgi?id=249380 fehr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Comment #1 from fehr@novell.com 2007-02-27 09:42 MST ------- Proposal could of course be rewritten according to your suggestions but this is certainly something to be decided by project management since it would mean throwing away current posprosal code and writing new one that can fulfil your requests. - currently nothing about content of partitions is known besides fs type Of could we could mount every block device and analyze content but I an already getting complains about slow startup times now. Mounting dozens of potentially incosistent filesystems will certainly not make startup faster - "last mounted on" is not available for reiserfs (no idea about xfs) Some remarks on things I can change easily: - When switching to "format" the currently detected fs is default. Which is IMHO ok, but you are right that the default should be ext3 if no previous fs was detectd. Will fix that. - Resetting the label when formatting is suggested by proposal code makes sense. Will fix that also. Generally resetting the label when formatting is IMHO not desirable if someone gives label names like "root", "home", "swap" he would probably be pissed if these are destroyed whenever he formats a filesystem. You other request would mean fundamental changes and I would only change these if dist team backs up your suggestions and of course is willing to live with the considerably increased startup time in some cases. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

https://bugzilla.novell.com/show_bug.cgi?id=249380 ------- Comment #3 from fehr@novell.com 2007-02-27 10:20 MST ------- Created an attachment (id=121353) --> (https://bugzilla.novell.com/attachment.cgi?id=121353&action=view) activate more debug output -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

https://bugzilla.novell.com/show_bug.cgi?id=249380 fehr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |WONTFIX ------- Comment #5 from fehr@novell.com 2007-02-28 02:54 MST ------- ext3 is only default for three cases: - when a partition is formatted in a proposal - when a new partition/LV/MD is created - when a partition/LV/MD is edited and no filesystem is detected. Since there are valid reasons to deviate from the default filesystem I do not consider it useful to always change the filesystem to ext3 whenever the user activates format. It worked this way since yast2 partitioner exists and so far nobody complained. Meanwhile I changed proposal code to automatically remove labels. Your other suggestions would mean fundmental changes to current proposal functionality and I will only implement such things if dist team approves it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

https://bugzilla.novell.com/show_bug.cgi?id=249380 fehr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |WONTFIX ------- Comment #7 from fehr@novell.com 2007-02-28 03:51 MST ------- The bug was resolved as WONTFIX. Reasons were explianed in my comments. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c9 Matej Horvath changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hfiguiere@novell.com --- Comment #9 from Matej Horvath 2007-08-09 09:50:42 MST --- *** Bug 298861 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=298861 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c11 --- Comment #11 from Christian Jäger 2007-09-27 07:37:51 MST --- I find it outrageous that this serious bug has been declared a 'wontfix'. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c13 Larry Ewing changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lewing@novell.com --- Comment #13 from Larry Ewing 2007-09-27 13:03:26 MST --- When the proposal exactly matches the current layout why would you ever want to format /home? This is something I have to change every time I do an install and in the worst case it would cause complete loss of data for the user. WONTFIX doesn't make sense to me either. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c15 Federico Mena Quintero changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Critical Status|RESOLVED |REOPENED Resolution|WONTFIX | --- Comment #15 from Federico Mena Quintero 2007-09-27 14:03:45 MST --- Reopening. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c16 Thomas Fehr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #16 from Thomas Fehr 2007-10-01 04:16:29 MST --- Since 10.3 development is over now, I will implement code in STABLE (while will become next openSuSE/SLES release) that look at the fs intended to be used for /home and suppresses formatting if heuristics indicate it is a valid /home filesystem. I still consider this a bogus feature since it involves mounting a potetially large filesystem with unknown content and state. If the filesystem happens to be dirty, the log replay alone may take minutes and there is no save way to prevent these minutes to be wasted, but in the end it is probably less time consuming to implement that stuff than to discuss this forever. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c18 --- Comment #18 from Christian Jäger 2007-10-01 05:03:15 MST --- Thank you. I am quite confident that you talented people will manage. After all, other Linuxes manage, too, (plus importing previous user-profiles from a pre-existing /home on the fly) without endless waiting-periods. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c20 --- Comment #20 from Richard Creighton 2007-10-01 06:52:59 MST --- (In reply to comment #16 from Thomas Fehr)

Since 10.3 development is over now, I will implement code in STABLE (while will become next openSuSE/SLES release) that look at the fs intended to be used for /home and suppresses formatting if heuristics indicate it is a valid /home filesystem.

I still consider this a bogus feature since it involves mounting a potetially large filesystem with unknown content and state. If the filesystem happens to be dirty, the log replay alone may take minutes and there is no save way to prevent these minutes to be wasted, but in the end it is probably less time consuming to implement that stuff than to discuss this forever.

I suggest then making a pop-up dialog when this occurs and let the operator make the decision. There are already many delays in the installation but one the operator is willing to make is one that saves time in the long run and reconstruction of data structures inadvertently erased or formatted takes longer than remounting a dirty partition and by asking you have alerted the operator and if there is a delay, he also now knows the reason. If they don't want to save the existing data/structure, proceed as you currently propose to do. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c22 --- Comment #22 from Federico Mena Quintero 2007-10-01 11:30:40 MST --- Thanks for working on this, Thomas! Every time I do an install I get a cold sweat when I see that my /home may go away :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c24 --- Comment #24 from Stanislav Brabec 2007-10-02 04:37:53 MST --- It is quite convenient to do a "safe upgrade" as a new installation to the dedicated partition and keeping the old SuSE instance as the default until all tests and customizations of the new one are complete. There are already YaST modules for searching the best-fit old instance to read old ssh keys, old /etc/hosts. It would be very nice, if it would be able to read /etc/fstab as well. I know, that is is not so simple as it sounds, because device might have a different name, one must guess which OS instance is the oldest. (It will also require NFS client configuration behavior change.) Here are few ideas to improve user experience: 1) Ask user, what should be removed: If partitioning scheme conforms OpenSUSE needs, then maybe a following question would be good: There is no free or empty partition nor reserved space on your system. Please choose what to do: (selected) Overwrite partition with label "SuSE Linux 10.0" Overwrite partition with SuSE Linux 10.1 Overwrite partition with OpenSUSE 10.2 Overwrite partition with label "Home" Overwrite partition with label "Swap" If it does not conform, suggest possible ways to solve: Your disc partitioning does not conform OpenSUSE 11.0 needs: - No system partition has enough size - Swap recommended for your RAM size is too small .. Please choose what to do: Backup the whole disc and repartition from scratch Format previous "Home" as / (Home Warning) Format previous "SuSE_Linux_10.1" as swap Implementing this calls back a comment from the previous discussion: Resetting the label when formatting to a really descriptive one (e. g. "OpenSUSE_11.0" for /, "OpenSUSE_11.0_usr" for /usr, "OpenSUSE_11.0_var" for /var, "Swap" for swap, "Home" for /home etc.) 2) Home Warning A special home warning for formatting of partitions with non empty /home directory and partitions with "Home" string in the name (optionally translated, depends on future default names proposal): It seems that you are overwriting non-empty home directory! Please confirm deleting of these user data. 3) Safe delete There is a chance for a "safe formatting" as an addition to Format/Not format: long fsck and rm -rf of everything except selected directories (e. g. /home). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c26 --- Comment #26 from Christian Jäger 2007-10-05 09:31:19 MST --- Agreed with that. I think that the root of the problem is twofold: Firstly, the 'upgrade'-option seems to have 'bad reputation' though I don't know whether this is at all based on actual problems; I haven't searched bugzilla for it So many people prefer a 'clean' install that only keeps /home intact. Now that creating a partition for /home is suggested by default, the logical step is to leave it alone. 'Clean' install doesn't mean the same as before. Perhaps we should look at the 'upgrade'-option, too and see what, if anything, is wrong with it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c28 --- Comment #28 from Christian Jäger 2007-10-08 14:37:47 MST --- Done: Bug #331939 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380#c29 Federico Mena Quintero changed: What |Removed |Added ---------------------------------------------------------------------------- Component|YaST2 |YaST2 Product|openSUSE 10.2 |openSUSE 10.3 --- Comment #29 from Federico Mena Quintero 2007-10-10 23:55:17 MST --- This probably won't get fixed for 10.2; moving to 10.3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=249380 User fehr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=249380#c30 Thomas Fehr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #30 from Thomas Fehr 2007-12-19 03:38:09 MST --- I now added code that checks if the filesystem that the proposal selected for /home already contains a valid home filesystem. If this is the case the partition used for /home is not formatted any more. This change will be available in with 11.0 Alpha1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.