http://bugzilla.suse.com/show_bug.cgi?id=914415 Martin Pluskal changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mpluskal@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 --- Comment #1 from Liuhua Wang --- Here is the services in lvm2.spec: %pre %service_add_pre lvm2-lvmetad.socket lvm2-lvmetad.service %post /sbin/ldconfig %{?regenerate_initrd_post} %service_add_post lvm2-lvmetad.socket lvm2-lvmetad.service %posttrans %{?regenerate_initrd_posttrans} %preun %service_del_preun lvm2-lvmetad.socket lvm2-lvmetad.service %postun /sbin/ldconfig %service_del_postun lvm2-lvmetad.socket lvm2-lvmetad.service I think the reason is because socket/service restarted by %service_del_postun. because the problem disappears in case of install and only occurs in case of update. /usr/lib/rpm/macros: %service_del_postun() %{restart_on_update %{1}} So I think I should delete lvm2-lvmetad.service from the 4 sections(pre/post/preun/postun) since what I expected is lvm2-lvmetad.socket is active but lvm2-lvmetad.service inactive, right? But then I did another test: 1. let lvm2-lvmetad.socket active and lvm2-lvmetad.service inactive. # systemctl status lvm2-lvmetad.socket lvm2-lvmetad.socket - LVM2 metadata daemon socket Loaded: loaded (/usr/lib/systemd/system/lvm2-lvmetad.socket; enabled) Active: active (listening) since Fri 2015-01-23 16:25:18 CST; 2s ago Docs: man:lvmetad(8) Listen: /run/lvm/lvmetad.socket (Stream) # systemctl status lvm2-lvmetad.service lvm2-lvmetad.service - LVM2 metadata daemon Loaded: loaded (/usr/lib/systemd/system/lvm2-lvmetad.service; disabled) Active: inactive (dead) Docs: man:lvmetad(8) 2. #systemctl restart lvm2-lvmetad.socket 3. Then both socket and service are active. # systemctl status lvm2-lvmetad.socket lvm2-lvmetad.socket - LVM2 metadata daemon socket Loaded: loaded (/usr/lib/systemd/system/lvm2-lvmetad.socket; enabled) Active: active (running) since Fri 2015-01-23 16:25:44 CST; 3s ago Docs: man:lvmetad(8) Listen: /run/lvm/lvmetad.socket (Stream) # systemctl status lvm2-lvmetad.service lvm2-lvmetad.service - LVM2 metadata daemon Loaded: loaded (/usr/lib/systemd/system/lvm2-lvmetad.service; disabled) Active: active (running) since Fri 2015-01-23 16:25:44 CST; 7s ago Docs: man:lvmetad(8) Main PID: 3584 (lvmetad) CGroup: /system.slice/lvm2-lvmetad.service └─3584 /sbin/lvmetad -f I also repeat the above test with the 3rd step using 'systemctl try-restart', the test result is same as 'systemctl restart'. Is that a systemd bug? # rpm -qi systemd Name : systemd Version : 210 Release : 25.5.4 Architecture: x86_64 Install Date: Sun 26 Oct 2014 17:12:52 CST Group : System/Base Size : 12744854 License : LGPL-2.1+ Signature : RSA/SHA256, Tue 14 Oct 2014 15:38:11 CST, Key ID b88b2fd43dbdc284 Source RPM : systemd-210-25.5.4.src.rpm Build Date : Tue 14 Oct 2014 15:36:09 CST Build Host : cloud120 Relocations : (not relocatable) Packager : http://bugs.opensuse.org Vendor : openSUSE -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 Liuhua Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lwang@suse.com |bnc-team-screening@forge.pr | |ovo.novell.com -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 --- Comment #2 from Martin Pluskal --- (In reply to Liuhua Wang from comment #1)

Here is the services in lvm2.spec: %pre %service_add_pre lvm2-lvmetad.socket lvm2-lvmetad.service

%post /sbin/ldconfig %{?regenerate_initrd_post} %service_add_post lvm2-lvmetad.socket lvm2-lvmetad.service

%posttrans %{?regenerate_initrd_posttrans}

%preun %service_del_preun lvm2-lvmetad.socket lvm2-lvmetad.service

%postun /sbin/ldconfig %service_del_postun lvm2-lvmetad.socket lvm2-lvmetad.service

I think the reason is because socket/service restarted by %service_del_postun. It seems that while issuing "systemctl try-restart lvm2-lvmetad.service" does not start stopped service: # systemctl try-restart lvm2-lvmetad.service # systemctl status lvm2-lvmetad.service lvm2-lvmetad.service - LVM2 metadata daemon Loaded: loaded (/usr/lib/systemd/system/lvm2-lvmetad.service; disabled) Active: inactive (dead) since Fri 2015-01-23 09:42:15 CET; 8s ago Docs: man:lvmetad(8) Process: 1746 ExecStart=/sbin/lvmetad -f (code=exited, status=0/SUCCESS) Main PID: 1746 (code=exited, status=0/SUCCESS)

issuing "systemctl try-restart lvm2-lvmetad.service lvm2-lvmetad.socket" or "systemctl try-restart lvm2-lvmetad.socket" does: # systemctl try-restart lvm2-lvmetad.service lvm2-lvmetad.socket # systemctl status lvm2-lvmetad.service lvm2-lvmetad.service - LVM2 metadata daemon Loaded: loaded (/usr/lib/systemd/system/lvm2-lvmetad.service; disabled) Active: active (running) since Fri 2015-01-23 09:43:26 CET; 5s ago Docs: man:lvmetad(8) Main PID: 1773 (lvmetad) CGroup: /system.slice/lvm2-lvmetad.service └─1773 /sbin/lvmetad -f So as long as lvm2-lvmetad.socket is enabled, lvm2-lvmetad.service will be started on update. Usage of %postun macro itself is correct, however if lvm2-lvmetad.socket should be enabled in presets is different question. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 --- Comment #4 from Lidong Zhong --- What's the current definition of the following four macros in OBS: %service_add_pre %service_add_post %service_del_preun %service_del_postun If it's the same as in SLES11-SP3, it should be OK to remove lvm2-lvmetad.* from these macro list, since lvm2-lvmetad.socket is already enabled in preset. When doing upgrade it's enabled and running and systemctl daemon-reload will also be run. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 --- Comment #6 from Liuhua Wang --- (In reply to Martin Pluskal from comment #5)

I hope that I don't need to remind you that %service_* macros used for a reason, solving one issue by blindly removing them will likely cause different issues. What seems to be reason for observed behavior is described in comment#3 , lets wait for some output from systemd maintainers.

One possible solution that comes to my mind would be to remove .socket from %service_* macros, other would be inspired by X11:XOrg/xdm/xdm.spec - adding "export DISABLE_RESTART_ON_UPDATE=yes" to %postun section.

Yes, if not add to the 4 sections, the socket will not be active. @Lidong, you can see another bug about this: bnc#908791 - lvm2-lvmetad.socket is enabled in sles-preset but is disable in systemctl status -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 Chenzi Cao changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bnc-team-screening@forge.pr |systemd-maintainers@suse.de |ovo.novell.com | --- Comment #8 from Chenzi Cao --- Hi Systemd-maintainers, would you please kindly help to have a look at here? I'm not sure whether it is right to assign it to you, please feel free to reassign whenever necessary, thank you! -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 --- Comment #10 from Dr. Werner Fink --- Btw: before reopen this bug *reassign* it to the correct package maintainer. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 --- Comment #16 from Martin Pluskal --- If I may ask, what would you suggest, removing .socket from %postun, adding export DISABLE_RESTART_ON_UPDATE=yes or something else? -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 --- Comment #19 from Dr. Werner Fink --- (In reply to Martin Pluskal from comment #16) IMHO the `systemctl try-restart' on a socket isn't that what should be done. Therefore a Also=lvm2-lvmetad.socket in the `[Install]' section of the "lvm2-lvmetad.service" should be sufficient to be ablle to remove"lvm2-lvmetad.service" from the %service_add_* macro lines in the spec file.

From man:systemctl(1)

enable NAME... [...] Enabling units should not be confused with starting (activating) units, as done by the start command. Enabling and starting units is orthogonal: units may be enabled without being started and started without being enabled. Enabling simply hooks the unit into various suggested places (for example, so that the unit is automatically started on boot or when a particular kind of hardware is plugged in). Starting actually spawns the daemon process (in case of service units), or binds the socket (in case of socket units), and so on. that is if an *traffic* event occurs on a socket then it starts the service. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 Dr. Werner Fink changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jengelh@inai.de --- Comment #21 from Dr. Werner Fink --- (In reply to Liuhua Wang from comment #20) The macro %service_add_post() does *not* use the command start nor stop nor try-restart but only preset. Maybe it would make sense to skip types *.socket from from start and try-restart. Nevertheless removing the *.socket from %service_del_preun(), %service_del_postun(), and %systemd_postun_with_restart() should be enough (IMHO) -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=914415 Liuhua Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #27 from Liuhua Wang --- close as fixed. -- You are receiving this mail because: You are on the CC list for the bug.