http://bugzilla.novell.com/show_bug.cgi?id=567887 http://bugzilla.novell.com/show_bug.cgi?id=567887#c1 Jeff Mahoney changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium CC| |jeffm@novell.com AssignedTo|kernel-maintainers@forge.pr |jeffm@novell.com |ovo.novell.com | --- Comment #1 from Jeff Mahoney 2010-03-19 15:16:10 UTC --- Interesting. The underlying files are still there. I can reliably crash tmpfs by umount it after umounting the ecryptfs on top of it. The dentries that ecryptfs created on tmpfs still exist, they're just not visible for some reason. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=567887 http://bugzilla.novell.com/show_bug.cgi?id=567887#c3 --- Comment #3 from Jeff Mahoney 2010-03-19 19:36:19 UTC --- Created an attachment (id=349575) --> (http://bugzilla.novell.com/attachment.cgi?id=349575) [PATCH] ecryptfs: fix use with tmpfs by removing d_drop from ecryptfs_destroy_inode Since tmpfs has no persistent storage, it pins all its dentries in memory so they have d_count=1 when other file systems would have d_count=0. ->lookup is only used to create new dentries. If the caller doesn't instantiate it, it's freed immediately at dput(). ->readdir reads directly from the dcache and depends on the dentries being hashed. When an ecryptfs mount is mounted, it associates the lower file and dentry with the ecryptfs files as they're accessed. When it's umounted and destroys all the in-memory ecryptfs inodes, it fput's the lower_files and d_drop's the lower_dentries. Commit 4981e081 added this and a d_delete in 2008 and several months later commit caeeeecf removed the d_delete. I believe the d_drop() needs to be removed as well. The d_drop effectively hides any file that has been accessed via ecryptfs from the underlying tmpfs since it depends on it being hashed for it to be accessible. I've removed the d_drop on my development node and see no ill effects with basic testing on both tmpfs and persistent storage. As a side effect, after ecryptfs d_drops the dentries on tmpfs, tmpfs BUGs on umount. This is due to the dentries being unhashed. tmpfs->kill_sb is kill_litter_super which calls d_genocide to drop the reference pinning the dentry. It skips unhashed and negative dentries, but shrink_dcache_for_umount_subtree doesn't. Since those dentries still have an elevated d_count, we get a BUG(). This patch removes the d_drop call and fixes both issues. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=567887 https://bugzilla.novell.com/show_bug.cgi?id=567887#c5 Jeff Mahoney changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED Target Milestone|--- |Future 11.3 --- Comment #5 from Jeff Mahoney 2011-01-17 16:54:56 UTC --- This patch was accepted shortly after I submitted it and is part of 2.6.34 for openSUSE 11.3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.