[Bug 837450] New: yast triggers on xorg-x11
https://bugzilla.novell.com/show_bug.cgi?id=837450 https://bugzilla.novell.com/show_bug.cgi?id=837450#c0 Summary: yast triggers on xorg-x11 Classification: openSUSE Product: openSUSE Factory Version: 13.1 Milestone 4 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 AssignedTo: yast2-maintainers@suse.de ReportedBy: lnussel@suse.com QAContact: jsrain@suse.com CC: coolo@suse.com, sndirsch@suse.com Found By: --- Blocker: --- yast decides whether or not the installation has X based on the presence of the xorg-x11 package. This pakages nowadays is only a placeholder that recommends all kinds of optional packages. It's not meant to be installed by default anymore. So yast needs to trigger on another core X package instead. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c1
Stefan Dirsch
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c2
--- Comment #2 from Egbert Eich
Assuming X based means a Xserver running on the same (virtual) machine for installation, i.e. a graphical installation, the package "xorg-x11-server" would be a good choice.
If this is the right choice depends on what YaST does when it believes an installation should be in gfx mode: if it launches and Xserver it needs to check for the presence of one. But as far as I know it can also launch Xvnc which is in a different package IHMO. Generally is would be a good idea to check if the binary it is trying to launch is available before executing it instead of making things depend on a package. Also fallbacks if this binary fails would be good to have. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c3
--- Comment #3 from Stephan Kulow
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c4
--- Comment #4 from Stefan Dirsch
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c
Jiří Suchomel
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c5
Jiří Suchomel
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c6
Stefan Dirsch
1. There's X11Version.have_x11 function that should check "if X11 is installed ". It returns true if "xorg-x11", "yast2-x11", "sax2" packages are installed... hm, looking at that sax2 check it appears the functions is never actually used.
sax2 no longer exists. Was already dropped with openSUSE 12.3. There was only sax2-tools still, but the necessary tools have been moved to yast2-tools for openSUSE factory. Dead code can and should be removed.
2. There's requirement of xorg-x11 package in control.xml in the case of "minimal X11" installation. This should be replaced by xorg-x11-server, as it is probably the case when xorg-x11 is selected for installation.
Ok.
3. Than there's a check if xorg-x11 is selected for installation in x11_finish.rb Here it tries to detect XFree86 version 3 and copy the files to current system during the update:
Which files are copied?
This must be years old: Stefan, I assume that these parts can be completely removed, right?
It's block starting at https://github.com/yast/yast-installation/blob/master/src/clients/x11_finish...
The XFree86 3.x code can be removed, yes. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c7
Jiří Suchomel
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c8
--- Comment #8 from Stephan Kulow
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c9
--- Comment #9 from Jiří Suchomel
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c10
--- Comment #10 from Stefan Dirsch
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c11
Jiří Suchomel
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c12
Stefan Dirsch
On related note: there's currently piece of code that backs up /etc/X11/xorg.conf from inst-sys to installed system.(at the end of first stage)
Steffen, do you think this is still useful, or could I drop that part as well?
We still want to use this special config during second stage of installation (so we're using the same Xorg configuration as with the first stage). After a successful installation it should be moved to /etc/X11/xorg.conf.install on the installed system. So this did not change. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c13
Jiří Suchomel
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c14
Frederic Crozat
I submitted changes for skelcd-control-openSUSE, but I'm not sure where to fix skelcd-control-SLED. I assume SUSE:SLE-11-SP3:GA is not relevant...
I wouldn't change the SLED file for SLE-11 (since X11 stack won't change there). I'll take care of the SLED 12 file. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c15
Ludwig Nussel
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c16
--- Comment #16 from Ludwig Nussel
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c17
Jiří Suchomel
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c18
--- Comment #18 from Ludwig Nussel
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c19
Josef Reidinger
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c20
--- Comment #20 from Josef Reidinger
https://bugzilla.novell.com/show_bug.cgi?id=837450
https://bugzilla.novell.com/show_bug.cgi?id=837450#c21
Josef Reidinger
participants (1)
-
bugzilla_noreply@novell.com