https://bugzilla.novell.com/show_bug.cgi?id=384159 User jpr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=384159#c2 JP Rosevear changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-gnome@forge.provo.novell.com |federico@novell.com Severity|Normal |Major Status Whiteboard| |gnome-showstopper --- Comment #2 from JP Rosevear 2008-04-30 14:46:01 MST --- Bug 384021 may be the same thing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=384159 User alberto.passalacqua@tin.it added comment https://bugzilla.novell.com/show_bug.cgi?id=384159#c3 Alberto Passalacqua changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alberto.passalacqua@tin.it Version|Factory |Beta 2 --- Comment #3 from Alberto Passalacqua 2008-05-03 20:54:13 MST --- Still in beta 2. Moving... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=384159 Federico Mena Quintero changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=384159 User federico@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=384159#c6 --- Comment #6 from Federico Mena Quintero 2008-05-05 13:06:44 MST ---

From the ChangeLog (grrrr, the merge to Subversion lost this; I wish we were using git):

commit f93f1c03534fd8e72c354e9f6f91c4270f39a045 Author: David Zeuthen Date: Mon Oct 15 21:25:20 2007 -0400 do grab the keyboard anyway After some more testing, it appears to work with Orca. At least when Orca doesn't fail to work... src/polkit-gnome-manager.c | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) commit 37377d244ea6d3d3d46972dc9e948c3e88a4f98b Author: David Zeuthen Date: Mon Oct 15 18:07:11 2007 -0400 don't grab the X keyboard; only grab the X pointer There's a couple of reasons for this; first, grabbing the keyboard breaks accessibility; try for yourself or see some horrible workaround that Orca built into their application (and, sigh, they don't even bother testing for whether gksu is installed anyway); http://live.gnome.org/Orca/ConfigurationGui#head-eed11f78d766f588c85a5b4fd69... Second, it's sufficient for our purposes (to keep focus on our password dialog) to just grab the pointer Third, "XGrabKeyboard is not a security interface" http://seclists.org/fulldisclosure/2005/May/0676.html And, sure, try xspy.c to see that even with the keyboard grabbed we can still get key strokes. There's a couple of mails flying around the net saying the XSECURITY extension should fix this; it doesn't appear gnome-screensaver is using this (probably it doesn't want to break a11y either?) and also some other comments that even XSECURITY is not adequate. Bottom line is that we probably want to wait until XACE is in... src/polkit-gnome-manager.c | 20 +++++++------------- 1 files changed, 7 insertions(+), 13 deletions(-) commit 19ac8b3d6e7ba19ddf062a0f18c4542741d1dfc2 Author: David Zeuthen Date: Fri Oct 12 23:33:44 2007 -0400 grab the pointer and keyboard when showing an auth dialog src/polkit-gnome-manager.c | 32 +++++++++++++++++++++++++++++++- 1 files changed, 31 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=384159 User federico@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=384159#c8 --- Comment #8 from Federico Mena Quintero 2008-05-05 17:32:16 MST --- Aha! The problem with the auth dialog appearing behind the clock's popup window only happens for me in click-to-focus mode in Metacity. I was using sloppy-focus, and the bug doesn't happen then. I'll investigate. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=384159 User federico@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=384159#c10 --- Comment #10 from Federico Mena Quintero 2008-05-05 18:59:19 MST --- Note to self: metacity/src/core/window.c:2155 if (overlap || (meta_prefs_get_focus_mode () == META_FOCUS_MODE_CLICK && meta_prefs_get_raise_on_click ())) meta_window_stack_just_below (window, focus_window); Both click-to-focus and sloppy-focus end up calling that meta_window_stack_just_below(), so *that* is not the culprit code. Moreover, focus_window is *not* the clock window (that one doesn't get the input focus, and is a DOCK window anyway, on a layer above the rest, I think). The call to stack_just_below() happens because overlap=TRUE always if the focus_window is the desktop window (that is, the auth dialog *always* overlaps the desktop). However, I couldn't find another thing in the code around meta_window_show() that would stack windows differently based on the focus mode. I guess I'll have to compare log files for runs with the different focus modes. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=384159 User federico@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=384159#c12 --- Comment #12 from Federico Mena Quintero 2008-05-08 11:41:47 MST --- I just discovered that the panel clock does *not* pass an XID as the transient parent to the org.gnome.PolicyKit.Manager.ShowDialog method (it just passes 0), so the window manager will not know what the auth dialog is relative to. I'll attach a patch to fix this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=384159 User federico@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=384159#c14 Federico Mena Quintero changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #213665|0 |1 is obsolete| | --- Comment #14 from Federico Mena Quintero 2008-05-08 16:48:00 MST --- Created an attachment (id=213755) --> (https://bugzilla.novell.com/attachment.cgi?id=213755) gnome-panel-bnc384159-clock-auth-dialog-transient-parent.diff This one actually works -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=384159 User federico@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=384159#c16 --- Comment #16 from Federico Mena Quintero 2008-05-09 19:22:18 MST --- Created an attachment (id=214114) --> (https://bugzilla.novell.com/attachment.cgi?id=214114) policykit-gnome-bnc384159-bgo531609-no-grabs.diff Patch for PolicyKit-gnome. This makes the auth dialog not grab the mouse/keyboard. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=384159 User federico@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=384159#c18 Federico Mena Quintero changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #18 from Federico Mena Quintero 2008-05-09 19:34:46 MST --- Submitted the metacity patch as well; the fix should be in Beta4. * Fri May 09 2008 - federico@novell.com - Added metacity-bnc384159-bgo519188-window-overlaps-itself.diff to fix https://bugzilla.novell.com/show_bug.cgi?id=384159 - Fix the logic for focus stealing and overlapping windows. This is the last patch; marking the bug as fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.