[Bug 207686] New: torcs-1.2.4-25: undefined C code
https://bugzilla.novell.com/show_bug.cgi?id=207686 Summary: torcs-1.2.4-25: undefined C code Product: openSUSE 10.2 Version: Alpha 4 plus Platform: All OS/Version: SuSE Linux 10.1 Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de I just tried to compile package torcs-1.2.4-25 with the GNU C compiler. The compiler said track.cpp:1018: warning: operation on 'nbvert' may be undefined The source code is SETPOINT(texLen, 0, x, y, RtTrackHeightL(&trkpos)); but #define SETPOINT(t1, t2, x, y, z) do { \ if (*(curTexElt->name) != 0) { \ tracktexcoord[2*nbvert] = t1; \ tracktexcoord[2*nbvert+1] = t2; \ trackvertices[3*nbvert] = x; \ trackvertices[3*nbvert+1] = y; \ trackvertices[3*nbvert+2] = z; \ trackindices[nbvert] = nbvert++; \ } \ } while (0) Suggest new code #define SETPOINT(t1, t2, x, y, z) do { \ if (*(curTexElt->name) != 0) { \ tracktexcoord[2*nbvert] = t1; \ tracktexcoord[2*nbvert+1] = t2; \ trackvertices[3*nbvert] = x; \ trackvertices[3*nbvert+1] = y; \ trackvertices[3*nbvert+2] = z; \ trackindices[nbvert] = nbvert; \ nbvert++; \ } \ } while (0) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=207686 mkoenig@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |sndirsch@novell.com |screening@forge.provo.novell| |.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=207686 sndirsch@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Priority|P5 - None |P2 - High ------- Comment #1 from sndirsch@novell.com 2006-09-22 12:44 MST ------- Yes. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=207686 sndirsch@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |WONTFIX ------- Comment #2 from sndirsch@novell.com 2006-10-10 07:47 MST ------- There are 338 occurences for this warning. I won't fix these unless you attach a patch. Feel free to reopen, if it's that important to you. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=207686 dcb314@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX | ------- Comment #3 from dcb314@hotmail.com 2006-10-10 08:40 MST -------
There are 338 occurences for this warning.
True, but irrelevant isn't it ?
Feel free to reopen, if it's that important to you.
It is. 10.2 is soon. My proposed fix is a one liner. Suggest either prove it wrong or apply it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=207686 sndirsch@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO Info Provider| |dcb314@hotmail.com ------- Comment #4 from sndirsch@novell.com 2006-10-10 08:48 MST ------- (In reply to comment #3)
There are 338 occurences for this warning.
True, but irrelevant isn't it ?
Right, most of them are the calls not the definition itself. I apologize.
My proposed fix is a one liner. Suggest either prove it wrong or apply it.
What about the definition of SETPOINT2. It's the same issue, isn't it? Since you're doing very good investigations and explanations, why something is wrong. What about attaching a patch to make things even easier for us? Just an idea. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=207686 dcb314@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|dcb314@hotmail.com | ------- Comment #5 from dcb314@hotmail.com 2006-10-10 11:56 MST ------- (In reply to comment #4)
Right, most of them are the calls not the definition itself. I apologize.
Apology accepted.
What about the definition of SETPOINT2. It's the same issue, isn't it?
True, but that isn't what I reported. If you just want to fix what I reported, then that's fine. Time is short. If you want to fix every undefined code message in the package, then that would be even better, but not required.
What about attaching a patch to make things even easier for us? Just an idea.
Good idea, but the more time I spend attaching patches is less time actually finding the problems. Since I appear to be the only one finding these problems and there appear to be dozens of Novell support staff willing to answer my bug reports, the tradeoff is easy. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=207686 sndirsch@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #6 from sndirsch@novell.com 2006-10-10 15:04 MST ------- fixed for Beta1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply@novell.com