https://bugzilla.novell.com/show_bug.cgi?id=895825 https://bugzilla.novell.com/show_bug.cgi?id=895825#c1 David Disseldorp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddiss@suse.com, | |dsterba@suse.com, | |fdmanana@suse.com --- Comment #1 from David Disseldorp 2014-09-09 14:21:32 UTC --- Thanks for the report Andreas. (In reply to comment #0) ...

Steps to Reproduce: asn@magrathea:~/workspace/projects/samba/git> cd st/ asn@magrathea:~/workspace/projects/samba/git/st> mkdir a asn@magrathea:~/workspace/projects/samba/git/st> chattr +c a asn@magrathea:~/workspace/projects/samba/git/st> touch a/file asn@magrathea:~/workspace/projects/samba/git/st> lsattr a/file --------c------- a/file asn@magrathea:~/workspace/projects/samba/git/st> chattr -c a asn@magrathea:~/workspace/projects/samba/git/st> touch a/file2 asn@magrathea:~/workspace/projects/samba/git/st> lsattr a/file2 --------c------- a/file2 asn@magrathea:~/workspace/projects/samba/git/st> lsattr -d a ---------------- a

So the problem is that the compression flag continues to be inherited by nested files after it has been cleared on the parent directory. I'm not able to reproduce this on openSUSE 13.1 or SLE12, so this appears to be a newly introduced regression. I'll look at putting together an xfstests reproducer for this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=895825 https://bugzilla.novell.com/show_bug.cgi?id=895825#c3 --- Comment #3 from Filipe Manana 2014-09-10 12:42:05 UTC --- This is because chattr -c just doesn't pass FS_NOCOMP_FL to the ioctl. It gets current flags, clears the FS_COMPR_FL flag, and sends the result to the ioctl. The ioctl handler only removes the compression property if FS_NOCOMP_FL is present in the new flags, which isn't. I didn't knew about this behaviour until looking at bnc#818373, i.e. David are you already on it? This is a simple patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=895825 https://bugzilla.novell.com/show_bug.cgi?id=895825#c5 Filipe Manana changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED AssignedTo|kernel-maintainers@forge.pr |fdmanana@suse.com |ovo.novell.com | --- Comment #5 from Filipe Manana 2014-09-10 14:13:53 UTC --- Alright, sent upstream: https://patchwork.kernel.org/patch/4877831/ -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=895825 https://bugzilla.novell.com/show_bug.cgi?id=895825#c7 --- Comment #7 from David Disseldorp 2014-09-11 11:36:05 UTC --- (In reply to comment #6)

Forgot to mention before, but to get around 'chattr -c' not working, you can use:

btrfs property set some_dir_or_file ''

It requires btrfs-progs v3.14+.

This bug was the result of a Samba vfs_btrfs workload, which uses ioctl(FS_IOC_SETFLAGS/FS_IOC_GETFLAGS): http://git.samba.org/?p=samba.git;a=blob;f=source3/modules/vfs_btrfs.c;hb=HE... We could change it over to manipulate "btrfs.*" xattrs, but I'd prefer to keep it as is. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=895825 https://bugzilla.novell.com/show_bug.cgi?id=895825#c9 --- Comment #9 from Filipe Manana 2014-09-11 12:31:44 UTC --- So should I: 1) add the patch to some kernel-source branch, or 2) do nothing, wait for it to get into some upstream release ddis: another workaround, if you call FS_IOC_SETFLAGS with FS_NOCOMP_FL it disables compression, and then if you don't want that flag, call it again without FS_NOCOMP_FL -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=895825 https://bugzilla.novell.com/show_bug.cgi?id=895825#c11 --- Comment #11 from Andreas Schneider 2014-09-11 12:45:05 UTC ---

I think it's fine to wait for upstream in this case, as this is an openSUSE Factory bug.

So you're sure that this doesn't happen on openSUSE 13.2? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=895825 --- Comment #15 from Filipe Manana --- You'll need kernel 3.16.7. Commit dfcb69eb4babcb4d172570734bd36da424b43388 of openSUSE-13.2 added patches.kernel.org/patch-3.16.6-7. Perhaps you've not installed the latest kernel package or maybe there isn't any available yet for 3.16.7? -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=895825 David Disseldorp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddiss@suse.com --- Comment #17 from David Disseldorp --- (In reply to Filipe Manana from comment #15)

You'll need kernel 3.16.7.

Commit dfcb69eb4babcb4d172570734bd36da424b43388 of openSUSE-13.2 added patches.kernel.org/patch-3.16.6-7. Perhaps you've not installed the latest kernel package or maybe there isn't any available yet for 3.16.7?

I'm on 3.16.6-2 - doesn't look like 3.16.7 is available yet... https://build.opensuse.org/package/view_file/openSUSE:13.2:Update/kernel-des... Thanks for checking. If the fix is queued for maintenance, then this can be closed again IMO. -- You are receiving this mail because: You are on the CC list for the bug.