[Bug 524556] New: extreme-tuxracer-0.4-96.4: 2 * bad calls to C++ STL erase
http://bugzilla.novell.com/show_bug.cgi?id=524556 Summary: extreme-tuxracer-0.4-96.4: 2 * bad calls to C++ STL erase Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: Other OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package extreme-tuxracer-0.4-96.4. For source code file extremetuxracer-0.4/src/ppgltk/audio/audio_data.cpp, around line 440 is the source code for the function delete_unused_audio_data. I notice the following code soundTable.erase(sit); This looks wrong to me. The C++ STL iterator sit will be invalidated by this call. Suggest code rework. Similar problems a few lines further down with C++ STL iterator mit. musicTable.erase(mit); -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524556
Marcus Meissner
http://bugzilla.novell.com/show_bug.cgi?id=524556
User mmaher@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=524556#c1
Maximilian Maher
http://bugzilla.novell.com/show_bug.cgi?id=524556
User dcb314@hotmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=524556#c2
David Binderman
We don't see any Problem with this Code that affect the game.
Standard problem in C++ - erase invalidates iterators. See http://www.cplusplus.com/reference/stl/vector/erase/ -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524556
User mmaher@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=524556#c3
--- Comment #3 from Maximilian Maher
Please contact the upstream developer: volker@planetpenguin.de
Will inform upstream about this "bug". -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524556
User mmaher@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=524556#c4
Maximilian Maher
participants (1)
-
bugzilla_noreply＠novell.com