[Bug 788299] New: SuSEconfig.postfix looses parameter in master.cf (amavisd, postfix, master, install)
https://bugzilla.novell.com/show_bug.cgi?id=788299 https://bugzilla.novell.com/show_bug.cgi?id=788299#c0 Summary: SuSEconfig.postfix looses parameter in master.cf (amavisd, postfix, master, install) Classification: openSUSE Product: openSUSE 12.2 Version: Final Platform: i686 OS/Version: openSUSE 12.2 Status: NEW Severity: Normal Priority: P5 - None Component: Installation AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: christian.eberl@workingbits.at QAContact: jsrain@suse.com Found By: --- Blocker: --- Created an attachment (id=512050) --> (http://bugzilla.novell.com/attachment.cgi?id=512050) patch for SuSEconfig.postfix User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20100101 Firefox/16.0 The first execution of SuSEconfig.postfix drops "smtpd_client_restrictions" override option(s) and leads to a duplicated entry in master.cf. This happens inside the SuSEconfig.postfix script, while checking for the override option "smtpd_client_restrictions". This option is lost and instead the previous found parameter is duplicated into the new master.cf. Although this happens within the commented section of master.cf, the affacted postfix parameter(s) may be applied to an uncommented section. At least for amavisd users, the affected changes go to an uncommented section. Chances are to see these duplicated entries right after installing postfix (or on any installed system with postfix). It seems there are circumstances where SuSEconfig.postfix gets automatically executed and some where it isn't executed. I can't report the exact steps I took, but I had both while testing. As this is by default in a commented section, the original line can also be manually inserted. Reproducible: Always Steps to Reproduce: 1. restore master.cf from original rpm distribution 1a. (keep a backup of original master.cf) 2. ensure /etc/sysconfig/mail: MAIL_CREATE_CONFIG="yes" 3. execute SuSEconfig.postfix Actual Results: duplicated line: #submission inet n - n - - smtpd # -o smtpd_tls_security_level=encrypt # -o smtpd_sasl_auth_enable=yes # -o smtpd_sasl_auth_enable=yes Expected Results: unmodified copy: #submission inet n - n - - smtpd # -o smtpd_tls_security_level=encrypt # -o smtpd_sasl_auth_enable=yes # -o smtpd_client_restrictions=permit_sasl_authenticated,reject The patch produces the expected result, but need analysis because my Perl knowledge is limited. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=788299
https://bugzilla.novell.com/show_bug.cgi?id=788299#c
Christian Boltz
https://bugzilla.novell.com/show_bug.cgi?id=788299
https://bugzilla.novell.com/show_bug.cgi?id=788299#c1
Wolfgang Rosenauer
https://bugzilla.novell.com/show_bug.cgi?id=788299
https://bugzilla.novell.com/show_bug.cgi?id=788299#c2
--- Comment #2 from Christian Boltz
https://bugzilla.novell.com/show_bug.cgi?id=788299
https://bugzilla.novell.com/show_bug.cgi?id=788299#c3
Wolfgang Rosenauer
https://bugzilla.novell.com/show_bug.cgi?id=788299
https://bugzilla.novell.com/show_bug.cgi?id=788299#c4
Peter Varkoly
It seems there are circumstances where SuSEconfig.postfix gets automatically executed ... There are no circumstances where /usr/sbin/config.postfix gets automatically executed. /usr/sbin/config.postfix will be executed only when you are using yast2-mail.# "#-o smtpd_sasl_auth_enable=yes" is duplicated in our original postfix package.
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=788299
https://bugzilla.novell.com/show_bug.cgi?id=788299#c5
Christian Boltz
There are no circumstances where /usr/sbin/config.postfix gets automatically executed. /usr/sbin/config.postfix will be executed only when you are using yast2-mail.
Are you sure? I setup a new server with openSUSE 13.1, and some days later my main.cf and master.cf were broken as described in this bugreport, without any backup of my manually modified files :-( Needless to say: I did't use yast2 mail or config.postfix. Unfortunately this also means I have no idea why or by what config.postfix was run... Anyway - config.postfix should at least create a backup copy of main.cf and master.cf before modifying them. A md5sum check would be even better (and if it matches the last-known md5sum, I'm ok with not doing another backup). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=788299
https://bugzilla.novell.com/show_bug.cgi?id=788299#c6
--- Comment #6 from Christian Eberl
There are no circumstances where /usr/sbin/config.postfix gets automatically executed. /usr/sbin/config.postfix will be executed only when you are using yast2-mail.# "#-o smtpd_sasl_auth_enable=yes" is duplicated in our original postfix package.
Hmmm, well - no. To both. I downloaded install rpms from http://download.opensuse.org/distribution/13.1/repo/oss/suse/i586/ (12.2, 12.3, 13.1 and Factory). In no (unpacked) rpm is a duplicated sasl-auth-enable in master.cf. Additionally I checked main.cf - every rpm contains an "inet_interfaces = all", which comes from the applied postfix-main.cf.patch (https://build.opensuse.org/package/view_file/openSUSE:13.1/postfix/postfix-m...) So for every version, there must be "something" changing at least main.cf... Lets stay on 13.1 (applies also for Factory): https://build.opensuse.org/package/show/openSUSE:13.1/postfix In postfix-SuSE.tar.gz are two relevant files for this issue: postfix.service:
ExecStartPre=/etc/postfix/system/config_postfix <<
config_postfix.systemd: (gets installed to /etc/postfix/system/config_postfix)
#!/bin/bash
if [ ! -e /var/adm/postfix.configured ]; then echo "First configuration of postfix" /usr/sbin/config.postfix touch /var/adm/postfix.configured fi << Well, at least for 13.1 (and Factory) config.postfix gets executed by definition. Because of "inet_interfaces = all" in main.cf, I'm pretty sure there must be some equivalent mechanism to modify main.cf in all versions... Note: I'm using "Text-mode only" installations; on my system, postfix.service does not get started automatically after installation; there I get unmodified versions of main.cf and master.cf -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=788299
https://bugzilla.novell.com/show_bug.cgi?id=788299#c7
Peter Varkoly
Well, at least for 13.1 (and Factory) config.postfix gets executed by definition. Because of "inet_interfaces = all" in main.cf, I'm pretty sure there must be some equivalent mechanism to modify main.cf in all versions...
Yes but this is postfix it self by calling /usr/sbin/postfix set-permissions upgrade-configuration setgid_group=maildrop And this must be called even the configuration may be worst. Now we have checks in %post section to keep the md5sums of the configuration files correct. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com