[Bug 859009] New: xen-blkfront: remove type check from blkfront_setup_discard
https://bugzilla.novell.com/show_bug.cgi?id=859009 https://bugzilla.novell.com/show_bug.cgi?id=859009#c0 Summary: xen-blkfront: remove type check from blkfront_setup_discard Classification: openSUSE Product: openSUSE 13.1 Version: Final Platform: x86-64 OS/Version: Linux Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: jbeulich@suse.com ReportedBy: ohering@suse.com QAContact: qa-bugs@suse.de Found By: Outsourced Testing Blocker: --- Created an attachment (id=574628) --> (http://bugzilla.novell.com/attachment.cgi?id=574628) 0001-xen-blkfront-remove-type-che.patch In its initial implementation a check for "type" was added, but only phy and file are handled. This breaks advertised discard support for other type values such as qdisk. Fix and simplify this function: If the backend advertises discard support it is supposed to implement it properly, so enable feature_discard unconditionally. If the backend advertises the need for a certain granularity and alignment then propagate both properties to the blocklayer. The discard-secure property is a boolean, update the code to reflect that. The attached patch should be applied to all active/maintained kernel branches. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=859009
https://bugzilla.novell.com/show_bug.cgi?id=859009#c
Jan Beulich
https://bugzilla.novell.com/show_bug.cgi?id=859009
https://bugzilla.novell.com/show_bug.cgi?id=859009#c1
Jan Beulich
participants (1)
-
bugzilla_noreply@novell.com