[Bug 826700] New: mkinitrd with manual iSCSI drive connected puts unneeded iscsi and tg3 modules in initrd rendering system unbootable
https://bugzilla.novell.com/show_bug.cgi?id=826700 https://bugzilla.novell.com/show_bug.cgi?id=826700#c0 Summary: mkinitrd with manual iSCSI drive connected puts unneeded iscsi and tg3 modules in initrd rendering system unbootable Classification: openSUSE Product: openSUSE 12.3 Version: Final Platform: x86-64 OS/Version: openSUSE 12.3 Status: NEW Severity: Critical Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: kl@httgmbh.net QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0 SeaMonkey/2.17.1 I am using an iSCSI-connected data drive which is set to "manual" and nevertheless automatically mounted after the system has booted. (Options nofail,acl,user_xattr,_netdev in /etc/fstab) In this environment mkinitrd complains: WARNING: iSCSI device /dev/disk/by-path/[...]:storage.lun1-lun-1-part1 is using 'node.conn[0].startup = manual'! WARNING: System not bootable with this setting, need to be set to 'onboot' instead, using: It then puts the following unneeded and unwanted modules into the initrd: Kernel Modules: af_packet tg3 scsi_transport_iscsi libiscsi libiscsi_tcp iscsi_tcp crc32c-intel Firmware: tigon/tg3_tso5.bin tigon/tg3_tso5.bin tigon/tg3_tso.bin tigon/tg3_tso.bin tigon/tg3.bin tigon/tg3.bin Features: network iscsi Unfortunately - due to another bug (Bug 598730) - the tg3 Network driver (still) doesn't work when loaded from initrd and so the boot hangs with no way to interrupt and access the system. Fail-safe mode also doesn't help here. If - before running mkinitrd - I stop the iSCSI service ( systemctl stop iscsid.service ) then the initrd is created the way it should without the unwanted kernel-modules / firmware /features. During automatic updates this is not possible, so... mkinitrd should not try to be smarter than the user here. ;-) Reproducible: Always Steps to Reproduce: 1. configure/start iSCSI to manually connect to a data drive. 2. run mkinitrd. 3. watch initrd beeing created with lots of uneeded modules/features. Actual Results: mkinitrd complains about wrong iSCSI settings and builds initrd containing unneeded modules/features which - in combination with Broadcom Ethernet - render system unbootable. Expected Results: mkinitrd should not complain about "manual" iSCSI and - if iSCSI is configured for "manual" - should NOT include features network/iscsi andnot include iSCSI-modules and network modules. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c
Ye Yuan
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c1
Olaf Hering
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c2
--- Comment #2 from Kai Lappalainen
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c
Kai Lappalainen
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c3
Olaf Hering
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c4
Hannes Reinecke
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c5
Lee Duncan
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c6
Lee Duncan
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c7
Kai Lappalainen
From my understanding the bug ist in /lib/mkinitrd/setup/81-iscsi.sh in the check_for_node_onboot() function:
if [[ "${startup}" != "onboot" ]] ; then.... There is a note also: "## Note: could set "onboot" ourselves here, but that seems heavy-handed" Beware of setting "onboot" "ourselves"!!! If "onboot" is not set, then iSCSI should not be included by mkinitrd. Simple as that, no? If I would want a real boot-time iSCSI volume I would set "startup type" to "onboot". The 81-iscsi.sh script should respect the choosen "startup type". I want the iSCSI volume mounted automatically during system startup after normal network initialisation, but not during boottime from initrd, as indicated by not setting "onboot" startup value. This works perfectly as long as mkinitrd does not add iSCSI stuff and network drivers to initrd. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c8
--- Comment #8 from Kai Lappalainen
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c9
Lee Duncan
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c10
Kai Lappalainen
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c11
--- Comment #11 from Lee Duncan
Lee, there is a third problem:
- mkinitrd scans only for iSCSI volumes if the iscsi daemon is running. It does not test, if the service is enabled which is IMHO also broken.
I agree with you that setup-iscsi.sh should stop scanning /etc/fstab.
Good.
Furthermore there should be a test if iscsid is actually enabled - running or not.
IMHO iscsi should only be included in the initrd image if:
- iscsi daemon is enabled (running or not while executing mkinitrd), and
- the configured volume is set "onboot"
I do not agree with this this new issue being a bug. The mkinitrd process is highly dependent on the current state of the system. For example, it only enables network devices that are configured at the time the initrd image is created. If you still feel this is a bug please file it as a separate issue (referencing this bug), and adding me on the cc list. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c12
--- Comment #12 from Lee Duncan
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c13
--- Comment #13 from Lee Duncan
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c14
--- Comment #14 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c15
--- Comment #15 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c16
Lee Duncan
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c17
--- Comment #17 from Swamp Workflow Management
https://bugzilla.novell.com/show_bug.cgi?id=826700
https://bugzilla.novell.com/show_bug.cgi?id=826700#c18
--- Comment #18 from Swamp Workflow Management
participants (1)
-
bugzilla_noreply@novell.com