[Bug 1212835] New: make modules_install fails with kmod-30-4.1
https://bugzilla.suse.com/show_bug.cgi?id=1212835 Bug ID: 1212835 Summary: make modules_install fails with kmod-30-4.1 Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Kernel Assignee: msuchanek@suse.com Reporter: ptesarik@suse.com QA Contact: qa-bugs@suse.de Target Milestone: --- Found By: --- Blocker: --- With the usrmerge patches, depmod now accesses $base/usr/lib/modules instead of $base/lib/modules. Unfortunately, scripts/depmod.sh in the kernel sources cannot cope with that and fails with a slightly confusing message: depmod: ERROR: could not open directory /srv/research/dynswiotlb-9p/usr/lib/modules/99.98.6.5.0-devel+: No such file or directory I can see how this is fixed for RPM builds (https://github.com/SUSE/kernel-source/commit/da84579e78f4c4efa5b3b910484fdae...), but I can no longer run "make modules_install" from the expanded kernel tree. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c1
--- Comment #1 from Petr Tesařík
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c2
--- Comment #2 from Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c3
--- Comment #3 from Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
Michal Koutný
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c4
--- Comment #4 from Petr Tesařík
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c5
--- Comment #5 from Michal Koutný
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c6
--- Comment #6 from Michal Suchanek
Installation is not an issue. There is a symbolic link from /lib to /usr/lib. All we need is to create a similar link in scripts/depmod.sh. Something like this:
--- a/scripts/depmod.sh +++ b/scripts/depmod.sh @@ -27,7 +27,8 @@ fi # numbers, so we cheat with a symlink here depmod_hack_needed=true tmp_dir=$(mktemp -d ${TMPDIR:-/tmp}/depmod.XXXXXX) -mkdir -p "$tmp_dir/lib/modules/$KERNELRELEASE" +mkdir -p "$tmp_dir/usr/lib/modules/$KERNELRELEASE" +ln -s usr/lib "$tmp_dir/lib" if "$DEPMOD" -b "$tmp_dir" $KERNELRELEASE 2>/dev/null; then if test -e "$tmp_dir/lib/modules/$KERNELRELEASE/modules.dep" -o \ -e "$tmp_dir/lib/modules/$KERNELRELEASE/modules.dep.bin"; then
That papers over the problem in the case the modules are not installed. Nonetheless, for upstreamable patch the aim should be to support installing modules under an arbitrary prefix. Probably the prefix should be queried from kmod because kmod supports only one prefix, and the kernel needs to use that one supported prefix. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c7
--- Comment #7 from Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
Petr Vorel
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c8
--- Comment #8 from Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c10
--- Comment #10 from Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c11
--- Comment #11 from Michal Koutný
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c12
--- Comment #12 from Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
Jan Engelhardt
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c18
Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c19
--- Comment #19 from Jan Engelhardt
Also please describe your vision how usrmerge is going to be supported in kmod.
Well certainly not by breaking the API. The linux kernel itself is known to, in general, revert patches that break public APIs. The other angle in package maintenance is that every patch adds to the complexity multiplied by the time they have to be lugged around. {at, bash, rpm} are prime examples of such sad stories, and for some patches, you also have to answer to users why the program does not behave the same as upstream. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c20
Jiri Slaby
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c21
--- Comment #21 from Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c22
--- Comment #22 from Jan Engelhardt
why we care more than about our kernel?
Well because that's good practice, especially considering that, should I be making a patch for SUSE, I'd want to test it with vanilla too. A backwards compatible way is to make kmod search multiple paths, not just one. Like $PATH perhaps. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c24
--- Comment #24 from Michal Suchanek
A backwards compatible way is to make kmod search multiple paths, not just one. Like $PATH perhaps.
See Comment #3 Also supporting modules in /lib when we want to move modules away from /lib is an anti-feature. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c27
--- Comment #27 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c30
--- Comment #30 from Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c31
Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c32
--- Comment #32 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c33
--- Comment #33 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c37
--- Comment #37 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c39
--- Comment #39 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c40
Jan Engelhardt
https://bugzilla.suse.com/show_bug.cgi?id=1212835
Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c51
--- Comment #51 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c69
--- Comment #69 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c71
--- Comment #71 from Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c72
--- Comment #72 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c73
--- Comment #73 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c74
--- Comment #74 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c75
--- Comment #75 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c76
--- Comment #76 from Maintenance Automation
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c78
--- Comment #78 from Michal Koutný
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c81
--- Comment #81 from Michal Koutný
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c82
--- Comment #82 from Seppe hoogzaad
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c84
--- Comment #84 from Michal Suchanek
https://bugzilla.suse.com/show_bug.cgi?id=1212835
https://bugzilla.suse.com/show_bug.cgi?id=1212835#c85
--- Comment #85 from Michal Suchanek
participants (1)
-
bugzilla_noreply@suse.com