https://bugzilla.novell.com/show_bug.cgi?id=440371 User mmeeks@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c2 Michael Meeks changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High --- Comment #2 from Michael Meeks 2008-10-31 04:48:05 MDT --- so; as I understand it, currently when using GDM the user always gets the system default language - so this is rather important to fix; bumping prio. Werner: this variable exists currently as GDM_LANG I believe. OTOH - writing yet more tangled shell to detect if the lang coming back from the login-shell is deliberately set to a language, and if so letting that take precedence seems just tangled and lame to me. I mean - what if they set the LANG to the same lang as /etc/sysconfig/language ? apparently it would be rather hard to detect that ;-) Could we drop this for everything except INPUT_METHOD ? sadly it seems sourcing ~/.profile directly isn't going to help either since that also includes the system default lang settings that clobbers the result. Of course - we could have some evil workaround that didn't do that in langs.sh DONT_SET_LANG_DEFAULT or something. as an eviler hack something like: grep '^export LANG=' ~/.profile # might work Ultimately though this feature seems like a lot of non-standard work, and a load of slow shell scripting on login for almost no benefit. There are perfectly good ways to set the lang in the GUI that work nicely; [ I assume the same is true of KDM ] - why add this tangled stuff too ? Ultimately, to fix the IM selection issue, I'd like to include that into the DM as well, and drop all the complex hackery here. It would be good to understand the underlying use-case a bit better & think it through more carefully as/when we have a quick-fix :-) Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c4 --- Comment #4 from Mike Fabian 2008-10-31 05:29:01 MDT --- Werner> I'm not willingly to overwrite the settings in ~/.profile as Werner> this is personal stuff set by the user its self. Yes, I also think so. If a user has enough knowledge to edit his ~/.profile to set LANG and LC_ variables, this should certainly be used with the highest priority. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c6 --- Comment #6 from Mike Fabian 2008-10-31 05:38:24 MDT --- Michael> so; as I understand it, currently when using GDM the user Michael> always gets the system default language - so this is rather Michael> important to fix; bumping prio. Currently I cannot select the language in GDM at all, see bug #435157, it is greyed out. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User jpr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c8 JP Rosevear changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sndirsch@novell.com --- Comment #8 from JP Rosevear 2008-10-31 06:03:05 MDT --- (In reply to comment #1 from Dr. Werner Fink)

Remark: If gdm overwrites LANG or not isn't known afterwards. IMHO gdm should export an additional variable like LANG_OVERRIDE to give any script sourced/executed later the possibility to detect the other value of the language variable. Maybe this could be done within /etc/X11/xdm/Xsession but only if every display manager uses the same method for commiting LANG. That is not exporting LANG but providing an option to /etc/X11/xdm/Xsession.

Read Xsession - every display manager has at least the option of passing the LANG there and having it set. The hack in the xim script renders this code in Xsession completely useless. (In reply to comment #5 from Mike Fabian)

GDM could set the INPUT_METHOD variable to any of names of the files (not directories) in /etc/X11/xim.d. If INPUT_METHOD is set, the file with that name in /etc/X11/xim.d is sourced to start an input method.

And the LANG variable would still be blown away. (In reply to comment #4 from Mike Fabian)

Werner> I'm not willingly to overwrite the settings in ~/.profile as Werner> this is personal stuff set by the user its self.

Yes, I also think so. If a user has enough knowledge to edit his ~/.profile to set LANG and LC_ variables, this should certainly be used with the highest priority.

Why? If the user selects a language in gdm different than the default, they have made a more immediate choice than ~/.profile. Even if you want this, its still broken when no language is actually in ~/.profile - because the xim script starts a bash login which sets LANG to the default variable. This is clearly not what is intended in bug 235044 - only if ~/.profile has LANG set do you want to use. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User werner@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c10 --- Comment #10 from Dr. Werner Fink 2008-10-31 06:27:31 MDT --- If the user hard codes the LANG variable in its ~/.profile it is his choise. Maybe the GDM_LANG variable should be documented to enable the user to use a boolean for set or not set the LANG variable. I've added the lines of comment #3 to lang.sh respectivly to lang.csh. AFAIK GDM is currently the only Display Manager which overrides the LANG variable. Therefore the lines should help even for the xim script as the login shells uses those two files. Only the personal profile of the user does not know about GDM_LANG ... to avoid overrides from this side one could use in /etc/X11/xim if test -n "$GDM_LANG ; then adduserenv INPUT_METHOD else adduserenv LANG LC_CTYPE LC_ALL INPUT_METHOD fi but this is the decision of Mike as hew knows more about the possiblities of the input mehtods combined with several locales. Maybe it is better to skip xim if GDM_LANG is set. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c12 --- Comment #12 from Mike Fabian 2008-10-31 07:28:12 MDT --- JP> If the user selects a language in gdm different than the default, JP> they have made a more immediate choice than ~/.profile. OK, I see your point. So if gdm sets LANG (by the way, does it set LANG or GDM_LANG?) we could detect that it is already set in xim, couldn’t we? I.e. in "adduserenv" in /etc/X11/xim set only these variables which are not already set. If they are already set for whatever reason, don’t overwrite the but use them as they are. Would that be OK? (If gdm sets GDM_LANG and not LANG, we might need to copy the value of GDM_LANG into LANG). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User werner@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c14 Dr. Werner Fink changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |stbinner@suse.de --- Comment #14 from Dr. Werner Fink 2008-10-31 07:32:15 MDT --- Do you have test my last change ... ? Btw: does KDM set the LANG variable? And if it does: is there a control variable? Stephan? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c16 --- Comment #16 from Mike Fabian 2008-10-31 07:41:19 MDT --- Werner> Do you have test my last change ... ? Not yet. If gdm sets also LANG and not only GDM_LANG and if kdm does this as well, testing for LANG instead of GDM_LANG might be better. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User jpr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c18 --- Comment #18 from JP Rosevear 2008-10-31 07:51:43 MDT --- (In reply to comment #12 from Mike Fabian)

JP> If the user selects a language in gdm different than the default, JP> they have made a more immediate choice than ~/.profile.

OK, I see your point.

So if gdm sets LANG (by the way, does it set LANG or GDM_LANG?) we could detect that it is already set in xim, couldn’t we?

It sets LANG and GDM_LANG, but more importantly in passes GDM_LANG as the second variable to Xsession - which explicitly sets LANG. Werner is listed as the author of this script. The comment is "Handle arguments given by xdm/kdm/gdm".

I.e. in "adduserenv" in /etc/X11/xim set only these variables which are not already set. If they are already set for whatever reason, don’t overwrite the but use them as they are.

It will be set no matter what I think, because Xsession is executed in a shell. adduserenv runs a bash login shell, which resets LANG to default and that value is used to replace LANG in the env (because LANG *might* have changed due to ~/.profile, but not usually).

Would that be OK?

(If gdm sets GDM_LANG and not LANG, we might need to copy the value of GDM_LANG into LANG).

The Xsession script essentially does this, since $GDM_LANG is passed to it as the second variable. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c20 --- Comment #20 from Mike Fabian 2008-10-31 08:09:18 MDT --- JP> adduserenv runs a bash login shell, which resets LANG to default the login shell doesn’t yet replace LANG in the environment, the "eval" in adduserenv does. So we still have the option here not to replace some variables in some circumstances. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User jpr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c22 --- Comment #22 from JP Rosevear 2008-10-31 08:55:18 MDT --- (In reply to comment #20 from Mike Fabian)

JP> adduserenv runs a bash login shell, which resets LANG to default

the login shell doesn’t yet replace LANG in the environment, the "eval" in adduserenv does. So we still have the option here not to replace some variables in some circumstances.

Yes, correct. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c24 --- Comment #24 from Mike Fabian 2008-10-31 09:31:03 MDT --- I just discussed with Werner and thought that checking in his code in /etc/X11/xim would be a good solution. Where is there a still conflict after adding this code? I cannot see a conflict. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User jpr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c26 --- Comment #26 from JP Rosevear 2008-10-31 11:04:52 MDT --- (In reply to comment #24 from Mike Fabian)

I just discussed with Werner and thought that checking in his code in /etc/X11/xim would be a good solution.

Where is there a still conflict after adding this code? I cannot see a conflict.

The conflict is that Xsession supports passing LANG and xim breaks it (now I guess not in the gdm case, but still..) Work around will work for now, thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c28 Mike Fabian changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|stbinner@suse.de | --- Comment #28 from Mike Fabian 2008-10-31 21:05:54 MDT --- Remove NEEDINFO to stbinner because we already know that kdm currently doesn’t pass LANG to Xsession. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User jpr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c30 --- Comment #30 from JP Rosevear 2008-11-04 02:19:19 MST --- I submitted the gdm package now after testing the aaa_base fix. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=440371 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440371#c32 Mike Fabian changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #32 from Mike Fabian 2009-01-22 04:28:20 MST --- FIXED. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.