https://bugzilla.novell.com/show_bug.cgi?id=442188 User hpj@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=442188#c2 --- Comment #2 from Hans Petter Jansson 2008-11-06 16:42:56 MST --- I was originally patching MozillaFirefox, but realized I'd have to patch xulrunner and moved the patches there. Unfortunately, I forgot to change the string. That said, the string doesn't carry any intrinsic meaning. It's just a token to prevent the database from being migrated twice. It could just as well be "foobar123". I'm afraid the only documentation to nss-shared-helper is the source code itself. It's not big, so that shouldn't be a huge problem, though. I'll submit new patches with the string changed to "mozilla-xul". -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=442188 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=442188#c4 --- Comment #4 from Wolfgang Rosenauer 2008-11-07 02:18:56 MST --- Thanks, both are accepted. Just three more notes for the next submitreq: - I propose to have a "header" in the patch file which contains who wrote the patch and what it is supposed to fix/achieve (for example see mozilla-restart-cmd.patch) - I also propose to have the spec file a bit backwards compatible and keep them usable for security updates for older distributions without a change (I fixed that this time) - and finally if you fiddle with configure.in/autoconf.mk anyway the source code changes should be #ifdef'ed as well Just my 2 cents -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.