[Bug 681952] New: ip addr add returns different error codes than before

newer
[Bug 711909] New: science: Bug...

older
[Bug 713320] New: 6.99 won't start...

bugzilla_noreply＠novell.com

23 Mar 2011 23 Mar '11

14:14

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c0 Summary: ip addr add returns different error codes than before Classification: openSUSE Product: openSUSE 11.4 Version: Final Platform: All OS/Version: Other Status: NEEDINFO Severity: Major Priority: P5 - None Component: Network AssignedTo: mt@novell.com ReportedBy: mt@novell.com QAContact: qa@suse.de InfoProvider: ms@novell.com Found By: Development Blocker: --- In any previous version (since suse ... 10.0?), ip addr add always returned the error code 2 in case the ip address is already set on the interface: # ip a s dev bond0 | grep 172 inet 172.16.2.3/24 brd 172.16.2.255 scope global bond0 # ip a a 172.16.2.3/24 dev bond0 ; echo $? RTNETLINK answers: File exists 2 On 11.4, it returns the exit code 254: # ip a s dev eth0 | grep 172 inet 172.16.1.1/24 brd 172.16.1.255 scope global eth0 # ip addr add 172.16.1.1/24 dev eth0 ; echo $? RTNETLINK answers: File exists 254 This of course causes ifup to return an error in this quite common case... Are there more changes like this / did the error reporting changed in another places too? Is this just a bug in some patch or is the new behaviour intended to be used in all further iproute2 versions? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

bugzilla_noreply＠novell.com

24 Mar 24 Mar

08:55

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c1 Marcus Schaefer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|ms@novell.com | --- Comment #1 from Marcus Schaefer 2011-03-24 08:55:10 UTC --- I'm not aware of an intentional change in the exit code handling 254 imho looks like a bug if it was 2 before -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

18 Apr 18 Apr

14:39

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c Marius Tomaschewski changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|mt@novell.com |bphilips@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

23 May 23 May

08:54

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c zj jia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zjjia@novell.com AssignedTo|bnc-team-screening@forge.pr |lnussel@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

09:09

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c Ludwig Nussel changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|lnussel@novell.com |jeffm@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

1 Jun 1 Jun

18:54

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c3 Jeff Mahoney changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jeffm@novell.com |bili@novell.com --- Comment #3 from Jeff Mahoney 2011-06-01 18:54:43 UTC --- Exit code = 254 = -2. Commit 1db61e02 introduced the change. Assigning to new iproute2 maintainer. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

2 Jun 2 Jun

10:33

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c4 Li Bin changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |NEEDINFO InfoProvider| |mt@novell.com --- Comment #4 from Li Bin 2011-06-02 10:33:35 UTC --- Marius,

...

From the patch's comment, I thought it's a new behaviour. it don't exit just wanna continue after errors in the batch mode, so that it could process the next one. If it's okay, I'll close this bug. Thanks!

commit 1db61e022d5f4318b9b236fef48be48a65e00878 Author: Michele Petrazzo - Unipex Date: Sat Mar 6 08:56:53 2010 +0000 Continue after errors in -batch Allow ip to process all the file passed with the -batch argument when is passed also the -force switch Signed-off-by: Michele Petrazzo diff --git a/ip/ipaddress.c b/ip/ipaddress.c index 3186f9c..48f7b1e 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@ -1039,7 +1039,7 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv) } if (l && matches(d, l) != 0) { fprintf(stderr, "\"dev\" (%s) must match \"label\" (%s).\n", d, l); - exit(1); + return -1; } if (peer_len == 0 && local_len) { @@ -1104,7 +1104,7 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv) } if (rtnl_talk(&rth, &req.n, 0, 0, NULL, NULL, NULL) < 0) - exit(2); + return -2; return 0; } -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

6 Jun 6 Jun

08:59

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c5 --- Comment #5 from Marius Tomaschewski 2011-06-06 08:59:02 UTC --- Created an attachment (id=433006) --> (http://bugzilla.novell.com/attachment.cgi?id=433006) Patch that should correct the error codes. The fix to not exit seems to be correct to continue in batch mode, but it (is incomplete and) breaks the normal operations because main does not catch this change. Also batch error codes are IMO broken. I've attached a hot-fix - untested. Please discuss with upstream what to do with this problem as it would make sense to make the error codes "stable" (again). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

09:03

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c6 Marius Tomaschewski changed: What |Removed |Added ---------------------------------------------------------------------------- InfoProvider|mt@novell.com |maintenance@opensuse.org --- Comment #6 from Marius Tomaschewski 2011-06-06 09:03:29 UTC --- Mr Maintenance, please decide if we need an update here -- it's needed to fix this and/or catch some false errors in sysconfig. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

11:26

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c7 Christian Dengler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cdengler@novell.com --- Comment #7 from Christian Dengler 2011-06-06 11:26:23 UTC --- I think to fix it in iproute2 is the best way. Is there any news from upstream? Will they accept it? (iproute2 +1) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

7 Jun 7 Jun

13:24

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c8 --- Comment #8 from Marcus Meissner 2011-06-07 13:24:10 UTC --- i would proceed with an upstream ready solution, so that we do not deviate in the return codes. but yes, +1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

9 Jun 9 Jun

13:33

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c9 Swamp Workflow Management changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:running:41543:low --- Comment #9 from Swamp Workflow Management 2011-06-09 13:33:46 UTC --- The SWAMPID for this issue is 41543. This issue was rated as low. Please submit fixed packages until 2011-07-07. Also create a patchinfo file using this link: https://swamp.suse.de/webswamp/wf/41543 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

13:34

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c10 Christian Dengler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|maintenance@opensuse.org | --- Comment #10 from Christian Dengler 2011-06-09 13:34:17 UTC --- update started. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

30 Jun 30 Jun

16:49

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c11 --- Comment #11 from Christian Dengler 2011-06-30 16:49:40 UTC --- Be so kind and submit the fixed sources and a patchinfo -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

20 Jul 20 Jul

10:44

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c13 Li Bin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #13 from Li Bin 2011-07-20 10:44:48 UTC --- (In reply to comment #8)

...

i would proceed with an upstream ready solution, so that we do not deviate in the return codes. but yes, +1

I subscribe the mailinglist several times but no response. Do you talk this issue with upstream. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

22 Jul 22 Jul

03:36

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c14 Li Bin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |meissner@novell.com --- Comment #14 from Li Bin 2011-07-22 03:36:46 UTC --- Marcus, Do you talk with upstream? Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

04:12

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c15 --- Comment #15 from Li Bin 2011-07-22 04:12:53 UTC --- I've talked with upstream. http://marc.info/?l=linux-netdev&m=131130743727679&w=2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

09:58

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c16 Marcus Meissner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|meissner@novell.com | --- Comment #16 from Marcus Meissner 2011-07-22 09:58:05 UTC --- I didnt. yiour mail should hopefully get it along. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

25 Jul 25 Jul

08:02

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c17 Li Bin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #17 from Li Bin 2011-07-25 08:02:15 UTC --- The upstream looks not very interesting in this issue. Anyway let's just push it in updates channel. 76914 State:new By:BinLi When:2011-07-25T09:59:46 submit: home:BinLi:branches:openSUSE:11.3:Update:Test/iproute2 -> openSUSE:11.3:Update:Test Descr: 'fix return error code(bnc#681952,swampid#41543)' 76913 State:new By:BinLi When:2011-07-25T09:59:20 submit: home:BinLi:branches:openSUSE:11.4:Update:Test/iproute2 -> openSUSE:11.4:Update:Test Descr: 'fix return error code(bnc#681952,swampid#41543)' -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

09:00

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c18 --- Comment #18 from Bernhard Wiedemann 2011-07-25 11:00:23 CEST --- This is an autogenerated message for OBS integration: This bug (681952) was mentioned in https://build.opensuse.org/request/show/76913 11.4 / iproute2 https://build.opensuse.org/request/show/76914 11.3 / iproute2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

2 Aug 2 Aug

13:45

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c Christian Dengler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

13:45

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c19 Swamp Workflow Management changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:41543:low |maint:running:41543:low | |maint:released:11.3:42340 | |maint:released:11.4:42340 --- Comment #19 from Swamp Workflow Management 2011-08-02 13:45:56 UTC --- Update released for: iproute2, iproute2-debuginfo, iproute2-debugsource, iproute2-doc, libnetlink-devel Products: openSUSE 11.3 (debug, i586, x86_64) openSUSE 11.4 (debug, i586, x86_64) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

13:46

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c Swamp Workflow Management changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:41543:low |. |maint:released:11.3:42340 | |maint:released:11.4:42340 | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

21 Aug 21 Aug

09:17

New subject: [Bug 681952] ip addr add returns different error codes than before

https://bugzilla.novell.com/show_bug.cgi?id=681952 https://bugzilla.novell.com/show_bug.cgi?id=681952#c20 Jan Engelhardt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jengelh@medozas.de --- Comment #20 from Jan Engelhardt 2011-08-21 09:17:45 UTC --- If you don't submit this to security:/netfilter/iproute2, the bug will reappear in 12.1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4636

Age (days ago)

4787

Last active (days ago)

List overview

Download

23 comments

1 participants

participants (1)

bugzilla_noreply＠novell.com

[Bug 681952] New: ip addr add returns different error codes than before

tags

participants (1)