[Bug 672045] New: hxtools sets EDITOR=mcedit
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c0 Summary: hxtools sets EDITOR=mcedit Classification: openSUSE Product: openSUSE 11.4 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: wstephenson@novell.com QAContact: qa@suse.de CC: jengelh@medozas.de Found By: --- Blocker: --- Which is intrusive, it should use a hxtools-local variable instead of messing with the system EDITOR. Alternatively hxtools shouldn't be pulled into a factory install. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c1
Jan Engelhardt
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c2
--- Comment #2 from P Linnell
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c3
Stephan Kulow
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c4
--- Comment #4 from Jan Engelhardt
1. o="$PWD"; b="%buildroot"; rm -Rf "$b"; in %install is a no no see: http://lists.opensuse.org/opensuse-packaging/2007-02/msg00005.html
Quoting the post:
If you want to do it [...]: %install rm -rf $RPM_BUILD_ROOT mkdir $RPM_BUILD_ROOT mkdir -p $RPM_BUILD_ROOT/usr ... or make install
Which the spec file does (save $RPM_BUILD_ROOT <=> %buildroot). Confused. Remove rm -Rf or not. Now just tell me which. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c5
--- Comment #5 from Jan Engelhardt
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c6
--- Comment #6 from Jan Engelhardt
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c7
--- Comment #7 from P Linnell
Remove rm -Rf or not. Now just tell me which.
Ok. Here is how the large majority of packages I see all over the place in OBS: %install nothing but install stuff %clean rm -rf %buildroot Simpler, cleaner and easier to read. %clean is *the* macro to clean the buildroot, no need to repeat... OBS automatically removes all buildroots anyways. The french have a saying: "Why prefer the simple, when the complicated will do?" :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c8
--- Comment #8 from Stephan Kulow
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c9
Jan Engelhardt
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c10
--- Comment #10 from Jan Engelhardt
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c
Marcus Meissner
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c11
Jan Engelhardt
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c12
Jan Engelhardt
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c
Jan Engelhardt
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c13
--- Comment #13 from Jan Engelhardt
Ok. Here is how the large majority of packages I see all over the place in OBS:
%install nothing but install stuff
%clean rm -rf %buildroot
Simpler, cleaner and easier to read.
But does not work very well if you reuse the BS chroot to debug and rerun rpmbuild, perhaps even with --short-circuit, before attempting a new osc build run.
%clean is *the* macro to clean the buildroot, no need to repeat... OBS automatically removes all buildroots anyways.
The french have a saying: "Why prefer the simple, when the complicated will do?" :)
Then by your very saying, why do packages even use %clean? It only makes debugging of a built software harder because it immediately kills the compiled unit. (Omitting %clean and chrooting is _the_ way to do a quick analysis as mentioned above.) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c14
--- Comment #14 from Jan Engelhardt
https://bugzilla.novell.com/show_bug.cgi?id=672045
https://bugzilla.novell.com/show_bug.cgi?id=672045#c
Jan Engelhardt
participants (1)
-
bugzilla_noreply@novell.com