https://bugzilla.novell.com/show_bug.cgi?id=350539 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c1 Jiří­ Suchomel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |casualprogrammer@yahoo.com --- Comment #1 from Jiří­ Suchomel 2008-01-03 02:17:47 MST --- Please attach the y2log with the testcase. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c3 --- Comment #3 from Jiří­ Suchomel 2008-01-03 02:54:33 MST --- Created an attachment (id=189129) --> (https://bugzilla.novell.com/attachment.cgi?id=189129) patch for /usr/share/YaST2/modules/OSRFstab.ycp Please try patching your /usr/share/YaST2/modules/OSRFstab.ycp. Than call "ycpc -c /usr/share/YaST2/modules/OSRFstab.ycp" and try again. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User casualprogrammer@yahoo.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c4 Casual J. Programmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|casualprogrammer@yahoo.com | --- Comment #4 from Casual J. Programmer 2008-01-03 03:20:49 MST --- workstation6l:/home/antonyarendt # cp /usr/share/YaST2/modules/OSRFstab.ycp /usr/share/YaST2/modules/OSRFstab.ycp.bak workstation6l:/home/antonyarendt # patch /usr/share/YaST2/modules/OSRFstab.ycp Download/bug-350539_OSRFstab.diff patching file /usr/share/YaST2/modules/OSRFstab.ycp workstation6l:/home/antonyarendt # ycpc -c /usr/share/YaST2/modules/OSRFstab.ycpcompiling to '/usr/share/YaST2/modules/OSRFstab.ybc' parsing '/usr/share/YaST2/modules/OSRFstab.ycp' modules/OSRFstab.ycp:871 [Parser] Undeclared identifier 'partition' Error Maybe I'm missing something here, I am also a _very_ casual patcher ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 Jiří­ Suchomel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189129|0 |1 is obsolete| | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User casualprogrammer@yahoo.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c7 --- Comment #7 from Casual J. Programmer 2008-01-03 04:18:24 MST --- Created an attachment (id=189144) --> (https://bugzilla.novell.com/attachment.cgi?id=189144) Screenshot for fstab suggestion #1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User casualprogrammer@yahoo.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c9 --- Comment #9 from Casual J. Programmer 2008-01-03 04:20:57 MST --- Created an attachment (id=189146) --> (https://bugzilla.novell.com/attachment.cgi?id=189146) yast2logs -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c10 --- Comment #10 from Jiří­ Suchomel 2008-01-03 05:57:31 MST --- Created an attachment (id=189173) --> (https://bugzilla.novell.com/attachment.cgi?id=189173) patch for /usr/share/YaST2/modules/OSRFstab.ycp Please patch again your OSRFstab.ycp, run ycpc, try again and attach fresh logs. This time I'm only adding some debug output to see what's going on. Thanks for testing! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User casualprogrammer@yahoo.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c11 Casual J. Programmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|casualprogrammer@yahoo.com | --- Comment #11 from Casual J. Programmer 2008-01-03 08:26:16 MST --- :-( # patch /usr/share/YaST2/modules/OSRFstab.ycp bug-350539-1_OSRFstab.diff patching file /usr/share/YaST2/modules/OSRFstab.ycp Hunk #2 FAILED at 870. 1 out of 2 hunks FAILED -- saving rejects to file /usr/share/YaST2/modules/OSRFstab.ycp.rej -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c13 Jiří­ Suchomel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189197|0 |1 is obsolete| | --- Comment #13 from Jiří­ Suchomel 2008-01-04 01:10:46 MST --- Created an attachment (id=189312) --> (https://bugzilla.novell.com/attachment.cgi?id=189312) patch for /usr/share/YaST2/modules/OSRFstab.ycp The patch was against the original (unpatched) code. Try this one, hopefully it will work. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User casualprogrammer@yahoo.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c14 Casual J. Programmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|casualprogrammer@yahoo.com | --- Comment #14 from Casual J. Programmer 2008-01-04 01:57:25 MST --- OK, now it runs, I thought I had reset to the original file from backup :-( never mind. It now suggests /media as mountpoint for /dev/sdb1, I still don't see why it suggests putting up an fstab entry for a removable drive,please explain. In the second step I maximized display it now is possible to see some difference in the mount points listed. Although still some details remain invisible. I think this window needs a slider to enable visibility of the complete line. Obviously it complains about the user space ntfs ( which is favoured by install ) and suggests the kernel ntfs file system instead. This should be checked and made identical for install and repair. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User casualprogrammer@yahoo.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c16 --- Comment #16 from Casual J. Programmer 2008-01-04 01:58:24 MST --- Created an attachment (id=189323) --> (https://bugzilla.novell.com/attachment.cgi?id=189323) Screenshot for fstab suggestion #2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c18 Jiří­ Suchomel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |fehr@novell.com --- Comment #18 from Jiří­ Suchomel 2008-01-04 02:14:22 MST --- (In reply to comment #14 from Casual J. Programmer)

I think this window needs a slider to enable visibility of the complete line.

I agree.

Obviously it complains about the user space ntfs ( which is favoured by install ) and suggests the kernel ntfs file system instead.

Thomas, why is this different? Technically, I call FileSystems::GetMountString with `ntfs parameter (= value of "detected_fs" key) and it returns the default value ("ntfs") instead of "ntfs-3g". The second issue is with mount options: FileSystems::CheckFstabOptions returns "fmask=133,dmask=022,locale=en_US.UTF-8" in the "unknown_options" entry. I assume they were generated during instalation, so I wonder why are they unknown now? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c20 --- Comment #20 from Jiří­ Suchomel 2008-01-04 02:41:52 MST --- (In reply to comment #19 from Casual J. Programmer)

Can you please eludicate on this topic from #14 also ?

"It now suggests /media as mountpoint for /dev/sdb1, I still don't see why it suggests putting up an fstab entry for a removable drive,please explain."

I was under the impression only permanent devices go into fstab.

I'll look into this as well, I hope after other issues are done. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User casualprogrammer@yahoo.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c22 --- Comment #22 from Casual J. Programmer 2008-01-04 03:24:33 MST --- @ Jiří­ Suchomel Thank you on #20 re #21 Not sure if this is what you want: hwinfo --disk | grep Features Features: Hotpluggable Features: Hotpluggable -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User fehr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c24 Thomas Fehr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fehr@novell.com Status|NEEDINFO |ASSIGNED Info Provider|fehr@novell.com | --- Comment #24 from Thomas Fehr 2008-01-07 03:35:40 MST --- ad comment #18: - Due to the added ntfs-3g driver now there are more than on possibility to mount ntfs filesystems (both "mount -t ntfs" and "mount -t ntfs-3g" should work). I can change GetMountString to return ntfs-3g if you prefer that. - The fact that some of the options show up under "Other Options" is because there are no UI-fields to set these options, all options without special UI fields show up under "Other Options", this is not new and was similar for older ntfs and vfat fstab options. ad comment #21: The property of hotplugability is not a property of a partition, but of a disk. So the key is contained in the map describing the disk, not a partition of the disk. You can get the map of a certain disk with e.g. map disk = Storage::GetDisk( Storage::GetTargetMap(), "/dev/sda" ); boolean pluggable = disk["hotpluggable"]:false; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User fehr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c26 Thomas Fehr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|fehr@novell.com | --- Comment #26 from Thomas Fehr 2008-01-07 05:12:15 MST ---

My problem with that GetMountString call is that it actually returns the default value, passed as seconf parameter. According to the function code, it looks like it _should_ return ntfs-3g so I wonder what's wrong here?

Just try with newest SVN code, it should return "ntfs-3g" now. If not I need y2log file.

I only need the way to verify if current settings in /etc/fstab are somehow correct. That's why I'm using FileSystems::CheckFstabOptions and report an error where the key "all_known" in the return map is set to false. If this case is only that you offer no configuration for extra options but they are actually at correct place, please either change the return value of CheckFstabOptions or give me other way to verify such fact.

Ah, now I see. Forgot to add "locale=", "fmask=", "dmask=" to FstabOptionRegex. Please retry with newest SVN version of FileSystems.ycp.

In the time when I need this information, I only ave the data shown in comment 21. But the map Storage::GetDisk (Storage::GetTargetMap(), part["device"]:"") (where "device" is /dev/sdd1) doesn't have hotpluggable key at all. I'm testing it on 10.3 is it some new feature?

Calling GetDisk with a partition as device argument will of course not do what you want since the device name of the disk is "/dev/sdd", not "/dev/sdd1". If you want to use a partition device name you need to call Storage::GetDiskPartititon which accepts partition devices and searches and returns the corresponding disk map from Storage BTW: The "hotpluggable" key is only present if it is true. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User fehr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c28 --- Comment #28 from Thomas Fehr 2008-01-07 05:32:11 MST --- Sorry forgot to mention that last changes module was StorageDevices.ycp -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=350539 User fehr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=350539#c30 Thomas Fehr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|fehr@novell.com | --- Comment #30 from Thomas Fehr 2008-01-07 05:59:23 MST --- I have some rudimentary tests for some aspects of fstab handling code. (see ~fehr/src/ycp/CheckFstabOptions.ycp). At least I checked that it now accepts new ntfs-3g options and GetMountString correctly returns "ntfs-3g" instead of "ntfs". As far as I see it, the option to create a mount point for devpts is not needed in yast2-repair (no idea why it is there either). The mount point for devpts is /dev/pts and this is mounted automatically in /etc/init.d/boot.localfs. So there is no influence of an entry regarding devpts contained in /etc/fstab. No idea why this entry is still added to fstab. Probably just someone forgot that it is created by yast2-storage at all. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.