https://bugzilla.novell.com/show_bug.cgi?id=666911 https://bugzilla.novell.com/show_bug.cgi?id=666911#c1 Ruediger Oertel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #1 from Ruediger Oertel 2011-01-26 09:40:18 UTC --- well, that's exactly what the source validator is about: forcing people to clean up _before_ something is submitted, especially these backup files. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=666911 https://bugzilla.novell.com/show_bug.cgi?id=666911#c3 --- Comment #3 from Hans-Peter Jansen 2011-01-26 13:17:28 UTC --- @Ruediger: nagging people about their backup files will lead to people avoid your module at all. Is that the plan? I'm using some (python hacked) local infrastructure, that automatically checks updated packages in (e.g. home:frispete:PyQt and PyQt-next projects). I managed to hide the templates as backup files (python-sip.spec.templ~ from above), as I don't want them to be published. Hence, I will never able to use the source validator on such projects. BTW, this issue is two-fold: just flagging it INVALID proves to me, that it isn't worth to report such issues in the first place. If the maintainer doesn't care, why should I? Will fix my issue locally (md /usr/lib/osc/source_validators) and shut up now. Sorry for wasting all our precious time. Pete -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=666911 https://bugzilla.novell.com/show_bug.cgi?id=666911#c5 --- Comment #5 from Hans-Peter Jansen 2011-01-27 00:45:07 UTC --- Okay, that's more to the point and much more to my taste. In the light of validating the sources of distributed packages I start to understand your intention. Yes, nobody wants backup files in src.rpms, and I support your reservations of simply removing them at some point, as this sounds like a recipe for headaches. OTOH, in the osc case, that intention regarding backup files isn't valid anymore. osc is a development tool, and keeping local backups of edited files is a sane course of action of such a tool. Even if I would use backup files conventionally only, I want them to be ignored during check in, just as does any other sane version mgmt system. I also practice a few work patterns, that _rely_ on their existence and behavior, hence I wouldn't accept any removal attempt apart from me executing rm *~. IIRC, osc already has a list of ignored patterns. Why not respect this list for the files in the project dir, when called from osc, as long as they're not part of the commit. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.