https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c1 --- Comment #1 from Iakov Karpov 2012-04-08 08:47:32 UTC --- + the same happens when switching power source (AC power to battery power and vice-versa) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c kk zhang changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkzhang@novell.com AssignedTo|bnc-team-screening@forge.pr |werner@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c3 kk zhang changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |nld10-bugs-qa@forge.provo.n |ovo.novell.com |ovell.com --- Comment #3 from kk zhang 2012-04-11 08:24:06 UTC --- Hi,could you please help to have a look this?I am not sure whether it is right to assign it to you.Feel free to reassign it.Thank you. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c4 Rafael Wysocki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |srid@rkmail.ru --- Comment #4 from Rafael Wysocki 2012-04-11 20:48:56 UTC --- How is 3. done, exactly? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c6 Rafael Wysocki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |srid@rkmail.ru --- Comment #6 from Rafael Wysocki 2012-04-12 22:03:29 UTC --- OK What happens if you suspend by "echo mem > /sys/power/state" instead of running pm-suspend? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c8 Rafael Wysocki changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|rjw@suse.com |kkzhang@suse.com --- Comment #8 from Rafael Wysocki 2012-04-13 20:41:30 UTC --- Well, it's not a kernel problem, then. Most likely, one of the scripts in /usr/lib/pm-utils/sleep.d/ does something wrong to your sysctl settings. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c Vojta Dziewięcki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c11 --- Comment #11 from Bernhard Wiedemann 2012-04-19 12:00:38 CEST --- This is an autogenerated message for OBS integration: This bug (753589) was mentioned in https://build.opensuse.org/request/show/114572 Factory / pm-utils -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c13 Stefan Seyfried changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |seife@novell.slipkontur.de --- Comment #13 from Stefan Seyfried 2012-05-30 11:00:37 CEST --- see bug 764388 for the nice side effects this crazy "sysctl -e --system" 'fix' brings. Instead of the big hammer, just resetting what was changed by the laptop-mode hook script would have been much nicer. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c15 --- Comment #15 from Vojta Dziewięcki 2012-06-04 18:12:41 UTC --- Created an attachment (id=493527) --> (http://bugzilla.novell.com/attachment.cgi?id=493527) Proposed fix Ok this might work: We remove the "crazy big hammer", but we also remove the "state_exists laptop_mode_default" test, which prevented the user-defined values from being saved most of the times and caused this bug. Now with this line removed, the script will save the values correctly upon unplugging the adapter and restore them upon plugging. Now the problem is that the powersave hooks run not only upon pugging or unplugging the ac adapter, but also on suspend and resume, and it causes trouble in this case (tested on my laptop): 1. Unplug the laptop adapter and plug it in again, the values get saved and restored correctly. 2. Change some value affected by laptop-mode hook (vm.dirty_bytes for example) 3. Suspend and wake, the values are never saved, but they are restored again to the values that had been saved before (upon unplugging the adapter). This is unwanted behaviour, since user-defined sysctl settings can be lost this way, so I propose adding on_ac_power tests upon suspend/resume, as seen in the attached patch. This way, the saved values would never be restored two times (Again, tested on my laptop - the value remained the same before and after suspend). There is no need to run "pm-powersave false" hook if the laptop is already running on ac-power, so IMO this shouldn't have any side-effects. So what do you guys think? Would this be an acceptable solution? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c17 --- Comment #17 from Bernhard Wiedemann 2012-06-21 14:00:27 CEST --- This is an autogenerated message for OBS integration: This bug (753589) was mentioned in https://build.opensuse.org/request/show/125636 Factory / pm-utils -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c19 Vojta Dziewięcki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |FIXED --- Comment #19 from Vojta Dziewięcki 2012-06-25 11:45:23 UTC --- Submitted. 12.1: sr#125700 11.4: sr#125699 Closing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c21 Fabio Scl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fa0sck@gmail.com --- Comment #21 from Fabio Scl 2012-07-04 09:44:06 UTC --- Hi, after applying pm-utils patches to my openSUSE 12.1 x86_64 (therefore now using pm-utils-1.4.1-12.25.1.x86_64) I don't know if it's just me but I noticed this put laptop on battery: ~> cat /proc/sys/vm/laptop_mode 5 OK, the same for other pm parameters then suspend/hibernate... resume: ~> cat /proc/sys/vm/laptop_mode 0 and the same for other pm parameters (link_power_management_policy, etc.) but one I think should expect: ~> cat /proc/sys/vm/laptop_mode 5 (and other param.) I modified/reverted line: resume|thaw) on_ac_power || pm-powersave false ;; with resume|thaw) on_ac_power || pm-powersave ;; in file /usr/lib/pm-utils/sleep.d/00powersave (of course) now it works as I would expect but I don't know if the workaround is good, potential drawbacks, etc. I will test more and carefully, hoping the issue is just a problem of mine. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c23 Fabio Scl changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED | --- Comment #23 from Fabio Scl 2012-07-04 12:03:28 UTC --- (In reply to comment #22)

Fabio, if you think there's a problem, please reopen the bug - closed bugs are ignored ;)

Ops -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c25 --- Comment #25 from Vojta Dziewięcki 2012-07-10 10:04:06 UTC ---

I modified/reverted line:

resume|thaw) on_ac_power || pm-powersave false ;;

with

resume|thaw) on_ac_power || pm-powersave ;;

Yeah, it should definitely be like this, I don't know why I wrote "false" there, my bad. I'll fix it in the next maintenance update, cause it's not worth doing one on it's own. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=753589 https://bugzilla.novell.com/show_bug.cgi?id=753589#c Wojtek Dziewięcki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.