[Bug 764677] New: PackageKit get the wrong package size that due to libzypp changes

newer
[Bug 771708] New: incorrect gray...

older
[Bug 660142] New: Kmail spawns new...

bugzilla_noreply＠novell.com

30 May 2012 30 May '12

09:31

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c0 Summary: PackageKit get the wrong package size that due to libzypp changes Classification: openSUSE Product: openSUSE 12.2 Version: Factory Platform: x86-64 OS/Version: openSUSE 12.2 Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: mlin@suse.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- Created an attachment (id=492931) --> (http://bugzilla.novell.com/attachment.cgi?id=492931) wrong package size in apper These days, I see apper(a package management tool for KDE) get the wrong package size from PackageKit that such as the attachment. And running "pkcon get-details" also get the weird package size, for example: kdeman@linux-c5b2:/tmp> pkcon get-details upower More than one package matches: 1. upower-0.9.16-1.1.x86_64 [@System] 2. upower-0.9.16-1.1.i586 [factory-oss] Please choose the correct package: 2 ... size: 101938176 bytes ... apparently the size looks wrong, it is not true big as pkcon said, I found the same behavior via dbus-monitor btw. Reproducible: Always Steps to Reproduce: 1.start apper(but I guess that it also can reproduce in gnome-packagekit) 2.enter any categories or check the new updates 3.watch the package size what it get Actual Results: see attachment Expected Results: valid size -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

bugzilla_noreply＠novell.com

30 May 30 May

09:40

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c1 Max Lin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mlin@suse.com --- Comment #1 from Max Lin 2012-05-30 09:40:50 UTC --- err..forgot say about libzypp changes. I saw a libzypp commit https://github.com/openSUSE/libzypp/commit/1e29b99a9dd54344ac3d7486e32b0fe98... since the return size no longer in kbytes, and packagekit zypp backend still have do size calculation as size * 1024, thus I guess it cause this problem, I guess... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

09:50

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c2 --- Comment #2 from Max Lin 2012-05-30 09:50:08 UTC --- Created an attachment (id=492937) --> (http://bugzilla.novell.com/attachment.cgi?id=492937) a simple patch to fix the size calculation I have build PacakgeKit with this patch, the patch just do that give raw size value to pk_backend_details() rather than give size * 1024, it looks fix the issue. Any comment? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

4 Jun 4 Jun

04:02

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c3 Max Lin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sreeves@suse.com --- Comment #3 from Max Lin 2012-06-04 04:02:43 UTC --- Hi Scott, I guess that you are the right man for this issue, so I added you to CC. :p Any comment? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

16 Jun 16 Jun

20:01

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c4 Dominique Leuenberger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO CC| |dimstar@opensuse.org InfoProvider| |mlin@suse.com --- Comment #4 from Dominique Leuenberger 2012-06-16 20:01:37 UTC --- If we can get a patch that can correctly identify WHICH of the API variants of libzypp is being used, I am willing to merge it. The current patch will cause issues when this PK build is being used on an 'older' version of libzypp, which does not have that change implemented yet (thus only shifting the problem). @Max,and chance to work up something like that? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

18 Jun 18 Jun

07:57

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c5 Max Lin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #492937|0 |1 is obsolete| | Status|NEEDINFO |NEW InfoProvider|mlin@suse.com | --- Comment #5 from Max Lin 2012-06-18 07:57:25 UTC --- Created an attachment (id=495099) --> (http://bugzilla.novell.com/attachment.cgi?id=495099) correct calculate package size Well, hope I didn't missed somewhere, but I could not found any function which return libzypp version, and also could not found any macro defined in devel header... so I tried another way what like I attached. Although its looks weird(check libzypp twice), but it doesn't need modify libzypp itself and works on my 12.1 and Factory machines. comment? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

20 Jun 20 Jun

16:53

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c6 Dominique Leuenberger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bnc-team-gnome@forge.provo. |dimstar@opensuse.org |novell.com | --- Comment #6 from Dominique Leuenberger 2012-06-20 16:53:19 UTC --- Thanks Max, I think that patch is as good as it gets without zypp introducing version information in its headers (which would be SO MUCH nicer :) ) I'll spin up a package with the patch included -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

19:00

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c7 --- Comment #7 from Vincent Untz 2012-06-20 19:00:36 UTC --- (From update of attachment 495099) A few comments on the patch:

...

--- a/configure.ac +++ b/configure.ac @@ -742,8 +742,16 @@ fi

if test x$enable_zypp = xyes; then PKG_CHECK_MODULES(ZYPP, libzypp >= 6.16.0) + PKG_CHECK_MODULES([LIBZYPP_RETURN_BYTES], libzypp >= 11.4.0, ZYPP_RETURN_BYTES="yes", ZYPP_RETURN_BYTES="no")

PKG_CHECK_EXISTS is better than PKG_CHECK_MODULES here. Just do: PKG_CHECK_EXISTS(libzypp >= 11.4.0, [ ZYPP_RETURN_BYTES="yes" ], [ ZYPP_RETURN_BYTES="no" ])

...

+ if test "x$ZYPP_RETURN_BYTES" = "xyes"; then + AC_DEFINE(ZYPP_RETURN_BYTES, 1, [define if libzypp return package size is bytes]) + fi +else + ZYPP_RETURN_BYTES=no fi

+AM_CONDITIONAL(ZYPP_RETURN_BYTES, test x$ZYPP_RETURN_BYTES = xyes) +

There's no need for AM_CONDITIONAL, I think. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

19:38

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c8 --- Comment #8 from Dominique Leuenberger 2012-06-20 19:38:55 UTC --- Created an attachment (id=495686) --> (http://bugzilla.novell.com/attachment.cgi?id=495686) Reworked patch, based on vuntz' comments -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

21:14

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c9 Dominique Leuenberger changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|dimstar@opensuse.org |vuntz@suse.com --- Comment #9 from Dominique Leuenberger 2012-06-20 21:14:14 UTC --- Patch integrated in SR 125578 Vincent, it would be great if you could assist in upstreaming this patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

21:33

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c10 --- Comment #10 from Vincent Untz 2012-06-20 21:33:47 UTC --- Committed upstream: https://gitorious.org/packagekit/packagekit/commit/e6191bb910bca7f47726be2ee... I guess we can close the bug? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

21 Jun 21 Jun

18:08

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c11 Dominique Leuenberger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #11 from Dominique Leuenberger 2012-06-21 18:08:31 UTC --- All done.. thanks Vincent! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

29 Jun 29 Jun

12:19

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c12 Ludwig Nussel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |badshah400@gmail.com --- Comment #12 from Ludwig Nussel 2012-06-29 14:19:30 CEST --- *** Bug 769345 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=769345 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

19 Jul 19 Jul

16:44

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c13 --- Comment #13 from Michael Andres 2012-07-19 18:44:09 CEST --- (In reply to comment #1)

...

err..forgot say about libzypp changes.

I saw a libzypp commit https://github.com/openSUSE/libzypp/commit/1e29b99a9dd54344ac3d7486e32b0fe98...

since the return size no longer in kbytes, and packagekit zypp backend still have do size calculation as size * 1024, thus I guess it cause this problem, I guess...

Actually 'no' ;) The underlying libsolv changed it's representation of size, that's why zypp::ResObject::downloadSize() was adapted. zypp::ResObject::downloadSize() always returns Byte. Unfortunately the zypp-backend is retrieving libsolv's raw attributes instead of using zypp::ResObject. That's why the backend code broke. https://github.com/openSUSE/PackageKit/pull/3 suggests a fix for this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

17:41

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c14 --- Comment #14 from Dominique Leuenberger 2012-07-19 17:41:48 UTC --- (In reply to comment #13)

...

Unfortunately the zypp-backend is retrieving libsolv's raw attributes instead of using zypp::ResObject. That's why the backend code broke.

https://github.com/openSUSE/PackageKit/pull/3 suggests a fix for this.

Just to make this clear: the submitted patch there is the one that came out from this bug report (and is currently already part of the openSUSE:Factory PackageKit package). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

17:42

New subject: [Bug 764677] PackageKit get the wrong package size that due to libzypp changes

https://bugzilla.novell.com/show_bug.cgi?id=764677 https://bugzilla.novell.com/show_bug.cgi?id=764677#c15 --- Comment #15 from Dominique Leuenberger 2012-07-19 17:42:32 UTC --- Ups.. sorry.. my bad... pull 3 is one from you... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4309

Age (days ago)

4359

Last active (days ago)

List overview

Download

15 comments

1 participants

participants (1)

bugzilla_noreply＠novell.com

[Bug 764677] New: PackageKit get the wrong package size that due to libzypp changes

tags

participants (1)