[Bug 545520] New: z88-120-174.76: pointless call to fopen
http://bugzilla.novell.com/show_bug.cgi?id=545520 Summary: z88-120-174.76: pointless call to fopen Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package z88-120-174.76 source code file z88-12.0/rni88.c function rni88 local variable is fi1. I notice the following code fi1= fopen(ci1,"w+"); if(fi1 == NULL) { wlog88n(0,LOG_NOI1); fclose(fwlo); return(AL_NOI1); } rewind(fi1); but I fail to notice any call to fclose and fi1 is unused in the rest of the routine. Suggest delete dead code to remove resource leak. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=545520
Marcus Meissner
http://bugzilla.novell.com/show_bug.cgi?id=545520
User rguenther@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=545520#c1
--- Comment #1 from Richard Guenther
participants (1)
-
bugzilla_noreply@novell.com