[Bug 244533] New: NetworkManager-{openvpn,vpnc}: wrong --datadir, --libexecdir settings
https://bugzilla.novell.com/show_bug.cgi?id=244533 Summary: NetworkManager-{openvpn,vpnc}: wrong --datadir, -- libexecdir settings Product: openSUSE 10.3 Version: Alpha 0plus Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: andreas.hanke@gmx-topmail.de QAContact: qa@suse.de NetworkManager-openvpn and NetworkManager-vpnc are both using --datadir=%{prefix}/share/%{name}. This breaks their .desktop files because /usr/share/NetworkManager/applications is not a valid place for .desktop files. --datadir=%{prefix}/share should be used. Or just leave --datadir unspecified, the autoconf default is fine. The packages are also using wrong values for --libexecdir (should be "lib" on all platforms, not "lib64") and each installing 1 icon into /opt/gnome. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=244533 ------- Comment #1 from andreas.hanke@gmx-topmail.de 2007-02-11 22:08 MST ------- Created an attachment (id=118531) --> (https://bugzilla.novell.com/attachment.cgi?id=118531&action=view) NetworkManager-openvpn.patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=244533 ------- Comment #2 from andreas.hanke@gmx-topmail.de 2007-02-11 22:08 MST ------- Created an attachment (id=118532) --> (https://bugzilla.novell.com/attachment.cgi?id=118532&action=view) NetworkManager-vpnc.patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=244533 ------- Comment #3 from andreas.hanke@gmx-topmail.de 2007-02-11 22:24 MST ------- Both patches above are missing one further line in the %files section: %dir %{_prefix}/lib/%{name} -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=244533 ------- Comment #4 from andreas.hanke@gmx-topmail.de 2007-02-11 22:42 MST ------- If you're going to do a big package cleanup, please note that the unversioned so symlinks *must* be present in the main packages because they are in fact plugins, loaded from /etc/NetworkManager/VPN/nm-*-service.name. This is most likely an upstream issue (they should use -module -avoid-version and $(pkglibdir) instead of $(libdir)), but until that is fixed, it must be packaged this way. Concerning --libexecdir, you could also use %{_prefix}/lib/NetworkManager instead of %{_prefix}/lib/%{name}. That way you don't have to create a new %dir for a single executable. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=244533 sbrabec@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |andreas.hanke@gmx-topmail.de ------- Comment #5 from sbrabec@novell.com 2007-02-12 03:24 MST ------- Are the .so files needed in Networkmanager main package case, too? (/usr/lib/libnm-util.so, /usr/lib/libnm_glib.so) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=244533 andreas.hanke@gmx-topmail.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hanke@gmx-topmail.de Status|NEEDINFO |NEW Info Provider|andreas.hanke@gmx-topmail.de| ------- Comment #6 from andreas.hanke@gmx-topmail.de 2007-02-12 03:42 MST ------- No, these are real libraries, .so symlinks can stay in NetworkManager-devel. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=244533 jpr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |tambet@novell.com |gnome@forge.provo.novell.com| -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=244533 ------- Comment #7 from andreas.hanke@gmx-topmail.de 2007-02-12 06:16 MST ------- Note that the patches above are already obsolete because the packages have been modified just now: http://lists.opensuse.org/opensuse-commit/2007-02/msg00421.html http://lists.opensuse.org/opensuse-commit/2007-02/msg00422.html Use them as a template for what I mean... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=244533#c8
Tambet Ingo
participants (1)
-
bugzilla_noreply＠novell.com