[Bug 241204] New: swsusp-for-sysvinit-2.86.diff should die
https://bugzilla.novell.com/show_bug.cgi?id=241204 Summary: swsusp-for-sysvinit-2.86.diff should die Product: openSUSE 10.3 Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: werner@novell.com ReportedBy: seife@novell.com QAContact: qa@suse.de CC: hmacht@novell.com, behlert@novell.com, pavel@novell.com, trenn@novell.com, fseidel@novell.com We patch our sysvinit to support the command "swsusp" additionally to "halt", "reboot" and "poweroff". Two reasons: - it is confusing to users. We really should guide the users to use our suspend framework that takes care of doing all the important things that need to be done around suspending. - it is using the deprecated and mostly untested reboot-syscall method. Breakage is more or less to be expected. I did not complain about this until now, because i always thought that this was implemented upstream, but today i noticed that it is explicitly patched into our sysvinit package. I think we should get rid of it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=241204 werner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |garloff@novell.com Severity|Normal |Minor Status|NEW |NEEDINFO Info Provider| |garloff@novell.com ------- Comment #1 from werner@novell.com 2007-02-02 02:26 MST ------- This patch was caused by Kurt: ------------------------------------------------------------------- Wed May 17 20:24:56 CEST 2000 - garloff@suse.de - Added software-suspend support to init. - login option of mingetty limits logname to 42 chars. ------------------------------------------------------------------- .. now question to Kurt: can I skip this or do we depend on this patch? I've looked after this patch and ported it several times to the next sysvinit version. We could also do a better intergration of this stuff into our suspend stuff (e.g not using the syscall but our framework for suspend). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=241204 garloff@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|garloff@novell.com | ------- Comment #2 from garloff@novell.com 2007-02-07 06:18 MST ------- Old patch -- amazing that it has worked for so long. Thanks for porting it, Werner!
From my point of view: We can just drop it. Pavel, if you have any objections, because you need it e.g. for testing, please speak up.
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=241204 werner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |seife@novell.com ------- Comment #3 from werner@novell.com 2007-02-09 07:20 MST ------- I'd like not to drop but to change the patch to support the new suspend method used by us. How this can be done? At least we may want to replace the ioctl with the usage of powersave and/or suspend packages. Stefan? Pavel? Holger? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=241204 seife@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|seife@novell.com | ------- Comment #4 from seife@novell.com 2007-02-10 09:15 MST ------- Basically, to emulate what we have been doing now, you'd alias "swsusp" to "echo disk > /sys/power/state". Doing it "correct" without involving a desktop environment will basically be impossible. If you absolutely want to keep the "swsusp" command, then do a "system('powersave -U')". Or link against libhal and send the apropriate command to HAL manually. It is, however, quite pointless IMO, since a proper suspend procedure involves the desktop environment as well, since the external media must be unmounted etc. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=241204 ------- Comment #5 from pavel@novell.com 2007-02-13 04:05 MST ------- Kurt: No, I have no objections, I never used it. Werner: Please just drop the patch. No need to invent _another_ mechanism of tiggering suspend. Please. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=241204 ------- Comment #6 from werner@novell.com 2007-02-13 04:11 MST ------- OK -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=241204 werner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #7 from werner@novell.com 2007-02-14 07:58 MST ------- removed -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply@novell.com