[Bug 237155] New: cairo-remove-requires-private.patch is wrong, please drop it
https://bugzilla.novell.com/show_bug.cgi?id=237155 Summary: cairo-remove-requires-private.patch is wrong, please drop it Product: openSUSE 10.3 Version: unspecified Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: andreas.hanke@gmx-topmail.de QAContact: qa@suse.de The patch cairo-remove-requires-private.patch is plain wrong, please drop it. This patch is a significant deviation from upstream behaviour and has been added because some applications (gcc?) silently and incorrectly relied on cairo.pc adding -I/usr/include/freetype2 to the --cflags output. The only installed header file in cairo-devel that #include's freetype2 headers is cairo-ft.h. But this one has its own .pc file: cairo-ft.pc. And cairo-ft.pc correctly passes -I/usr/include/freetype2 even without this patch. Whenever an application fails to build without this cairo patch, it's the application's fault! The application is using the wrong .pc file, e.g. it should be querying for cairo-ft.pc instead of cairo.pc. I've just looked at the cairo packages from Fedora and Mandriva, they are not adding such patches and their packages build fine. So I assume that the broken application has been fixed in the meantime and this workaround can be removed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=237155 andreas.hanke@gmx-topmail.de changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Major ------- Comment #1 from andreas.hanke@gmx-topmail.de 2007-01-20 14:48 MST ------- Needless to say that it has a significant impact on the entire distribution. It causes ALL GNOME packages to have direct excess dependencies on freetype2, fontconfig, glitz etc. even if they don't use it at all... exactly what Requires.private is meant to protect against. Please fix build failures *properly*. If removing this patch breaks a build, there is something wrong that needs to be patched, but it's not cairo. As an example, let's take an arbitrary GNOME application: # ldd -u -r /usr/bin/gnome-theme-manager [..] huge loads of excess bloat [...] /usr/lib/libfontconfig.so.1 /usr/lib/libfreetype.so.6 /usr/lib/libglitz.so.1 [...] more bloat [...] The three above mentioned ones can be found in ALL GNOME applications, none of them actually uses them and they can be easily avoided by killing this patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=237155 ------- Comment #2 from andreas.hanke@gmx-topmail.de 2007-01-20 15:37 MST ------- This annoying patch causes all GNOME applications on SUSE Linux to be linked against the following libraries unnecessarily: -lfreetype -lz -lfontconfig -lglitz -lm -lpng12 -lXrender -lX11 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=237155 ------- Comment #3 from andreas.hanke@gmx-topmail.de 2007-01-21 06:33 MST ------- I have built gcc and libgcj overnight against a non-patched cairo and it worked just fine. Therefore, and since cairo.pc is part of the API and distributors should never change APIs, please remove this superfluous patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=237155 jhargadon@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=237155 jhargadon@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |jhargadon@novell.com |gnome@forge.provo.novell.com| -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=237155 jhargadon@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #4 from jhargadon@novell.com 2007-01-26 11:22 MST ------- I have removed the patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com