[Bug 757656] New: libnm-glib: Several places pass uninitialized GError **
https://bugzilla.novell.com/show_bug.cgi?id=757656 https://bugzilla.novell.com/show_bug.cgi?id=757656#c0 Summary: libnm-glib: Several places pass uninitialized GError ** Classification: openSUSE Product: openSUSE 12.2 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: jeffm@suse.com QAContact: qa-bugs@suse.de Found By: Development Blocker: --- The NetworkManager libnm-glib code uses GError pointers in several places. In places where they are passed as pointers-to-pointers, the API requires that the pointer value be NULL, e.g. GError *error = NULL; While I was figuring out bnc#757655, I tried starting gnome-shell --replace and it crashed nearly immediately. The problem was a crash in vsprintf on a buffer at address 0x4545454545454545, which is the _MALLOC_PERTURB=69 effect. In nearly every case, libnm correctly initializes GError pointers but there were several places it was not - including the one I hit. I've already developed the fix and will attach the patch after I update it with the bnc. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=757656
https://bugzilla.novell.com/show_bug.cgi?id=757656#c1
--- Comment #1 from Jeff Mahoney
https://bugzilla.novell.com/show_bug.cgi?id=757656
https://bugzilla.novell.com/show_bug.cgi?id=757656#c2
--- Comment #2 from Jeff Mahoney
https://bugzilla.novell.com/show_bug.cgi?id=757656
https://bugzilla.novell.com/show_bug.cgi?id=757656#c3
--- Comment #3 from Jeff Mahoney
https://bugzilla.novell.com/show_bug.cgi?id=757656
https://bugzilla.novell.com/show_bug.cgi?id=757656#c4
Vincent Untz
https://bugzilla.novell.com/show_bug.cgi?id=757656
https://bugzilla.novell.com/show_bug.cgi?id=757656#c5
Vincent Untz
https://bugzilla.novell.com/show_bug.cgi?id=757656
https://bugzilla.novell.com/show_bug.cgi?id=757656#c6
Dominique Leuenberger
participants (1)
-
bugzilla_noreply@novell.com