https://bugzilla.novell.com/show_bug.cgi?id=409150 User kmachalkova@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=409150#c1 --- Comment #1 from Katarina Machalkova 2008-07-15 03:04:19 MDT --- This is how predicate for needed patch looks like: if ( selectable->hasCandidateObj() && selectable->candidateObj().isRelevant() ) { if ( ! selectable->candidateObj().isSatisfied() || selectable->candidateObj().status().isToBeInstalled() ) displayPatch = true; } This is a predicate for unneeded patch: if ( selectable->hasCandidateObj() && ( !selectable->candidateObj().isRelevant() || ( selectable->candidateObj().isSatisfied() && ! selectable->candidateObj().status().isToBeInstalled() ) ) ) { displayPatch = true; } You see, this is very complicated and error-prone. Moreover, if something changes in this area in libzypp, the conditions and their evaluation must be fixed on 2 (or 3) different places in 2-3 different patch selectors - qt-pkg, ncurses-pkg, and possibly gtk. It would be nice if the above part of code moved to libzypp and was accesible from package selectors (e.g. as bool ZyppSelectable->isNeeded(), isNotNeeded() functions), so next time a bug is fixed or a code adjustment is done on a single place. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=409150 User ma@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=409150#c2 Michael Andres changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ma@novell.com --- Comment #2 from Michael Andres 2008-07-16 04:46:08 MDT --- But does it need to be that complicated? Isn't it: // needed if ( selectable->fate() == Selectable::TO_INSTALL || ( selectable->hasCandidateObj() && selectable->candidateObj().isBroken() ) ) // unneeded if ( selectable->fate() != Selectable::TO_INSTALL && ( selectable->hasCandidateObj() && ! selectable->candidateObj().isBroken() ) ) Remember that there are 3 mutual exclusive states: ! isRelevant() isSatisfied() isBroken() Thus isRelevant() && ! isSatisfied() means isBroken() ! isRelevant() || isSatisfied() means ! isBroken() -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=409150 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=409150#c4 Lukas Ocilka changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |locilka@novell.com --- Comment #4 from Lukas Ocilka 2008-07-16 05:47:14 MDT --- Libzypp itself or zypp application layer is the right place for this piece of code. Maintaining one implementation is always better than maintaining three or four different ones... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.