https://bugzilla.novell.com/show_bug.cgi?id=224517 Summary: [PATCH] HAL lcd set brightness script broken for Sony laptops using sonypi module and spicctrl Product: openSUSE 10.2 Version: RC 3 Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P5 - None Component: GNOME - Platform AssignedTo: bnc-team-gnome-platform@forge.provo.novell.com ReportedBy: novell@mirell.de QAContact: qa@suse.de The hal script for setting the lcd brightness in /usr/lib/hal/scripts/linux/ contains a wrong entry to set the lcd brightness on Sony laptops using the sonypi module and spicctrl. It appears as it would have been copied from the get script and someone forget to adjust it to set the value ;) The path to the spicctrl tool is wrong aswell (/usr/bin/spicctrl on SuSE, /usr/sbin/spicctrl in script). I don't know if a symlink or change of the script should take place here but overall this bug is easy to fix and makes lcd brightness control work again on my Sony laptops. Fix below: --- /usr/lib/hal/scripts/linux/hal-system-lcd-set-brightness-linux.old 2006-11-29 16:18:02.000000000 +0100 +++ /usr/lib/hal/scripts/linux/hal-system-lcd-set-brightness-linux 2006-11-29 16:07:52.000000000 +0100 @@ -50,7 +50,7 @@ # spicctrl -B # 70 # 0..255 - value="`/usr/sbin/spicctrl -B`" + value="`/usr/sbin/spicctrl -b $value`" RETVAL=$? if [ $RETVAL != 0 ]; then echo "org.freedesktop.Hal.Device.LaptopPanel.NotSupported" >&2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.