[opensuse-arm] i fixed package go for armv6, whom to tell?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 hi, i fixed the package go for armv6, whom should i tell to fix it in the offical repo? please contact me for an explanation, as this "fix" has an issue which needs to be documented. see the armv6l.patch and the go.spec: https://build.opensuse.org/package/show/home:ProhtMeyhet:branches:devel:lang... - -- Sebastian Kratz @ProhtMeyhet -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBCgAGBQJURlA0AAoJEPy7f1qF9ovTm2AQAJzQzBi3pvgKgVw5wUR4EGsu V2jXgap/RLRCo6yfXS0DIzTMFr95TPYrRutz20RZI8BuSR7XX1c4RcfRiBQ5bEZz fW4s4cAY1przmatDepWY1SC/npRMGDK0NFTwndTMXa0W6eDDO6hI1ifshwDY8Dwz fG8QFlUYLkr/airx8dC9rhwjXwrCtieqly7GbhqJ5YrDrOT9I/Cy9c1t+QpeLqzG 9pE6F4m0yqHjte7uDKaNeiozg2RluOtc3kYSKiOCkKgTBVpzbFaqERC4LBorNewJ NY+Bw50Qi+CHP+zaVkWC6kLkP0egOif6fmnFzPaDAQtpx0QdTVOPmnGVxTf+riR1 Z4lETd5MhLxXGymAj3O2UOpZ2Qi9pFZQsptRAEY4rOJsfrz8MfQl66LdgF0Gwep6 G4CdWzJn4HznJ50o7AKJ3ItJG46xXLTm5iLSYm6SlPN8yXmKy2eZ1ur+NXmAWu3f gPH2+3VD/8si059uAOPUhI4fNrjNIBkVA1G0Kc4dbRJwnFcxjD1Bb+MQMs1kTlXk rPT28PuqvWLVkXTe9owNbfBdbTGVX2QqEqjXaAjHzEe4zd8UAZS3Xemo/mZce7uD 57Dkn2Vh53KxvIvHB3rRIrjIWYfLKzueWIgwTOKMqs2RGiRXMJmc4vIp7Ena3jRt 7KgMITQ9GMH8RezBR8gh =NCXC -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-arm+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-arm+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 21.10.14 14:23, Sebastian Kratz wrote:
hi,
i fixed the package go for armv6, whom should i tell to fix it in the offical repo?
please contact me for an explanation, as this "fix" has an issue which needs to be documented.
It's usually best to document the patch inside of the patch file itself. That way the explanation why this is needed won't disappear over time. Also, you probably want to apply this patch always and have a C-style #ifdef for armv6 around it if it only applied for armv6. As for how to fix it in the official repo, there are 2 things to kick off now 1) submit the patch to the upstream go project 2) do "osc sr" and create a submit requet against devel:languages:go that way Thanks a lot for your work on this :) Alex -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: GPGTools - http://gpgtools.org iQIcBAEBAgAGBQJURlLpAAoJECszeR4D/txgMX4QAJWZAoJSco3bC9YBtJm/Yl/k 3oi5cxizF5YzqIq9bLtFCerhEhuXW0Qf82OMlN7GjbfwrxcNQCZUwysTGs5DXhpR LDbW581klzw/yQxs9AV+/VJDhmDMtwFmZJFKIREMiNmX0x2K5jjckYqNW00Y4BBM QelWfcXEwzLLOJ4YgfGlNJ6FVD4AJ+yur3l91z7pVxjJYbP8cEKt++W40EMqhjyz CfrLapxsxTHhaTUAeZjY+z0MDh1Jg4y2JceA5uPtneEtGzE95FTSpdhnvPzCR3ev V21YCY2Dl7KaHvs2caZKg4mJEKlXLcHgLbIbT7UBFPmeE7P50Ah/SKaxQNFvg4y+ 7RUjpJVbVbgPrO55saFYmFagxrWO3mGznNr4AgmYaJlMudX0u2pECTa/pWtRRlWj 6ljlgqyuato1N9dDmRu8uhd/MH6VN2AJixNMW0BDw1ygV1BKcBk9h242OMYteOsY 3I2VYDyBfWC3BeEPvfcpdUU9073kOmmqga3Uv4JNc19Mwz+OL0s3W/d+5nAtaHrY 5Kmo6Huv3jQKER/R/OkaLwxuh+nneGxT5YqFiCrxyoiSrIlnzhA0e69MjA+tkGgG CA3ryHkAchCVxV4/gtdB5K7Tp3QKd5HyaXS3KXM5L0oc4jhoyEG2feoLy3jwbsOr OljyEhH+bafqAbLm2e9r =tepc -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-arm+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-arm+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 10/21/2014 02:34 PM, Alexander Graf wrote:
On 21.10.14 14:23, Sebastian Kratz wrote:
hi,
i fixed the package go for armv6, whom should i tell to fix it in the offical repo?
please contact me for an explanation, as this "fix" has an issue which needs to be documented.
It's usually best to document the patch inside of the patch file itself. That way the explanation why this is needed won't disappear over time.
the explanation is really needed for programmers, but my fear is they won't read %description
Also, you probably want to apply this patch always and have a C-style #ifdef for armv6 around it if it only applied for armv6. As for how to fix it in the official repo, there are 2 things to kick off now
1) submit the patch to the upstream go project
thats the point, the problem is with the opensuse build system, not go itself. it seems that under qemu on armv6 the number of unix signals isn't 64 but 63. thus there is an off-by-one error while building and testing. this doesn't happen on my raspberry pi, so it might be a bug in qemu, but i can't be sure. my fix now reduces the constant defining the number of signals by 1, but that of course means signal handling won't be 100% correct.
2) do "osc sr" and create a submit requet against devel:languages:go that way
i'll try that
Thanks a lot for your work on this :)
np - -- Sebastian Kratz @ProhtMeyhet -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBCgAGBQJURll8AAoJEPy7f1qF9ovTjPwP/3T7NRGFfLauIzq1Jln0eujT /2vh93Zzal2BK7qTZxpssbGQJgjWy1QDNDQak8MIGqy9SBTZ3rlILKx1adeoCjGY g9XxIicueytTIrzQRpD/FsaJz8DTYX+i5PUnkk0tHCONUWMn7tiVXluLVMe4cAAw Fqrg9L3AkI72LV4lZIH2nBE0tTYnqQMXiD4RKjNXThX4VEKnQmO2isLMOil2T4gB I4FhW+8PjLMpWutLmsyi6gkvqEG5TeuAn17KCi2MaKP1jIhZwQB7Gzgb06JJ3S6T 5AN515W8KsM+OqXv1d8HRdgDh77fZt5x2VxYwoNQHQlOmjDnHYc2tjwQhbho1c4n R5TCuZcOmzS3qYVRhj8jEUf8vBomoO9F9kdbwUvy9ebw/3A3fMMdtdfp5A45RfWg CNTSE41ef8lMoFCnJAp8p6eJRJc93s99AXNQ5KUwpV+eSqEAslApk7LIhycuCT6l mymGMp+MOmThsI4k4plc4sBSJg/pYEOqxYgXYx2zruOxQc6LCf7WhpM9Q0mZk8+3 HQOACvGo3DIuW+jQywwig/GBfveH5/KdUnxT1nwz3fBYiqlPsTFM+ZGlsyu6K/WB DJp81lgNt1U5feuwHjYG3NQicUgrxAKarLf7fxpuDVKOzyXNvLTCjnhT72k1S8FJ sK3dgWLNCBbUxAQAOiBi =Y3K9 -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-arm+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-arm+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 21.10.14 15:02, Sebastian Kratz wrote:
On 10/21/2014 02:34 PM, Alexander Graf wrote:
On 21.10.14 14:23, Sebastian Kratz wrote:
hi,
i fixed the package go for armv6, whom should i tell to fix it in the offical repo?
please contact me for an explanation, as this "fix" has an issue which needs to be documented.
It's usually best to document the patch inside of the patch file itself. That way the explanation why this is needed won't disappear over time.
the explanation is really needed for programmers, but my fear is they won't read %description
Also, you probably want to apply this patch always and have a C-style #ifdef for armv6 around it if it only applied for armv6. As for how to fix it in the official repo, there are 2 things to kick off now
1) submit the patch to the upstream go project
thats the point, the problem is with the opensuse build system, not go itself. it seems that under qemu on armv6 the number of unix signals isn't 64 but 63. thus there is an off-by-one error while building and testing. this doesn't happen on my raspberry pi, so it might be a bug in qemu, but i can't be sure. my fix now reduces the constant defining the number of signals by 1, but that of course means signal handling won't be 100% correct.
Phew, you could also try to fix up QEMU :). What is the missing last signal? Was it introduced in a later kernel version? Alex -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: GPGTools - http://gpgtools.org iQIcBAEBAgAGBQJUV5VrAAoJECszeR4D/txgUq4P/3AOT3bS2GA3A3W88tbYu+ki jj+KMXyxCK8HUEp4W0y/jT2lVvTv7PJU342L8/rrvMXxWF3H2T9EZndleyEwl4vo fXP8Ja/+J5SuR4cqEo5Ravrt1z2XH2Q+3KbIU+1nxMgCb4xFyseKvFxFBHPRWM8g t2wc0mfHOYVjclfRfLtHE/S4+Z6Z4IXpKbeLrfihfhuITAQAxQsYX41ZNil8Kv8w somjb4SWHHQHI0RPyQ1KQiH/tHhG+wyndIfBmljnNyKyNo1jMsl8cwxKdegqc34m RUABkrREw8c7Du77/iQ9PqUTznn/ItQWrhLZ7VndMv2Nsa/mfl1Nnp+QPsJAbHCE gT9OD/6L4kzxWzZmDSg5gLLdOgehci6JITtCwyYVQtG3iQXuJDkuhRT9GIkZB6qx RP2Sva+nN2UGxKndh10jOcynLTBGlZD9Nhs/IrxmqpiWNHoHQH9lpLvigzg0UNr9 HDp6eavAlcZ0QZuiOp5SDxV5dQ6LNh7M2FudH5g3C9GQn9G7tAdpxBcKburVqyKG VBAv9xJCH+67QHc24vlb9Ei/f9a90UP3SxeSNZ1I66HZOWCRs2Tnf6TbN7d1avxu z0L7ru4IYi9F6kAmTKFbmybQdzyTUSK89uIRGKOp05rYTjiq/dWKOTu04dhKwdGc bAXcgnE/AAp2v6lYwF/U =fIR3 -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-arm+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-arm+owner@opensuse.org
participants (2)
-
Alexander Graf -
Sebastian Kratz