Mailinglist Archive: opensuse-buildservice (354 mails)

< Previous Next >
[opensuse-buildservice] Double display of filter on monitor page (PATCH)
  • From: Dirk Stoecker <opensuse@xxxxxxxxxxxx>
  • Date: Tue, 13 Feb 2007 18:33:05 +0100 (CET)
  • Message-id: <Pine.LNX.4.64.0702131830410.9583@xxxxxxxxxxxxxxxxx>
Hello,

attached a little patch to remove the double displayed monitor filter.
I also seperated the "Remove filter" from the text using []. () would be
nicer, but [] is consistent with the rest of the build service.

Ciao
--
http://www.dstoecker.eu/ (PGP key available)Index: app/views/monitor/_building.rhtml
===================================================================
--- app/views/monitor/_building.rhtml (Revision 1222)
+++ app/views/monitor/_building.rhtml (Arbeitskopie)
@@ -23,7 +23,7 @@
</div>
<p>You can filter the list in the monitor either by using the filter links in the table or by entering the project name in the editbox. In the editbox you can use partial project names.</p>
<% if @project_filter %>
- <p class="info filtered_by">Currently active filter <b><%= h(@project_filter) %></b> <%= link_to 'Remove Filter', :controller => 'monitor' %></p>
+ <p class="info filtered_by">Currently active filter <b><%= h(@project_filter) %></b> [<%= link_to 'Remove Filter', :controller => 'monitor' %>]</p>
<% end %>
<% if build_count > 0 %>
<p class="info">Hover the job time field to see the start time.</p>
Index: app/views/monitor/_building_table.rhtml
===================================================================
--- app/views/monitor/_building_table.rhtml (Revision 1222)
+++ app/views/monitor/_building_table.rhtml (Arbeitskopie)
@@ -1,9 +1,5 @@
<div id="building_list">

-<% if @project_filter and @project_filter != "" %>
- <div class="info filtered_by">Currently active filter <b><%= h(@project_filter) %></b><br /><%= link_to 'Remove Filter', :controller => 'monitor' %></div>
-<% end %>
-
<table class="building">
<thead>
<tr>
< Previous Next >
Follow Ups